From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94AE4A0540; Mon, 20 Jul 2020 00:16:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7AECB1C13A; Mon, 20 Jul 2020 00:16:14 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id BB9B21C138 for ; Mon, 20 Jul 2020 00:16:12 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 14D7E5805A0; Sun, 19 Jul 2020 18:16:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 19 Jul 2020 18:16:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 7l604mrINajGgKwTSTFJuUPOw3nt6B85yYM1WCM/AMs=; b=mMnHKzfiOr4Br+l7 CGHpzFMmixy1V5Gpfcs6BNXyZbbARCVH3F11pW3v0bPaB9WCg9vI4GjKc0yMrhgB NX3T5iksTTioNXoo7kY1GxoNvHI7hzGKqFX/hw/WCUOJpqTZ/Gx8Q1lvskzwMaSX gBAnGil67N56fqE9GYn48x9jt1GTMARyMeFqfQY106uI2XmMA1/NDCCfCO7pUs+1 OhDBQkYyUIozvbTVGp7GL3j127XAnR3fq3n8P7n0rVIRM+s0Tb+q/+YNb2wKzBws 6U39aI8FAFfuA+aNCtWP0BfbSQVqZLVZ1NPIVFOIfhf9R51ESdyI1nNuutMOimUu xQgLhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=7l604mrINajGgKwTSTFJuUPOw3nt6B85yYM1WCM/A Ms=; b=d7eVgLjeogKF5asBaFJWdEb5v+sZ3728K84466cXN0zLQwSoN/SYZSPbH TNuvfPzsi/zL+ocw91+Zc05/6bWIQlfOmqMAM5HqbKU6ytMEwtsbnVvRI3m1PaIa VNBQO4BsI6P1+xAjtO2rUsc1Ouzwrk9APl11bE0gHCWfRiRFnwVnA/QBvMmdgs5A OWxXUDm9MAVzbim6qYW7V3vFnzIrk2hthERmVW/zS1PXBK3FRomsPeVa/srpTWNV b9W7Lf7XEUySfnD4AdAa4dEE7P49inkIxvsR20cLaNIdFumz6PHAF6c22RdL6uJS 3puduhYHAHIGWJ87q78r/rKYYav6g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgedvgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5FF383280063; Sun, 19 Jul 2020 18:15:57 -0400 (EDT) From: Thomas Monjalon To: Ori Kam Cc: jerinj@marvell.com, xiang.w.wang@intel.com, matan@mellanox.com, viacheslavo@mellanox.com, John McNamara , Marko Kovacevic , Parav Pandit , Shahaf Shuler , Ray Kinsella , Neil Horman , guyk@marvell.com, dev@dpdk.org, pbhagavatula@marvell.com, hemant.agrawal@nxp.com, opher@mellanox.com, alexr@mellanox.com, dovrat@marvell.com, pkapoor@marvell.com, nipun.gupta@nxp.com, bruce.richardson@intel.com, yang.a.hong@intel.com, harry.chang@intel.com, gu.jian1@zte.com.cn, shanjiangh@chinatelecom.cn, zhangy.yun@chinatelecom.cn, lixingfu@huachentel.com, wushuai@inspur.com, yuyingxia@yxlink.com, fanchenggang@sunyainfo.com, davidfgao@tencent.com, liuzhong1@chinaunicom.cn, zhaoyong11@huawei.com, oc@yunify.com, jim@netgate.com, hongjun.ni@intel.com, deri@ntop.org, fc@napatech.com, arthur.su@lionic.com, rasland@mellanox.com, Yuval Avnery Date: Mon, 20 Jul 2020 00:15:55 +0200 Message-ID: <3058241.yiR4NS12MS@thomas> In-Reply-To: <1595182154-36508-2-git-send-email-orika@mellanox.com> References: <1593941027-86651-1-git-send-email-orika@mellanox.com> <1595182154-36508-1-git-send-email-orika@mellanox.com> <1595182154-36508-2-git-send-email-orika@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/07/2020 20:09, Ori Kam: > From: Yuval Avnery > > This commit introduce the RegEx pull mode drivers class, and > adds Mellanox RegEx PMD. [...] > --- /dev/null > +++ b/doc/guides/regexdevs/features_overview.rst > @@ -0,0 +1,100 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright 2020 Mellanox Technologies, Ltd SPDX is not aligned with the Copyright. You should not have a double space before SPDX. [...] > --- /dev/null > +++ b/doc/guides/regexdevs/index.rst > @@ -0,0 +1,15 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright 2020 Mellanox Technologies, Ltd Same here. RST annotations start at the third column. > + > +REGEX Device Drivers > +==================== > + > +The following are a list of RegEx (Regular Expression) device drivers, > +which can be used from an application through RegEx API. > + > +.. toctree:: > + :maxdepth: 2 > + :numbered: same here [...] > + Due to external dependencies, this driver is disabled in default > + configuration of the "make" build. It can be enabled with > + ``CONFIG_RTE_LIBRTE_MLX5_REGEX_PMD=y`` or by using "meson" build system which > + will detect dependencies. I would drop this part. I don't think it is an useful info, especially because make is going to be removed. > +Mellanox mlx5 PCI device can be probed by number of different pci devices, for example Inconsistency on the same line: "pci" vs "PCI". Better to break line after the comma and after a dot. > +net / vDPA / RegEx. To select the RegEx PMD ``class=regex`` should be specified > +as device parameter. This does not explain if RegEx is exclusive with other classes. [...] > +- BlueField 2 running Mellonx supported kernel. typo: Mellonx > +- Enable the RegEx caps using system call from the BlueField 2. This is a doc. Please write full words: "capabilities". [...] > +These options can be modified in the ``.config`` file. > + > +- ``CONFIG_RTE_LIBRTE_MLX5_REGEX_PMD`` (default **n**) > + > + Toggle compilation of librte_pmd_mlx5 itself. Better to drop this "make" part. [...] > enum mlx5_class { > MLX5_CLASS_INVALID, > MLX5_CLASS_NET = RTE_BIT64(0), > + MLX5_CLASS_REGEX = RTE_BIT64(2), > MLX5_CLASS_VDPA = RTE_BIT64(1), I think regex would be better sorted after vDPA. [...] > +++ b/drivers/regex/meson.build > @@ -0,0 +1,9 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2020 Mellanox Technologies, Ltd > + > +drivers = ['mlx5'] > +std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc > +std_deps += ['bus_pci'] # very many PMDs depend on PCI, so make std > +std_deps += ['bus_vdev'] # same with vdev bus I disagree about making bus some standard deps.