From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id DD354558C for ; Thu, 10 Nov 2016 15:42:15 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id u144so53108937wmu.1 for ; Thu, 10 Nov 2016 06:42:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=vh60N52A+jBq7B0RGeF34RKMP4dgGttRntXzSrwKtZM=; b=qQMEjLuJby39HwUAaXrQ7wiZWJ9p1YNN+/Rrxj0OytP5WiQ5iQUBuMU6I1H/NxEUuD O35R0iP/Lnig7AEe1HO4RdrRw3Yw0uKx3WRf9sEdACX7diJZaf4g0rEcm96xPNmAstJJ jYjTq7pomW5QYz4ln5pIy0eAF2YG7cu1fmlLuEG5QEx8dw+kc6FuxS9CT8II5Zfc1byQ mxbbLXpOPXQuXNCXPr6nd3XcyOlMKMznsH0m0w+iQyLrlQ1LPLhwwdVZlDmnkUj6i8Ie 8aLRY3Qv5wxptduwIPXHpE263YgDZsmSgKtWd2K0c5dWiUzvo092h0eA8mFRPK2j6grx +YMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=vh60N52A+jBq7B0RGeF34RKMP4dgGttRntXzSrwKtZM=; b=cg85SNF3JwTIpgb4YiXgD9g+A0CjWGl5OLD/vuqeKk1+lhAEU0k4yy9N66HQIdSfal 4Kro3Ytlpp31BV2n9judOoiIxTf4TW8HNgiFUT+VkgVfpqr41tASzqjEM2iMyH5bOY90 8DKbCYR5tslguOL3wk+eYI7ZK1Ex3OXtCXTCoC9hGzN744ICEeyk2S78r4PIzNiMuFHg vT5TcA8eXQM0tl5qF7btv3bQ9eWxD0FbVmJ41r2rKciKF69/ZNuY+4QeevbMjhNoC6ZS 64K3T5AquwvUySotxGOreIO3nZt8o7VacHMgnA+3l8W2rM5H3gPEAcN7VY3snjDu+lHe yJag== X-Gm-Message-State: ABUngvcPpWFFgDQWVsig4Ncnoih2ucjARtl8MEintDpVGDjLq54wKbRur81JHKDSmNwzac7k X-Received: by 10.194.108.131 with SMTP id hk3mr4703788wjb.102.1478788935512; Thu, 10 Nov 2016 06:42:15 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id im3sm5870869wjb.13.2016.11.10.06.42.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Nov 2016 06:42:15 -0800 (PST) From: Thomas Monjalon To: Alejandro Lucero Cc: dev@dpdk.org, Bert van Leeuwen Date: Thu, 10 Nov 2016 15:42:14 +0100 Message-ID: <3059112.zVgrzqmBCq@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1478786449-44745-1-git-send-email-alejandro.lucero@netronome.com> References: <1478786449-44745-1-git-send-email-alejandro.lucero@netronome.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: check number of queues less than RTE_ETHDEV_QUEUE_STAT_CNTRS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2016 14:42:16 -0000 2016-11-10 14:00, Alejandro Lucero: > From: Bert van Leeuwen > > A device can have more than RTE_ETHDEV_QUEUE_STAT_CNTRS queues which > is used inside struct rte_eth_stats. Ideally, DPDK should be built with > RTE_ETHDEV_QUEUE_STAT_CNTRS to the maximum number of queues a device > can support, 65536, as uint16_t is used for keeping those values for > RX and TX. But of course, having such big arrays inside struct rte_eth_stats > is not a good idea. RTE_ETHDEV_QUEUE_STAT_CNTRS come from a limitation in Intel devices. They have limited number of registers to store the stats per queue. > Current default value is 16, which could likely be changed to 32 or 64 > without too much opposition. And maybe it would be a good idea to modify > struct rte_eth_stats for allowing dynamically allocated arrays and maybe > some extra fields for keeping the array sizes. Yes and? what is your issue exactly? with which device? Please explain the idea brought by your patch.