From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6107443272; Thu, 2 Nov 2023 23:17:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43D0140262; Thu, 2 Nov 2023 23:17:46 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 3A91240144 for ; Thu, 2 Nov 2023 23:17:45 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B663C3200344; Thu, 2 Nov 2023 18:17:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 02 Nov 2023 18:17:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1698963459; x=1699049859; bh=tWiWkObPiP/py/9cpDG5meKjJjizhGbCtHS zCKJ7iGU=; b=RDWTr6nbcVLoXz9JBMSDm0HooV90LS7wgIySDbq/RCaI9rUdzIG yKJ1suzCphp0hFZhNMiJRya6fKYQL1w7W4qAn6aJ5dA4ZLFTydlQw60Gl7tHHtaE lGYvIdzss8VL516TUwO/qHXoKv/kJbYRGeXWqvWGaBtsSqbhPsn1YSbEL8VruN/i Xm8kyfO2FLJGYaqMB+KN8Hb2zhSlvY6bVZxLwLl6LMYDqrNKLV/MIqIaqK7bBbc+ QEtxPev31LN+AXu0oet/pVxdMofalhjWx901ZmWLv5Z3iXMaNHufdHNos0P96zYe vKu+I/Qvp0eFrJKReMosFCvz2U2EOFRkY8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698963459; x=1699049859; bh=tWiWkObPiP/py/9cpDG5meKjJjizhGbCtHS zCKJ7iGU=; b=A8qAJyflrGyuTNjlMVXBYGEQenbibrPJ/fwxvDSANYqc/XJ+ty4 hQeOsdPH3Mp2/cdZJrGYzhvyUtfqD5d7ha833vvdrLZeJwKkmp0PERxk5EzVRDB7 f3Z2zBsF6avLEJCz2hp+DLfk798eydHgt4/Ah5wIUaBKyHKSCM64d1P2AmHrzN2+ dZsPecUz2PRgQW0sDAsdg3H9046ZOFEUw3Pxsd4Sq5JxePp1cWNOvvS7RrCOGAAN oCjo0yhc0NXrzE6EUOSPsrs+SB4Un09wqW3cHUvgoBxSin6oZSs3Ma6f99khra11 3+lLXaI/4CMtoeNd8hcstd8rQveRNqeWrJw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddtiedgudehlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedv ieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Nov 2023 18:17:34 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Ajit Khaparde Cc: dev@dpdk.org, Aman Singh , Yuying Zhang , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Hemant Agrawal , Sachin Saxena , Simei Su , Wenjun Wu , Qi Zhang , Xiao Wang , Beilei Xing , Qiming Yang , Jiawen Wu , Jian Wang , david.marchand@redhat.com, Olivier MATZ Subject: Re: [PATCH] drivers: remove compile-time option for IEEE 1588 Date: Thu, 02 Nov 2023 23:17:32 +0100 Message-ID: <3062773.CbtlEUcBR6@thomas> In-Reply-To: References: <20230203132810.14187-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/11/2023 22:21, Ajit Khaparde: > On Thu, Nov 2, 2023 at 2:13=E2=80=AFPM Ferruh Yigit wrote: > > On 6/25/2023 4:45 PM, Thomas Monjalon wrote: > > > 23/06/2023 16:00, Ferruh Yigit: > > >> On 2/3/2023 1:28 PM, Thomas Monjalon wrote: > > >>> The option RTE_LIBRTE_IEEE1588 has no effect on any library > > >>> unlike its name. > > >>> > > >>> Also we are suppose to enable/disable features dynamically, > > >>> not at compilation time. > > >>> > > >>> And the best is that this macro is neither documented, > > >>> nor in rte_config.h. > > >>> > > >>> It looks to be a mistake keeping this flag, so it is removed, > > >>> meaning always enabled. > > >>> PS: it is disabling vector paths of some drivers. > > >>> > > >> > > >> PTP (IEEE1588) processing brings additional overhead to datapath. > > >> > > >> Agree that it is not good to have undocumented compile macro, but ju= st > > >> removing it may cause performance degradation. > > >> > > >> It may be possible to have separate burst function that supports PTP= and > > >> driver configures it when application explicitly request it with a n= ew > > >> offload flag (although it is not exactly an offload), what do you th= ink? > > > > > > The best is to enable dynamically with different functions. > > > > There was no comment from driver maintainers. If I made a baby when sending this patch, it would be a birth today. Isn't it enough time to warn maintainers? > > Perhaps better option is plan flag removal and execute it, like to > > remove the flag in 24.11 LTS, this gives enough time for drivers to upd= ate. You want to give time for one more baby? > > If this sounds good, I can send a deprecation notice to record this pla= n. > +1 Which plan? 2 babies?