From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f169.google.com (mail-we0-f169.google.com
 [74.125.82.169]) by dpdk.org (Postfix) with ESMTP id CD68DB623
 for <dev@dpdk.org>; Wed, 18 Feb 2015 02:10:11 +0100 (CET)
Received: by wesw62 with SMTP id w62so1755796wes.12
 for <dev@dpdk.org>; Tue, 17 Feb 2015 17:10:11 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=KLSLNmeZRoADQOhajbNwTYij/BAIvxJZImIRT/NeHso=;
 b=f/895KpeDh1YFvsfBUgFhpmVNkHJA9z5cTjcMTdBqSIZQKlYOvXEkF1DzMyJYYUvd6
 btMskV4BJD7NJQAkLznQ0xPJrBtVpOQFucTmWmzBnXomZX54qYk/wfy+77laRIn8mt0e
 0UaQ8NosNQBrLYk4XSu+T2teeiIu4ovZH3D9jaVPaOkov+FzvPrtL7jNJ86hvZihSs0k
 dVp88mxdo2lRFN6EBpxhT5wJ08LleauaS6DF+FtazGFDP0kZ5T+Yfa7QvatftDrcLXxg
 xs99/W5pB4xzQ9yd4Tpd1YOXTZSFkZm9eXUVMUB05HTaS/GggU5tjjZc2ItJBPe+jkg9
 zWgg==
X-Gm-Message-State: ALoCoQmzykCiAKpEPZPmSWL7C3qbrSXVXH5TodwGQOLm3abz+7OpY4RHBeAcrWphXv7OMnGdXF3r
X-Received: by 10.194.110.137 with SMTP id ia9mr3579667wjb.153.1424221811654; 
 Tue, 17 Feb 2015 17:10:11 -0800 (PST)
Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net.
 [82.235.116.147])
 by mx.google.com with ESMTPSA id cf12sm29819198wjb.10.2015.02.17.17.10.10
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 17 Feb 2015 17:10:10 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Date: Wed, 18 Feb 2015 02:09:38 +0100
Message-ID: <3062823.xy5khOG9OG@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <54E2DC82.8070901@igel.co.jp>
References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp>
 <2770102.I27SuxhSqW@xps13> <54E2DC82.8070901@igel.co.jp>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for
	unmapping igb_uio resources
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Feb 2015 01:10:12 -0000

2015-02-17 15:15, Tetsuya Mukawa:
> On 2015/02/17 10:11, Thomas Monjalon wrote:
> > 2015-02-16 13:14, Tetsuya Mukawa:
> >> +#ifdef ENABLE_HOTPLUG
> > Please avoid using #ifdef if not really necessary.
> 
> I agree with you.
> In this case, only hotplug functions call pci_unmap_resource().
> So this will be needed.

Why is it needed?