From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id E3E36231C for ; Sun, 1 Nov 2015 22:42:11 +0100 (CET) Received: by wicll6 with SMTP id ll6so39197021wic.0 for ; Sun, 01 Nov 2015 13:42:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=zxdELyTQ5qbPyQRitPX7pViTT+tKq9oRB1I92DUS2ko=; b=HxRCdZdLyqKvQBh39f19bgNgM7iYZGHElvBMECmtTO5phdVqGHI9BnELJi/wUgEwYn Ch0NUfpJ4TpkZ9SWP35I+Y6keAVPo+SIOvoIV9UgF36Xvkmfm/Rzka/PUUPX0FBmVuBQ 61OjBk7IBv9HfBztDo3LC6OERCHKbzVjftK3DRO2Jp5QKuebScDifvmCIzCCgdI3haBu enjKpPJZc5Za7Okdzg/wpVkqZQpq12hrNiaYpKXJE5+hCnkudpQKvVRlxKIgyVnTUe7+ A7c3BUo23r+VCuF6UDGpxv9ETBEmbNolVZPKK9NrIXvOBBLclJrSLKNihhmJEAqyRY+i 9tfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=zxdELyTQ5qbPyQRitPX7pViTT+tKq9oRB1I92DUS2ko=; b=JFreqq1LFOAN1j8PGOFjmVWRD7IC5Mo9PZ80v685EQLD3dAjWkGePGa4Pha3qXPlk0 KkQtcM4kEYH9H3stvoqSq/ZMSvKkf5J9zeNwwnn23igWIClNj9l0X+Yp03L6B1En/9Pv tl8bfFCVDxNF0xZZd8LE+SMF05ZnWGidPgVHx0DVUO/WuXHtBOsgO7zMvPnjKltTF7C4 tXMA9LRXl3+u1gHJa9zQgS57ejTixb2zLuDwTrQo2PotsgV3LqIAi05QUZFUdXmLR8BN RQNv3QlJJfhoOOwk1L1QiNdvSEYIlUTDULsVtMgKhVIH8bS8/b2stcuMCoVmfpEDs6nr B7HQ== X-Gm-Message-State: ALoCoQloWdww+GmdSlh8uvgLeyPei7RbRrDDLwXnA6fgOa/PTq8DKJi+kfFSI7D3yE9ioihRvRcs X-Received: by 10.194.7.97 with SMTP id i1mr22611240wja.87.1446414131757; Sun, 01 Nov 2015 13:42:11 -0800 (PST) Received: from xps13.localnet (122.26.90.92.rev.sfr.net. [92.90.26.122]) by smtp.gmail.com with ESMTPSA id m143sm14631309wmb.1.2015.11.01.13.42.10 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 01 Nov 2015 13:42:11 -0800 (PST) From: Thomas Monjalon To: Bernard Iremonger Date: Sun, 01 Nov 2015 22:41:01 +0100 Message-ID: <3062831.ssDunZgDdU@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446217733-9887-3-git-send-email-bernard.iremonger@intel.com> References: <1446217733-9887-3-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2015 21:42:12 -0000 2015-10-30 15:08, Bernard Iremonger: > +/** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */ > +#define RTE_ETH_DEV_DRV_NEED_MAPPING RTE_PCI_DRV_NEED_MAPPING > +/** Device needs to be unbound even if no module is provided */ > +#define RTE_ETH_DEV_DRV_FORCE_UNBIND RTE_PCI_DRV_FORCE_UNBIND > +/** Device supports link state interrupt */ > +#define RTE_ETH_DEV_INTR_LSC RTE_PCI_DRV_INTR_LSC > +/** Device supports detaching capability */ > +#define RTE_ETH_DEV_DETACHABLE RTE_PCI_DRV_DETACHABLE Please, use an enum which has a name and can be referenced in the API, e.g. the variable X contains some X_flags. You should not try to re-use the same values as the PCI layer since it will not be possible to map it forever when new buses will enter in the game. > +/** Device is a bonded device */ > +#define RTE_ETH_DEV_BONDED 0x0020 Why not having RTE_ETH_DEV_PCAPED? ;) Please try to remove this flag.