From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 72A8EAABF for ; Tue, 8 May 2018 16:42:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C605222E1C; Tue, 8 May 2018 10:42:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 08 May 2018 10:42:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=d7dLmjOGMrJ9d8NadTYj8JE1FH h52usuzUE4XP+0eh0=; b=VpjNrmY8/r8wbQc2hBnUic/mYt+KqWG6ZlUa5ib3HH 4u8vL4ICHFF6OWGCtSadQCCXuqCmBDvwISMCyySEurNleazPJMZxLmJ0/giGgdvR DNmKsbsoZJRdFX8Pl9VC8SXwX56jc8hVTsToKDeutXiokMPAheI8vX24jugdBcTt g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=d7dLmj OGMrJ9d8NadTYj8JE1FHh52usuzUE4XP+0eh0=; b=NOJu8/CMYQEZ27WBg26Tvb Usu2KZC8Ll01Gok1v/dK5K0Auv+eXtOUfPrKqKLN4Y8yd2oYqqarCAuyd7pYqlth oaxqRXhTZcqt4mM3shsTXGnNKin70Z0GrZZFNnl3sGBKAyhk9Nw2+F546R6hA6pm Pyfdjo1RBtp4/iNynIBXltbkyudckhXrFtjYI59l7DIBgFIUyZGm15pwDQRhaG3e 7bVWb16erhUVIVdsV37WEx3/Ha1CLS7a/LYgKBGU7bF/yqxdqrgqIO2cY3pAZs1B 0F+s9DFKe74LY1KYmYho51GevNK3Diz+1B/HWHm3Qmf7QqVbh+X6BxiH97SwHqcQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 66B87E498E; Tue, 8 May 2018 10:42:54 -0400 (EDT) From: Thomas Monjalon To: "Xu, Rosen" Cc: dev@dpdk.org, declan.doherty@intel.com, bruce.richardson@intel.com, shreyansh.jain@nxp.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, tianfei.zhang@intel.com, song.liu@intel.com, hao.wu@intel.com, gaetan.rivet@6wind.com Date: Tue, 08 May 2018 16:42:53 +0200 Message-ID: <3063017.5QX4IrYKZL@xps> In-Reply-To: <1525789143-138168-2-git-send-email-rosen.xu@intel.com> References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com> <1525789143-138168-1-git-send-email-rosen.xu@intel.com> <1525789143-138168-2-git-send-email-rosen.xu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 1/4] bus/ifpga: Add Intel FPGA BUS Library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 14:42:59 -0000 08/05/2018 16:19, Xu, Rosen: > --- /dev/null > +++ b/drivers/bus/ifpga/rte_bus_ifpga_version.map > + ifpga_get_integer32_arg; > + ifpga_get_string_arg; > + rte_ifpga_driver_register; > + rte_ifpga_driver_unregister; All exported symbols must start with rte_ > --- a/drivers/bus/meson.build > +++ b/drivers/bus/meson.build > -drivers = ['dpaa', 'fslmc', 'pci', 'vdev'] > +drivers = ['dpaa', 'fslmc', 'pci', 'vdev', 'ifpga'] Would be better sorted in alphabetical order (between fslmc and pci). Same comment in files config/common_base and drivers/bus/Makefile.