* [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size @ 2015-11-09 16:48 Nelio Laranjeiro 2015-11-09 16:48 ` [dpdk-dev] [PATCH 2/2] doc: announce ABI change for RETA configuration Nelio Laranjeiro 2015-11-10 17:29 ` [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size Mcnamara, John 0 siblings, 2 replies; 13+ messages in thread From: Nelio Laranjeiro @ 2015-11-09 16:48 UTC (permalink / raw) To: dev Current buffer size are not enough for a few testpmd commands. Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> --- doc/guides/rel_notes/deprecation.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 730c3b7..c75b4b4 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -47,3 +47,8 @@ Deprecation Notices and table action handlers will be updated: the pipeline parameter will be added, the packets mask parameter will be either removed (for input port action handler) or made input-only. + +* ABI changes are planned in cmdline buffer size to allow the use of long + commands (such as RETA update in testpmd). This should impact + CMDLINE_PARSE_RESULT_BUFSIZE, STR_TOKEN_SIZE and RDLINE_BUF_SIZE. + It should be integrated in release 2.3. -- 2.1.4 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [dpdk-dev] [PATCH 2/2] doc: announce ABI change for RETA configuration 2015-11-09 16:48 [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size Nelio Laranjeiro @ 2015-11-09 16:48 ` Nelio Laranjeiro 2015-12-14 14:25 ` Thomas Monjalon 2015-12-15 5:32 ` Lu, Wenzhuo 2015-11-10 17:29 ` [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size Mcnamara, John 1 sibling, 2 replies; 13+ messages in thread From: Nelio Laranjeiro @ 2015-11-09 16:48 UTC (permalink / raw) To: dev Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> --- doc/guides/rel_notes/deprecation.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index c75b4b4..8554c53 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -52,3 +52,8 @@ Deprecation Notices commands (such as RETA update in testpmd). This should impact CMDLINE_PARSE_RESULT_BUFSIZE, STR_TOKEN_SIZE and RDLINE_BUF_SIZE. It should be integrated in release 2.3. + +* ABI changes is planned for the reta field in struct rte_eth_rss_reta_entry64 + which handles at most 256 entries (8 bits) while newer NICs support larger + tables (512 entries). + It should be integrated in release 2.3. -- 2.1.4 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] doc: announce ABI change for RETA configuration 2015-11-09 16:48 ` [dpdk-dev] [PATCH 2/2] doc: announce ABI change for RETA configuration Nelio Laranjeiro @ 2015-12-14 14:25 ` Thomas Monjalon 2015-12-14 15:09 ` Olga Shern 2015-12-15 5:32 ` Lu, Wenzhuo 1 sibling, 1 reply; 13+ messages in thread From: Thomas Monjalon @ 2015-12-14 14:25 UTC (permalink / raw) To: Nelio Laranjeiro; +Cc: dev 2015-11-09 17:48, Nelio Laranjeiro: > +* ABI changes is planned for the reta field in struct rte_eth_rss_reta_entry64 > + which handles at most 256 entries (8 bits) while newer NICs support larger > + tables (512 entries). > + It should be integrated in release 2.3. Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] doc: announce ABI change for RETA configuration 2015-12-14 14:25 ` Thomas Monjalon @ 2015-12-14 15:09 ` Olga Shern 0 siblings, 0 replies; 13+ messages in thread From: Olga Shern @ 2015-12-14 15:09 UTC (permalink / raw) To: Thomas Monjalon, Nelio Laranjeiro; +Cc: dev Acked-by: Olga Shern <olgas@mellanox.com> -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon Sent: Monday, December 14, 2015 4:25 PM To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] doc: announce ABI change for RETA configuration 2015-11-09 17:48, Nelio Laranjeiro: > +* ABI changes is planned for the reta field in struct rte_eth_rss_reta_entry64 > + which handles at most 256 entries (8 bits) while newer NICs support larger > + tables (512 entries). > + It should be integrated in release 2.3. Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] doc: announce ABI change for RETA configuration 2015-11-09 16:48 ` [dpdk-dev] [PATCH 2/2] doc: announce ABI change for RETA configuration Nelio Laranjeiro 2015-12-14 14:25 ` Thomas Monjalon @ 2015-12-15 5:32 ` Lu, Wenzhuo 2015-12-15 6:14 ` Thomas Monjalon 1 sibling, 1 reply; 13+ messages in thread From: Lu, Wenzhuo @ 2015-12-15 5:32 UTC (permalink / raw) To: Nelio Laranjeiro, dev Hi, > -----Original Message----- > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > Sent: Tuesday, November 10, 2015 12:48 AM > To: dev@dpdk.org > Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; Mcnamara, > John <john.mcnamara@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com> > Subject: [PATCH 2/2] doc: announce ABI change for RETA configuration > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] doc: announce ABI change for RETA configuration 2015-12-15 5:32 ` Lu, Wenzhuo @ 2015-12-15 6:14 ` Thomas Monjalon 0 siblings, 0 replies; 13+ messages in thread From: Thomas Monjalon @ 2015-12-15 6:14 UTC (permalink / raw) To: Nelio Laranjeiro; +Cc: dev > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com> > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> > Acked-by: Olga Shern <olgas@mellanox.com> Applied, thanks ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size 2015-11-09 16:48 [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size Nelio Laranjeiro 2015-11-09 16:48 ` [dpdk-dev] [PATCH 2/2] doc: announce ABI change for RETA configuration Nelio Laranjeiro @ 2015-11-10 17:29 ` Mcnamara, John 2015-11-20 16:28 ` Olivier MATZ ` (2 more replies) 1 sibling, 3 replies; 13+ messages in thread From: Mcnamara, John @ 2015-11-10 17:29 UTC (permalink / raw) To: Nelio Laranjeiro, dev > -----Original Message----- > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > Sent: Monday, November 9, 2015 4:48 PM > To: dev@dpdk.org > Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; Mcnamara, John; Lu, > Wenzhuo > Subject: [PATCH 1/2] doc: announce ABI change for cmdline buffer size > > Current buffer size are not enough for a few testpmd commands. > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> Acked-by: John McNamara <john.mcnamara@intel.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size 2015-11-10 17:29 ` [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size Mcnamara, John @ 2015-11-20 16:28 ` Olivier MATZ 2015-11-20 16:33 ` Bruce Richardson 2015-12-03 16:32 ` Mcnamara, John 2015-12-14 14:13 ` Thomas Monjalon 2015-12-15 6:11 ` Thomas Monjalon 2 siblings, 2 replies; 13+ messages in thread From: Olivier MATZ @ 2015-11-20 16:28 UTC (permalink / raw) To: Mcnamara, John, Nelio Laranjeiro, dev Hi Nélio, On 11/10/2015 06:29 PM, Mcnamara, John wrote: > > >> -----Original Message----- >> From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] >> Sent: Monday, November 9, 2015 4:48 PM >> To: dev@dpdk.org >> Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; Mcnamara, John; Lu, >> Wenzhuo >> Subject: [PATCH 1/2] doc: announce ABI change for cmdline buffer size >> >> Current buffer size are not enough for a few testpmd commands. >> >> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > Acked-by: John McNamara <john.mcnamara@intel.com> > While I'm not fundamentally opposed to change the buffer size, I'm wondering if the impacted commands shouldn't be reworked to have smaller lines. 256 is already a quite big value for a line: 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345 For instance, we could change some commands to use contexts. Dummy example with reta config: testpmd> port config 0 rss reta testpmd-reta-config-0> add hash1 queue1 testpmd-reta-config-0> add hash2 queue2 testpmd-reta-config-0> del hash1 queue1 testpmd-reta-config-0> show testpmd-reta-config-0> commit testpmd> What do you think? Regards, Olivier ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size 2015-11-20 16:28 ` Olivier MATZ @ 2015-11-20 16:33 ` Bruce Richardson 2015-12-03 16:32 ` Mcnamara, John 1 sibling, 0 replies; 13+ messages in thread From: Bruce Richardson @ 2015-11-20 16:33 UTC (permalink / raw) To: Olivier MATZ; +Cc: dev On Fri, Nov 20, 2015 at 05:28:43PM +0100, Olivier MATZ wrote: > Hi Nélio, > > On 11/10/2015 06:29 PM, Mcnamara, John wrote: > > > > > >> -----Original Message----- > >> From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > >> Sent: Monday, November 9, 2015 4:48 PM > >> To: dev@dpdk.org > >> Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; Mcnamara, John; Lu, > >> Wenzhuo > >> Subject: [PATCH 1/2] doc: announce ABI change for cmdline buffer size > >> > >> Current buffer size are not enough for a few testpmd commands. > >> > >> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > > > Acked-by: John McNamara <john.mcnamara@intel.com> > > > > While I'm not fundamentally opposed to change the buffer size, > I'm wondering if the impacted commands shouldn't be reworked to > have smaller lines. 256 is already a quite big value for a line: > > 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345 > > For instance, we could change some commands to use contexts. > Dummy example with reta config: > > testpmd> port config 0 rss reta > testpmd-reta-config-0> add hash1 queue1 > testpmd-reta-config-0> add hash2 queue2 > testpmd-reta-config-0> del hash1 queue1 > testpmd-reta-config-0> show > testpmd-reta-config-0> commit > testpmd> > > What do you think? > +1 multiple shorter commands are much less error prone than a single long one. /Bruce ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size 2015-11-20 16:28 ` Olivier MATZ 2015-11-20 16:33 ` Bruce Richardson @ 2015-12-03 16:32 ` Mcnamara, John 1 sibling, 0 replies; 13+ messages in thread From: Mcnamara, John @ 2015-12-03 16:32 UTC (permalink / raw) To: Olivier MATZ, Nelio Laranjeiro, dev > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Friday, November 20, 2015 4:29 PM > To: Mcnamara, John; Nelio Laranjeiro; dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Lu, Wenzhuo > Subject: Re: [PATCH 1/2] doc: announce ABI change for cmdline buffer size > > Hi Nélio, > > On 11/10/2015 06:29 PM, Mcnamara, John wrote: > > > > > >> -----Original Message----- > >> From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > >> Sent: Monday, November 9, 2015 4:48 PM > >> To: dev@dpdk.org > >> Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; Mcnamara, > >> John; Lu, Wenzhuo > >> Subject: [PATCH 1/2] doc: announce ABI change for cmdline buffer size > >> > >> Current buffer size are not enough for a few testpmd commands. > >> > >> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > > > Acked-by: John McNamara <john.mcnamara@intel.com> > > > > While I'm not fundamentally opposed to change the buffer size, I'm > wondering if the impacted commands shouldn't be reworked to have smaller > lines. 256 is already a quite big value for a line: > > 01234567890123456789012345678901234567890123456789012345678901234567890123 > 45678901234567890123456789012345678901234567890123456789012345678901234567 > 89012345678901234567890123456789012345678901234567890123456789012345678901 > 2345678901234567890123456789012345 > > For instance, we could change some commands to use contexts. > Dummy example with reta config: > > testpmd> port config 0 rss reta > testpmd-reta-config-0> add hash1 queue1 > testpmd-reta-config-0> add hash2 queue2 > testpmd-reta-config-0> del hash1 queue1 > testpmd-reta-config-0> show > testpmd-reta-config-0> commit > testpmd> > > What do you think? Hi, I think it is a good idea but my concern is that it won't get done unless someone commits to doing it. And if they do it will be a non-trivial change since the commandline/runtime parsing in testpmd is a little crufty and it isn't set up to do this kind of sub-command parsing. Also, we will still have to maintain backward compatibility (for users and testers) with the existing single line versions of the commands. So, I'd like to make sure that this change isn't blocked on the assumption that it will be fixed with a more elegant solution if that solution is unlikely to happen. However, I do think that we should avoid bolting on every increasing options to existing testpmd commands and should instead create new commands where it makes sense. John. -- ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size 2015-11-10 17:29 ` [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size Mcnamara, John 2015-11-20 16:28 ` Olivier MATZ @ 2015-12-14 14:13 ` Thomas Monjalon 2015-12-14 14:54 ` Olga Shern 2015-12-15 6:11 ` Thomas Monjalon 2 siblings, 1 reply; 13+ messages in thread From: Thomas Monjalon @ 2015-12-14 14:13 UTC (permalink / raw) To: Mcnamara, John; +Cc: dev 2015-11-10 17:29, Mcnamara, John: > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Current buffer size are not enough for a few testpmd commands. > > > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > Acked-by: John McNamara <john.mcnamara@intel.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size 2015-12-14 14:13 ` Thomas Monjalon @ 2015-12-14 14:54 ` Olga Shern 0 siblings, 0 replies; 13+ messages in thread From: Olga Shern @ 2015-12-14 14:54 UTC (permalink / raw) To: Thomas Monjalon, Mcnamara, John; +Cc: dev Acked-by: Olga Shern <olgas@mellanox.com> -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon Sent: Monday, December 14, 2015 4:13 PM To: Mcnamara, John <john.mcnamara@intel.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size 2015-11-10 17:29, Mcnamara, John: > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Current buffer size are not enough for a few testpmd commands. > > > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > Acked-by: John McNamara <john.mcnamara@intel.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size 2015-11-10 17:29 ` [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size Mcnamara, John 2015-11-20 16:28 ` Olivier MATZ 2015-12-14 14:13 ` Thomas Monjalon @ 2015-12-15 6:11 ` Thomas Monjalon 2 siblings, 0 replies; 13+ messages in thread From: Thomas Monjalon @ 2015-12-15 6:11 UTC (permalink / raw) To: Mcnamara, John; +Cc: dev > > Current buffer size are not enough for a few testpmd commands. > > > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > Acked-by: John McNamara <john.mcnamara@intel.com> > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> > Acked-by: Olga Shern <olgas@mellanox.com> Applied, thanks ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2015-12-15 6:16 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-11-09 16:48 [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size Nelio Laranjeiro 2015-11-09 16:48 ` [dpdk-dev] [PATCH 2/2] doc: announce ABI change for RETA configuration Nelio Laranjeiro 2015-12-14 14:25 ` Thomas Monjalon 2015-12-14 15:09 ` Olga Shern 2015-12-15 5:32 ` Lu, Wenzhuo 2015-12-15 6:14 ` Thomas Monjalon 2015-11-10 17:29 ` [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size Mcnamara, John 2015-11-20 16:28 ` Olivier MATZ 2015-11-20 16:33 ` Bruce Richardson 2015-12-03 16:32 ` Mcnamara, John 2015-12-14 14:13 ` Thomas Monjalon 2015-12-14 14:54 ` Olga Shern 2015-12-15 6:11 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).