From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 041E03975 for ; Thu, 28 Aug 2014 13:58:06 +0200 (CEST) Received: by mail-wg0-f48.google.com with SMTP id n12so628122wgh.19 for ; Thu, 28 Aug 2014 05:02:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=qrVG/uknP1eE8SxMp//0BtqDs0Yi5yJ1W+GwIVWS2/c=; b=XooDyJn3ZzgIn3uM3JK0zJUH7ASZhotOftL2645M4CHx//cyTwG/hojQHWuqSLCPSU veLdhTTxOo8q8gMWjmyjcKvSCxBvWm/r0ixvw8QI8n87UdVrqtyuRTO23PM7F8st2FtJ Rh49f+rmaKYUxIm+DReRM+ytLY9jHbTdxjdIJxWairYS41L8C0kIwLUqBUGUWhNnyejE 4zizWw+PEwFW5wpz16l2l19oTlp8C7Ojnp0kp4B1Co2uy+zjL3somgZM4Xb/jBPDdXCS 12gp5effUGPz/MbclPsfPLghAXhZaJfL5GgtLIBXiPUNfD5xpzjklltPoUwFgfymkFG0 XkJA== X-Gm-Message-State: ALoCoQlJZfKtH8/x06GK1c/lCNFRaSJC7eC9rQAuXIUFAVklLonxPu0N/hngZxXPxlLHgriMXJD6 X-Received: by 10.194.89.200 with SMTP id bq8mr4730253wjb.52.1409227332456; Thu, 28 Aug 2014 05:02:12 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id u5sm34874379wia.17.2014.08.28.05.02.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Aug 2014 05:02:11 -0700 (PDT) From: Thomas Monjalon To: "Ananyev, Konstantin" Date: Thu, 28 Aug 2014 14:02:06 +0200 Message-ID: <3064205.9pGcLqH4SI@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB9772582135F37F@IRSMSX105.ger.corp.intel.com> References: <1409105634-29980-1-git-send-email-jingjing.wu@intel.com> <32773310.iMGaa2PpNO@xps13> <2601191342CEEE43887BDE71AB9772582135F37F@IRSMSX105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config functions for i40e flow director support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 11:58:06 -0000 2014-08-28 11:30, Ananyev, Konstantin: > From: Thomas Monjalon > > 2014-08-28 09:01, Wu, Jingjing: > > > I have another question: > > > If we use the way 'rx_classification_filter_ctl' works, the specific > > > structures defined in rte_i40e.h will be visible in user's application, > > > such as testpmd. > > > I know I shouldn't make commands linked with i40e like what I did before. > > > But will the i40e specific structures become visible be acceptable? > > > > I think testpmd should be limited to generic API. > > So it wouldn't be acceptable to be dependent of i40e files. > > But having some specific i40e tests in examples or app/test is OK. > > > > Probably I didn't get you right: Indeed ;) > Are you suggesting to have a new clone of testpmd for any new device > we are going to support? No. I say there shouldn't be any PMD dependency on testpmd. It means we should use only generic API. > That seems like too much hassle to me. > Plus what to do if someone would like to test configuration with two > different devices involved: ixgbe and i40e for example? ixgbe and i40e features should use the same generic API for flow director. > I suggest we keep one testpmd for all devices we support. > Of course we'll probably have to make some rework to avoid > if (strncmp(drv_name, "xxx") spread all over it. > We need to find some better way to discover/setup HW specific features. Agreed -- Thomas