From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 32C542BBC for ; Wed, 25 May 2016 19:27:11 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id n129so71527319wmn.1 for ; Wed, 25 May 2016 10:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z5fhkydmmXsOaTgCTnurzA1oFoZhDNd2diIugOdVOwI=; b=GBwUMyp2dhOUwqq9Z8JbvifNxdhRzQJNwoVZYytK8iDDrgeEmxaSfKnanHf6cHC+VY BeBa6/MwOKSK1fxBgfzYI/xkyyyZM3xn/s18eEg+bOlqpgy12PgBYj0tNuKTAcWZ9Gvi i1bmaaVVRLt6lMBnbOtSBXw4dhtCHMeAhcfQY28lck7+tDojREeYhH4dXPbtWzkRoPt/ AmP1FwGhxLJ8J/7GRly9Ba3XfK47stwfjCo0nl36C1poUyj5e7HM7FnTnyjXD8jBztFG Vpe3ZqqvMs5i5Qxzrp+GtHTonWBK5LXp4pykcRRNnan+J6LhDKsWHvSVoXoluX4qqKn8 9NDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Z5fhkydmmXsOaTgCTnurzA1oFoZhDNd2diIugOdVOwI=; b=DffVtgLT4wix+bMh8xMYHoe742mRM9pHyqFKYrGIKvZRNoaUq1Ej/hLhnK8m+pwwRF 8qXjzEBzpMOpkD6yiNYlSm8U8/Cqwo4fi8ksLRij/Kwy0vTpIkArOf2PNZJxEJ+mU/X6 2k26D0tI6YkMlbf2uN98/vrvH2O1wQBb6B4qsHlswzCCnvfaEICSdaXwSp1nq2oe6XOR y+JfeFm3ThbVpoeXToNX5BPoORgT7liAQfsuzhAoOWbFg57XtYnDFQgbMZ0Tg2Y5jzWT D+mlhs3Q/LdqXyneBieoX8QTOsCrLr4V665NyS+DV+2YyDNJPCP0LkAzsnX01upsR939 ayHw== X-Gm-Message-State: ALyK8tJkylMwnhGPEjGa5swclX17Rq44kEb+AwVOAmKgWUItWeE84IS9ZcXQC60Gmavmqzfx X-Received: by 10.28.194.4 with SMTP id s4mr4786051wmf.68.1464197230962; Wed, 25 May 2016 10:27:10 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id k127sm10393985wmf.21.2016.05.25.10.27.10 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2016 10:27:10 -0700 (PDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Jerin Jacob , harish.patil@qlogic.com, Hiroyuki Mikita Date: Wed, 25 May 2016 19:27:09 +0200 Message-ID: <3064965.ukpxY9gdBn@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <5745DA7B.2000505@intel.com> References: <1464169261-25455-1-git-send-email-jerin.jacob@caviumnetworks.com> <5745DA7B.2000505@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] qede: fix build issue in the cross-compiling mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 17:27:11 -0000 2016-05-25 18:01, Ferruh Yigit: > On 5/25/2016 10:41 AM, Jerin Jacob wrote: > > In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc > > instead of just gcc > > > > Signed-off-by: Jerin Jacob > > --- > > -ifneq (,$(filter gcc gcc48,$(CC))) > > +ifneq (,$(filter %gcc %gcc48,$(CC))) > > What about: ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > This saves adding gcc version or cross compilation related check. True! It could be used instead every occurences of "ifeq ($(CC), icc)" and so on. cc Hiroyuki Mikita It is the same issue with http://dpdk.org/patch/13013