* [dpdk-dev] [PATCH] qede: fix build issue in the cross-compiling mode
@ 2016-05-25 9:41 Jerin Jacob
2016-05-25 17:01 ` Ferruh Yigit
2016-05-26 6:12 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
0 siblings, 2 replies; 5+ messages in thread
From: Jerin Jacob @ 2016-05-25 9:41 UTC (permalink / raw)
To: dev; +Cc: harish.patil, Jerin Jacob
In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
instead of just gcc
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
drivers/net/qede/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index c9b3b1c..10ced84 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -47,7 +47,7 @@ endif
endif
endif
-ifneq (,$(filter gcc gcc48,$(CC)))
+ifneq (,$(filter %gcc %gcc48,$(CC)))
CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
CFLAGS_BASE_DRIVER += -Wno-missing-declarations
CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] qede: fix build issue in the cross-compiling mode
2016-05-25 9:41 [dpdk-dev] [PATCH] qede: fix build issue in the cross-compiling mode Jerin Jacob
@ 2016-05-25 17:01 ` Ferruh Yigit
2016-05-25 17:27 ` Thomas Monjalon
2016-05-26 6:12 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
1 sibling, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2016-05-25 17:01 UTC (permalink / raw)
To: Jerin Jacob, dev; +Cc: harish.patil
On 5/25/2016 10:41 AM, Jerin Jacob wrote:
> In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
> instead of just gcc
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> drivers/net/qede/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
> index c9b3b1c..10ced84 100644
> --- a/drivers/net/qede/Makefile
> +++ b/drivers/net/qede/Makefile
> @@ -47,7 +47,7 @@ endif
> endif
> endif
>
> -ifneq (,$(filter gcc gcc48,$(CC)))
> +ifneq (,$(filter %gcc %gcc48,$(CC)))
What about: ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
This saves adding gcc version or cross compilation related check.
> CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> CFLAGS_BASE_DRIVER += -Wno-missing-declarations
> CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] qede: fix build issue in the cross-compiling mode
2016-05-25 17:01 ` Ferruh Yigit
@ 2016-05-25 17:27 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2016-05-25 17:27 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Jerin Jacob, harish.patil, Hiroyuki Mikita
2016-05-25 18:01, Ferruh Yigit:
> On 5/25/2016 10:41 AM, Jerin Jacob wrote:
> > In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
> > instead of just gcc
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > -ifneq (,$(filter gcc gcc48,$(CC)))
> > +ifneq (,$(filter %gcc %gcc48,$(CC)))
>
> What about: ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
> This saves adding gcc version or cross compilation related check.
True!
It could be used instead every occurences of "ifeq ($(CC), icc)" and so on.
cc Hiroyuki Mikita
It is the same issue with http://dpdk.org/patch/13013
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] qede: fix build issue in the cross-compiling mode
2016-05-25 9:41 [dpdk-dev] [PATCH] qede: fix build issue in the cross-compiling mode Jerin Jacob
2016-05-25 17:01 ` Ferruh Yigit
@ 2016-05-26 6:12 ` Jerin Jacob
2016-05-26 6:36 ` Thomas Monjalon
1 sibling, 1 reply; 5+ messages in thread
From: Jerin Jacob @ 2016-05-26 6:12 UTC (permalink / raw)
To: dev; +Cc: thomas.monjalon, ferruh.yigit, h.mikita89, Jerin Jacob
In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
instead of just gcc
Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
v1..v2
Use CONFIG_RTE_TOOLCHAIN_GCC instead of regular expression in filter
---
drivers/net/qede/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index c9b3b1c..d4b1e28 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -47,7 +47,7 @@ endif
endif
endif
-ifneq (,$(filter gcc gcc48,$(CC)))
+ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
CFLAGS_BASE_DRIVER += -Wno-missing-declarations
CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] qede: fix build issue in the cross-compiling mode
2016-05-26 6:12 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
@ 2016-05-26 6:36 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2016-05-26 6:36 UTC (permalink / raw)
To: Jerin Jacob; +Cc: dev, ferruh.yigit, h.mikita89
2016-05-26 11:42, Jerin Jacob:
> In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
> instead of just gcc
>
> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
We should do the same change for clang and icc. Please check
git grep '(CC)'
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-26 6:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-25 9:41 [dpdk-dev] [PATCH] qede: fix build issue in the cross-compiling mode Jerin Jacob
2016-05-25 17:01 ` Ferruh Yigit
2016-05-25 17:27 ` Thomas Monjalon
2016-05-26 6:12 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
2016-05-26 6:36 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).