From: Thomas Monjalon <thomas@monjalon.net>
To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Cc: david.hunt@intel.com, anatoly.burakov@intel.com,
jerinj@marvell.com, radu.nicolau@intel.com, gakhil@marvell.com,
cristian.dumitrescu@intel.com, ferruh.yigit@amd.com,
konstantin.ananyev@huawei.com, dev@dpdk.org,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH v2 1/2] power: fix power library with --lcores
Date: Fri, 18 Oct 2024 12:15:57 +0200 [thread overview]
Message-ID: <3066036.BaHzMo0RvP@thomas> (raw)
In-Reply-To: <20241018033435.1305782-1-sivaprasad.tummala@amd.com>
18/10/2024 05:34, Sivaprasad Tummala:
> This commit fixes an issue in the power library
> related to using lcores mapped to different
> physical cores (--lcores option in EAL).
>
> Previously, the power library incorrectly accessed
> CPU sysfs attributes for power management, treating
> lcore IDs as CPU IDs.
> e.g. with --lcores '1@128', lcore_id '1' was interpreted
> as CPU_id instead of '128'.
>
> This patch corrects the cpu_id based on lcore and CPU
> mappings. It also constraints power management support
> for lcores mapped to multiple physical cores/threads.
>
> When multiple lcores are mapped to the same physical core,
> invoking frequency scaling APIs on any lcore will apply the
> changes effectively.
>
> v2:
> - renamed check_lcore_and_set_cpu to power_get_lcore_mapped_cpu_id
>
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> Acked-by: Huisong Li <lihuisong@huawei.com>
Applied with style edits and Fixes/Cc, thanks.
prev parent reply other threads:[~2024-10-18 10:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 13:03 [RFC PATCH " Sivaprasad Tummala
2024-07-24 13:03 ` [RFC PATCH 2/2] test/power: " Sivaprasad Tummala
2024-07-24 14:38 ` [RFC PATCH 1/2] power: " Stephen Hemminger
2024-07-24 14:39 ` Stephen Hemminger
2024-08-26 13:43 ` Tummala, Sivaprasad
2024-10-17 11:02 ` [PATCH v1 " Sivaprasad Tummala
2024-10-17 11:02 ` [PATCH v1 2/2] test/power: " Sivaprasad Tummala
2024-10-17 12:10 ` lihuisong (C)
2024-10-17 11:57 ` [PATCH v1 1/2] power: " Konstantin Ananyev
2024-10-17 12:05 ` lihuisong (C)
2024-10-18 2:52 ` Tummala, Sivaprasad
2024-10-18 3:34 ` [PATCH v2 " Sivaprasad Tummala
2024-10-18 3:34 ` [PATCH v2 2/2] test/power: " Sivaprasad Tummala
2024-10-18 10:15 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3066036.BaHzMo0RvP@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@huawei.com \
--cc=lihuisong@huawei.com \
--cc=radu.nicolau@intel.com \
--cc=sivaprasad.tummala@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).