* [dpdk-dev] [PATCH 1/2] ethdev: fix C11 extensions in exported header
@ 2017-08-04 11:56 Adrien Mazarguil
2017-08-04 11:56 ` [dpdk-dev] [PATCH 2/2] cryptodev: " Adrien Mazarguil
2017-08-04 13:37 ` [dpdk-dev] [PATCH 1/2] ethdev: " Dumitrescu, Cristian
0 siblings, 2 replies; 5+ messages in thread
From: Adrien Mazarguil @ 2017-08-04 11:56 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Cristian Dumitrescu
Fix issues reported by check-includes.sh:
rte_tm.h:473:2: error: anonymous unions are a C11 extension
[-Werror,-Wc11-extensions]
rte_tm.h:696:2: error: anonymous unions are a C11 extension
[-Werror,-Wc11-extensions]
rte_tm.h:904:2: error: anonymous unions are a C11 extension
[-Werror,-Wc11-extensions]
Fixes: 5d109deffa87 ("ethdev: add traffic management API")
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
lib/librte_ether/rte_tm.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/librte_ether/rte_tm.h b/lib/librte_ether/rte_tm.h
index a632b5c..ebbfa1e 100644
--- a/lib/librte_ether/rte_tm.h
+++ b/lib/librte_ether/rte_tm.h
@@ -50,6 +50,8 @@
#include <stdint.h>
+#include <rte_common.h>
+
#ifdef __cplusplus
extern "C" {
#endif
@@ -470,6 +472,7 @@ struct rte_tm_level_capabilities {
*/
int leaf_nodes_identical;
+ RTE_STD_C11
union {
/** Items valid only for the non-leaf nodes on this level. */
struct {
@@ -693,6 +696,7 @@ struct rte_tm_node_capabilities {
*/
uint32_t shaper_shared_n_max;
+ RTE_STD_C11
union {
/** Items valid only for non-leaf nodes. */
struct {
@@ -901,6 +905,7 @@ struct rte_tm_node_params {
/** Number of shared shaper IDs in the *shared_shaper_id* array. */
uint32_t n_shared_shapers;
+ RTE_STD_C11
union {
/** Parameters only valid for non-leaf nodes. */
struct {
--
2.1.4
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH 2/2] cryptodev: fix C11 extensions in exported header
2017-08-04 11:56 [dpdk-dev] [PATCH 1/2] ethdev: fix C11 extensions in exported header Adrien Mazarguil
@ 2017-08-04 11:56 ` Adrien Mazarguil
2017-08-04 12:41 ` De Lara Guarch, Pablo
2017-08-04 13:37 ` [dpdk-dev] [PATCH 1/2] ethdev: " Dumitrescu, Cristian
1 sibling, 1 reply; 5+ messages in thread
From: Adrien Mazarguil @ 2017-08-04 11:56 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Pablo de Lara
Fix issues reported by check-includes.sh:
rte_crypto_sym.h:586:3: error: anonymous structs are a C11 extension
[-Werror,-Wc11-extensions]
rte_crypto_sym.h:510:2: error: anonymous unions are a C11 extension
[-Werror,-Wc11-extensions]
Fixes: b59502a5e3d0 ("cryptodev: add AEAD parameters in crypto operation")
Cc: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
lib/librte_cryptodev/rte_crypto_sym.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h
index 58a33b8..0ceaa91 100644
--- a/lib/librte_cryptodev/rte_crypto_sym.h
+++ b/lib/librte_cryptodev/rte_crypto_sym.h
@@ -507,6 +507,7 @@ struct rte_crypto_sym_op {
/**< Session-less API crypto operation parameters */
};
+ RTE_STD_C11
union {
struct {
struct {
--
2.1.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] cryptodev: fix C11 extensions in exported header
2017-08-04 11:56 ` [dpdk-dev] [PATCH 2/2] cryptodev: " Adrien Mazarguil
@ 2017-08-04 12:41 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2017-08-04 12:41 UTC (permalink / raw)
To: Adrien Mazarguil, Thomas Monjalon; +Cc: dev
> -----Original Message-----
> From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com]
> Sent: Friday, August 4, 2017 12:56 PM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH 2/2] cryptodev: fix C11 extensions in exported header
>
> Fix issues reported by check-includes.sh:
>
> rte_crypto_sym.h:586:3: error: anonymous structs are a C11 extension
> [-Werror,-Wc11-extensions]
> rte_crypto_sym.h:510:2: error: anonymous unions are a C11 extension
> [-Werror,-Wc11-extensions]
>
> Fixes: b59502a5e3d0 ("cryptodev: add AEAD parameters in crypto
> operation")
> Cc: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Patch looks good, although check-git-log.sh complains about it:
Wrong tag:
Fix issues reported by check-includes.sh:
Apart from this.
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] ethdev: fix C11 extensions in exported header
2017-08-04 11:56 [dpdk-dev] [PATCH 1/2] ethdev: fix C11 extensions in exported header Adrien Mazarguil
2017-08-04 11:56 ` [dpdk-dev] [PATCH 2/2] cryptodev: " Adrien Mazarguil
@ 2017-08-04 13:37 ` Dumitrescu, Cristian
2017-08-04 23:16 ` Thomas Monjalon
1 sibling, 1 reply; 5+ messages in thread
From: Dumitrescu, Cristian @ 2017-08-04 13:37 UTC (permalink / raw)
To: Adrien Mazarguil, Thomas Monjalon; +Cc: dev
> -----Original Message-----
> From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com]
> Sent: Friday, August 4, 2017 12:56 PM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [PATCH 1/2] ethdev: fix C11 extensions in exported header
>
> Fix issues reported by check-includes.sh:
>
> rte_tm.h:473:2: error: anonymous unions are a C11 extension
> [-Werror,-Wc11-extensions]
> rte_tm.h:696:2: error: anonymous unions are a C11 extension
> [-Werror,-Wc11-extensions]
> rte_tm.h:904:2: error: anonymous unions are a C11 extension
> [-Werror,-Wc11-extensions]
>
> Fixes: 5d109deffa87 ("ethdev: add traffic management API")
> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
Acked-by: Cristian Dumitrescu <Cristian.Dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] ethdev: fix C11 extensions in exported header
2017-08-04 13:37 ` [dpdk-dev] [PATCH 1/2] ethdev: " Dumitrescu, Cristian
@ 2017-08-04 23:16 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2017-08-04 23:16 UTC (permalink / raw)
To: Adrien Mazarguil; +Cc: dev, Dumitrescu, Cristian
> > Fix issues reported by check-includes.sh:
> >
> > rte_tm.h:473:2: error: anonymous unions are a C11 extension
> > [-Werror,-Wc11-extensions]
> > rte_tm.h:696:2: error: anonymous unions are a C11 extension
> > [-Werror,-Wc11-extensions]
> > rte_tm.h:904:2: error: anonymous unions are a C11 extension
> > [-Werror,-Wc11-extensions]
> >
> > Fixes: 5d109deffa87 ("ethdev: add traffic management API")
> > Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
> Acked-by: Cristian Dumitrescu <Cristian.Dumitrescu@intel.com>
Series applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-04 23:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-04 11:56 [dpdk-dev] [PATCH 1/2] ethdev: fix C11 extensions in exported header Adrien Mazarguil
2017-08-04 11:56 ` [dpdk-dev] [PATCH 2/2] cryptodev: " Adrien Mazarguil
2017-08-04 12:41 ` De Lara Guarch, Pablo
2017-08-04 13:37 ` [dpdk-dev] [PATCH 1/2] ethdev: " Dumitrescu, Cristian
2017-08-04 23:16 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).