From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BACFA0A03; Mon, 18 Jan 2021 12:37:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07466140E35; Mon, 18 Jan 2021 12:37:43 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 2272F140DFD for ; Mon, 18 Jan 2021 12:37:40 +0100 (CET) IronPort-SDR: L1D+xa1ZAelW26wyHKj5Phc11pOJjG1/6P1lAoqayPZQO39op1FBI0CXcYw8yMp/NDGSW/Ax5m vZ8kgndAaOag== X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="175288134" X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="175288134" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 03:37:40 -0800 IronPort-SDR: hbOM/y62s9JlLTb4tZA1SBuoEVcKGAyks1fBZ7u9bhQN2F46bSWWetnezzj8Xuln3ufJ6KiUzP 3uCMBXosPqkw== X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="383537162" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.192.12]) ([10.213.192.12]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 03:37:39 -0800 To: David Marchand Cc: dev References: <9843593ce51003ea5e372a8107a96acdc01e8958.1610712939.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" Message-ID: <306a8459-0bc0-d8b8-1c78-749d68560ef6@intel.com> Date: Mon, 18 Jan 2021 11:37:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mem: improve parameter checking on memory hotplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 18-Jan-21 8:26 AM, David Marchand wrote: > On Fri, Jan 15, 2021 at 1:15 PM Anatoly Burakov > wrote: >> >> Currently, we don't check anything that comes in through memory hotplug >> subsystem using the IPC, because we always assume the data is correct. >> This is okay as anyone having access to the IPC socket would also have >> rights to crash the DPDK process through other means, but it's still a >> good practice to do parameter checking, so fix the code to do that. > > Intel CI and GHA caught an issue on 32bits builds: > https://github.com/ovsrobot/dpdk/runs/1708623050?check_suite_focus=true#step:14:558 > Yep, saw that, will fix. -- Thanks, Anatoly