From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 750E3A059F; Fri, 10 Apr 2020 17:12:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D1191C29C; Fri, 10 Apr 2020 17:12:49 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3DE371C247 for ; Fri, 10 Apr 2020 17:12:47 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id D4D175C0199; Fri, 10 Apr 2020 11:12:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 10 Apr 2020 11:12:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=4pK0636mCWvMawvrbVLxPJW4s3q+fNS7reQeZtnDlEY=; b=LuMKCbbxFqFq Gqjp+wWF6g9dx/18bwn9YIbUfQgxCqAwAEvewbNPV0e6QCCgHa8uvWtmmluB19/t aLblC+g4aLDDMrMmp784k4KWzrm3cFPVXmW0Nx2TSDWlcVGHtKDQZ9hqMjHfGCkG mLWtmPE7EyN2Ym/vD2LLfELwwlReLlQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=4pK0636mCWvMawvrbVLxPJW4s3q+fNS7reQeZtnDl EY=; b=eN4y/Xm24MnQKLv8wFOU7siIyoOl2I73wlbn1i814SuP0wqrAajNdFmI2 ulh8rG9dsPcURaY42ojrVGR/04w0JkpyWHFe3l5sx/LsQeU6JQVuHeO5zGJlkqw0 5IeXU+ejFFrfalV1zy8fitHsY9rkeGiZuxO1Zv+gRW/DQ76RSpyK37/LZOzvuWI2 R9/gC73on0Eqi6Jrbkv2tCWzxDy57JIYS855WWG91THU9qx2x8Mh9a3MMjH0+sVc nObjQEk37B9e/qcBn8hBpuuxndaMN2mctupuLFalRk6OS2riagKzbUoBfsVHMv5P mqb5d0Aujb+NKcN61oxXVd43f9rPA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvddvgdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6BDC2306005C; Fri, 10 Apr 2020 11:12:45 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Jerin Jacob Cc: Jerin Jacob , dpdk-dev , "Richardson, Bruce" , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Sunil Kumar Kori , Olivier Matz Date: Fri, 10 Apr 2020 17:12:44 +0200 Message-ID: <3071160.0WQXIW03uk@thomas> In-Reply-To: References: <20200329144342.1543749-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/04/2020 15:29, Jerin Jacob: > On Fri, Apr 10, 2020 at 6:45 PM David Marchand > wrote: > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > # In summary: > > > ~~~~~~~~~~~~~ > > > # In the existing code: > > > The trace will be emitted when > > > a) When the trace is enabled > > > AND > > > b) trace level than the global level. > > > > > > # in new suggestion > > > The trace will be emitted when > > > a) When it is enabled > > > > > > And the EAL argument will be --trace=regex/globbing, This EAL argument > > > will call rte_trace_regexp() and enable the selected tracepoints. > > > > > > The downside will be it will not be similar to log API. I am fine with > > > either way. > > > > The level notion in the traces api is artificial. > > I prefer a simple api where tracepoints state is controlled via a > > single criteria: with the new suggestion that would be names. > > So +1. > > I thought it may be helpful to replace log and I decided to pick the > level in the trace. > > Looks like the consensus is to remove "level" from Trace. I miss the plan to rework logs on top of trace. How could it be done?