From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Igor Romanov <igor.romanov@oktetlabs.ru>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices
Date: Tue, 07 Jul 2020 23:56:46 +0200 [thread overview]
Message-ID: <3073906.7FGJkFTaRg@thomas> (raw)
In-Reply-To: <BYAPR11MB31439E3827F2E116F60C16CED7660@BYAPR11MB3143.namprd11.prod.outlook.com>
07/07/2020 15:14, Van Haaren, Harry:
> From: Andrew Rybchenko <arybchenko@solarflare.com>
> > From: Igor Romanov <igor.romanov@oktetlabs.ru>
> >
> > The service core list is populated, but not used. Incorrect
> > lcore states are examined for a service.
> >
> > Use the populated list to iterate over service cores.
> >
> > Fixes: e30d d318 47d2 ("service: add mechanism for quiescing")
> > Cc: stable@dpdk.org
>
> I believe the original adding of quiescing did not have this exact bug (ids[] was used)?
> It seems to have been introduced when reworking to avoid false sharing, so fixes is:
> Fixes: e484ccddbe1b ("services: avoid false sharing on core state")
>
>
> > Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> Code change itself:
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Series applied, thanks
next prev parent reply other threads:[~2020-07-07 21:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 14:35 [dpdk-dev] [PATCH] service: fix wrong lcore indexes Andrew Rybchenko
2020-07-04 15:06 ` Honnappa Nagarahalli
2020-07-04 15:10 ` David Marchand
2020-07-06 11:09 ` Andrew Rybchenko
2020-07-06 11:05 ` [dpdk-dev] [PATCH v2 1/2] service: fix wrong lcore indices Andrew Rybchenko
2020-07-06 11:06 ` [dpdk-dev] [PATCH v2 2/2] test/service: add test for service active on two lcores Andrew Rybchenko
2020-07-07 10:45 ` [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices Andrew Rybchenko
2020-07-07 10:45 ` [dpdk-dev] [PATCH v3 2/2] test/service: add test for service active on two lcores Andrew Rybchenko
2020-07-07 13:14 ` Van Haaren, Harry
2020-07-07 19:47 ` Honnappa Nagarahalli
2020-07-07 13:14 ` [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices Van Haaren, Harry
2020-07-07 21:56 ` Thomas Monjalon [this message]
2020-07-07 19:33 ` Honnappa Nagarahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3073906.7FGJkFTaRg@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=igor.romanov@oktetlabs.ru \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).