From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E6A2A00BE; Tue, 7 Jul 2020 23:56:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF9BE1DD9A; Tue, 7 Jul 2020 23:56:52 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 290991DD93; Tue, 7 Jul 2020 23:56:51 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 0CAD2BE1; Tue, 7 Jul 2020 17:56:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 07 Jul 2020 17:56:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 16m0CUXP+JVrRd6runUsr0t7gRghi2zOZQYjjsB6bjg=; b=q+Frlfm/JfC7wnHb cN2//DbZhLMcwHoeClviefk/oatebWsBhUMiit96z/U+ybdOFwmVS2gI6lhOQ4wR f6PZU3HETO6yai/07DCMjBWu2SPOGSd8cfqTBxZXmXm89/OQJik74dF3Wwa2WlQC yenfNx3pFBnPuFA3SGYYq2ocjUApJTePKqgEqx+qef1gvklA1ukkQMj6ma6Hm9WW /t/8O5CEmohFyPY1CD6OZ9ZogJC+B6JO5x4qr0p92aV2ebmmsTH5S08C0SD/Wh0/ OuC5BMX0U4pCHO6pFlmxKuXrhHp4CO8z+/jjDILpmCdZ3t3XHkp8ghdVtHRFpMpc Q+5W2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=16m0CUXP+JVrRd6runUsr0t7gRghi2zOZQYjjsB6b jg=; b=Lb52lyyPs+iyNDAfc+O9OnsxJvHQnSaI9IUW+iZH9Q5goVHOVEc3Zpxbn A6mmrgRyaXqqJTIGMkAWGODZrxVm2QoLN+jJM0IIwCj5GFKxQgnjaavorFUrd4QK CNo+oLdPBl6yAABT4Zf7CH1rbfA8erlP7S91D8wr78Na8L/4sTH2cktkSl4GTwSx RE/54eusSdkvCTm+cA5QchkCQSFsISmbvKbDI3tdaqALLqoeI7g7gvHc7Re1HLlI +jkg+5L4frkEmipghJ+QPEHUVodjsS+Y4sK/pkyadWLJKdR1JFDVzebVyXz9ervH oXnDleqwdghGOvs/oN5MgQjw5ivEQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeigddtgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 04F5630600B2; Tue, 7 Jul 2020 17:56:47 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko , Igor Romanov Cc: "dev@dpdk.org" , "stable@dpdk.org" , "Van Haaren, Harry" Date: Tue, 07 Jul 2020 23:56:46 +0200 Message-ID: <3073906.7FGJkFTaRg@thomas> In-Reply-To: References: <1593873347-13686-1-git-send-email-arybchenko@solarflare.com> <1594118726-8421-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/07/2020 15:14, Van Haaren, Harry: > From: Andrew Rybchenko > > From: Igor Romanov > > > > The service core list is populated, but not used. Incorrect > > lcore states are examined for a service. > > > > Use the populated list to iterate over service cores. > > > > Fixes: e30d d318 47d2 ("service: add mechanism for quiescing") > > Cc: stable@dpdk.org > > I believe the original adding of quiescing did not have this exact bug (ids[] was used)? > It seems to have been introduced when reworking to avoid false sharing, so fixes is: > Fixes: e484ccddbe1b ("services: avoid false sharing on core state") > > > > Signed-off-by: Igor Romanov > > Signed-off-by: Andrew Rybchenko > > Code change itself: > Acked-by: Harry van Haaren Series applied, thanks