From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 885DC2C39; Sun, 5 Aug 2018 02:15:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 17E6F21F3E; Sat, 4 Aug 2018 20:15:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 04 Aug 2018 20:15:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=vtkWCpjrCiRH6JBzjBusY1pRa1 1G3ACJY4EpK0y1RbE=; b=MLUjhUBnZ/xdy8zleLM/7eTiiMFFPMdttxs3X+41Y9 7SoBw6I9MiNSburk3VU92LOzYkAnpZIHsflFA5xdzwrdS4/CaZcv8ebiom8OCY4y mLAk8q8K645Z4p5842152V2H1b5AKmphnNMD39sBR8skvrriTqSeDJ4qeG4mxQIZ s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=vtkWCp jrCiRH6JBzjBusY1pRa11G3ACJY4EpK0y1RbE=; b=nGf2xUnts/Z0IFhAkCK3Hd aJIAyyxCRDUqSzy5wRENjZxd1NuTrGsk0UXd6vahsz6RPaShxtx9ukZlKrOw4oQG WlSzbr9Jz1Tr2UDNaUPYw4LZ7DxOwtZwEAoND4Mzag8bjn9BWqWQ8F7yc9/63EC0 PW806ix4iEttBd0PLGV91xajgtYPVWEQw1LX1k5q1BgGaJAhn9Cz0u7Yq1uYh/fr eeBHJbNAVzm7puRI/rl8/Q8nl++iJ/aHIMAYzfX2GHekTuyq/EYoEIvkasXv55V1 37NCGaW8syAXOKEF8Dwtytkar2CSfM0hOs8OPZ21uvhUOpYtLCbTbuThSLG5+09A == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (247.15.136.77.rev.sfr.net [77.136.15.247]) by mail.messagingengine.com (Postfix) with ESMTPA id 30EA9E4074; Sat, 4 Aug 2018 20:15:56 -0400 (EDT) From: Thomas Monjalon To: Radu Nicolau Cc: dev@dpdk.org, "Doherty, Declan" , chas3@att.com, ferruh.yigit@intel.com, stable@dpdk.org Date: Sun, 05 Aug 2018 02:15:54 +0200 Message-ID: <3080010.MRSpSMGQK2@xps> In-Reply-To: References: <1525867586-23328-1-git-send-email-radu.nicolau@intel.com> <1531920077-14937-1-git-send-email-radu.nicolau@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] net/bonding: fix slave add for mode 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Aug 2018 00:15:59 -0000 02/08/2018 15:42, Doherty, Declan: > On 18/07/2018 2:21 PM, Radu Nicolau wrote: > > Moved the link status validity check from the slave add to the slave > > activation step. Otherwise slave add will fail for mode 4 if > > the ports are all stopped but only one of them checked. > > > > Removed activate slave call from slave add function. > > > > Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions") > > Bugzilla ID: 52 > > Cc: stable@dpdk.org > > > > Signed-off-by: Radu Nicolau > > --- > > v5: removed activate_slave call from slave add > > v4: reworked patch > > v3: updated commit msg > > v2: add fix and Bugzilla references > > > ... > > > > Acked-by: Declan Doherty Applied, thanks