From: Thomas Monjalon <thomas@monjalon.net>
To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
Akhil Goyal <gakhil@marvell.com>
Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>,
Fan Zhang <roy.fan.zhang@intel.com>,
Brian Dooley <brian.dooley@intel.com>,
Anoob Joseph <anoobj@marvell.com>,
Archana Muniganti <marchana@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: Re: [EXT] Re: [PATCH v2] examples/fips_validation: fix memory leak in sha test
Date: Mon, 04 Jul 2022 10:26:40 +0200 [thread overview]
Message-ID: <3081146.FMhQkTaH9n@thomas> (raw)
In-Reply-To: <CO6PR18MB44848612B15C8BF466D4CC13D8BE9@CO6PR18MB4484.namprd18.prod.outlook.com>
04/07/2022 09:50, Akhil Goyal:
> > On Sat, Jul 2, 2022 at 4:59 PM Gowrishankar Muthukrishnan
> > <gmuthukrishn@marvell.com> wrote:
> > >
> > > There is wrong size used for allocation of digest buffer which in
> > > some cases cause memory corruption. Also, fixed places where memory
> > > leak is observed. This fix would enable sha 384 and 512 NIST vectors
> > > be supported fully.
> > >
> > > Fixes: 93d797d94f1 ("examples/fips_validation: add parsing for sha")
> >
> > This sha1 is not valid anymore, or maybe Akhil will squash the fix in
> > the next-crypto tree before reaching main.
> Fixed the SHA and applied on top of next-crypto as I had already asked Thomas to pull the tree.
David did some good comments, I will wait for a better version of the patch.
next prev parent reply other threads:[~2022-07-04 8:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-02 14:51 [PATCH v1] " Gowrishankar Muthukrishnan
2022-07-02 14:58 ` [PATCH v2] " Gowrishankar Muthukrishnan
2022-07-04 7:48 ` David Marchand
2022-07-04 7:50 ` [EXT] " Akhil Goyal
2022-07-04 8:26 ` Thomas Monjalon [this message]
2022-07-04 8:18 ` Gowrishankar Muthukrishnan
2022-07-02 18:44 ` Gowrishankar Muthukrishnan
2022-07-04 7:00 ` Akhil Goyal
2022-07-04 9:55 ` [PATCH v3] " Gowrishankar Muthukrishnan
2022-07-04 10:34 ` Akhil Goyal
2022-07-04 17:32 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3081146.FMhQkTaH9n@thomas \
--to=thomas@monjalon.net \
--cc=anoobj@marvell.com \
--cc=brian.dooley@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=gmuthukrishn@marvell.com \
--cc=jerinj@marvell.com \
--cc=marchana@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).