From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id E9ED94F91 for ; Mon, 5 Nov 2018 23:18:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6ACF722731; Mon, 5 Nov 2018 17:18:44 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 05 Nov 2018 17:18:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=C16KW+DaO4d3Ocy2Tf4eM253B9e/z02VrLsXJqhXj7M=; b=gPDRMorqotWV 0h7bkxV5geM5pqXeIcpcIbWJQ3Oibnz6hQpzfEQpsMIcbj1kaCSB9mGePKPsNvZ5 VKDvOeA0Id3g0LtSU+Fv4mptkLA7AuHmhOs+qA6icSor8SQcGz6sbs3VbTC0JgKB VuBN/Gept0ISc1SL6m3EKMACu+xauLE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=C16KW+DaO4d3Ocy2Tf4eM253B9e/z02VrLsXJqhXj 7M=; b=LGkbCF8UYzINbus+EAyrAyLA5xoGoV0EtHjDNtEXyhwfnVBPgH8H/0rxd 9HeHr4LOm6ryusfCAyrB/Kd4/tqRUn/bnecI4EdDiU7+XokMo2VExhn4tIkVyEjQ jVvHtxgPtwqLRiYiUPg8lkZqyq67tG+HbT+6/LAalvovBlw2GQhcIC3pPj0WK+yo VW6uD0x1zE2WB7JHwzc5rpPdpR+RPG9fkB6Tup2LhJAS/2H/0pMhuXnuOqSfVXdu sOn5BVVFEtRlmjbuhBCjn27yjHf464Mk6neQCIfn5wXjDSZFM6TIHC8plIDHgT+B Yt6/b4YyssqazTU11VPczIpiZzimQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 30E4B102E4; Mon, 5 Nov 2018 17:18:43 -0500 (EST) From: Thomas Monjalon To: "Zhang, Roy Fan" Cc: dev@dpdk.org, "alejandro.lucero@netronome.com" , bruce.richardson@intel.com, ferruh.yigit@intel.com Date: Mon, 05 Nov 2018 23:18:41 +0100 Message-ID: <3083350.6GbpAYNfqf@xps> In-Reply-To: <2529427.7ESO8GYSS3@xps> References: <20181101121009.86287-1-roy.fan.zhang@intel.com> <9F7182E3F746AB4EA17801C148F3C604334D4B41@IRSMSX101.ger.corp.intel.com> <2529427.7ESO8GYSS3@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix missing case for virtio-crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 22:18:45 -0000 We must also fix rte_pci_write_config() 02/11/2018 11:39, Thomas Monjalon: > +Cc Bruce and Ferruh > > 02/11/2018 11:01, Zhang, Roy Fan: > > Hi Thomas, > > > > You are right, the problem can happen with any PMD falls into RTE_KDRV_UIO_GENERIC and RTE_KDRV_NIC_UIO driver type. As riginally rte_pci_read_config() only covered 2 out of 4 possible driver types' . > > > > The patch was submitted for fixing the Virtio Crypto Initialization Segmentation Fault problem introduced in 18.11 RC1, and it did. The problem is I don't think the patch will fix all problems of rte_pci_read_config(). Even I added RTE_KDRV_UIO_GENERIC type into the switch case there is a remaining RTE_KDRV_NIC_UIO type I am not sure where to fit due to the limited knowledge. > > > > That's why I write the patch title like this. I hope someone else with better bus knowledge could submit a complete fix patch. > > > > Best regards, > > Fan > > > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > Sent: Thursday, November 1, 2018 1:35 PM > > > To: Zhang, Roy Fan > > > Cc: dev@dpdk.org; alejandro.lucero@netronome.com > > > Subject: Re: [PATCH] bus/pci: fix missing case for virtio-crypto > > > > > > 01/11/2018 13:10, Fan Zhang: > > > > The recent change to rte_pci_read_config() caused virtio-crypto device > > > > initialization always failed as it has a RTE_KDRV_UIO_GENERIC driver > > > > type. This patch fixes the problem. > > > > > > Hi Fan, > > > this issue is not related at all to virtio-crypto. > > > It can happen with any PMD, right? > > > > > > In the title, we should mention UIO generic driver. > > > > > > > > > > > > > >