From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id A29F5E72 for ; Mon, 6 Jul 2015 18:15:47 +0200 (CEST) Received: by wgck11 with SMTP id k11so144861149wgc.0 for ; Mon, 06 Jul 2015 09:15:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+rSt/C2WyOaVm4X6wsIvf0bZIfkNucGncz6rUmf4RCA=; b=a2YpBfto4Mix2qI6cYJn8QxqEzetKvA1dU5dFAdSn/QtfAeKuJ9N1ZpDfR3o80hsi+ nUhvdAeB3OGakzR3kY+65R3nanoni86JFn3tDXiYtPMhJsa9vJKdVl4hO21DoY4O/V3a +oukdSbdu/dIwvJc5n1dReQAs/Fw9yAoYo9GtjG3k0W2ot7ccx3V0tw5GMc3d3Rbhzk3 vJ/DB3/F3ESCrvbfRLxhHxn5Et3v/fIepm8NyWDvgq7yvn9tAqVXnxZJ3KVTAenm5LCA ys0y7DVVAunlR7eddQr0a/vjbH+z1YF6dBrdtAqtvylRS5S0+LSfCi/DTspQhieutVrG pPnA== X-Gm-Message-State: ALoCoQnq/INyCCokp/AF0lWhIEx7SUkEcfOpUKxxhI81C439rHHlZCHmSD/dJgnDRuQ7tB4qRHq4 X-Received: by 10.194.179.200 with SMTP id di8mr97710008wjc.56.1436199346833; Mon, 06 Jul 2015 09:15:46 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id q9sm48062390wiz.23.2015.07.06.09.15.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jul 2015 09:15:45 -0700 (PDT) From: Thomas Monjalon To: Keunhong Lee Date: Mon, 06 Jul 2015 18:14:37 +0200 Message-ID: <3087134.yXks7R84Dd@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1436189297-7780-1-git-send-email-dlrmsghd@gmail.com> <3865893.mD3C20oiXL@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/2] Native uio-based PMD for Mellanox ConnectX-3 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jul 2015 16:15:49 -0000 2015-07-07 00:57, Keunhong Lee: > Answer 1. UIO based driver is faster then ib based driver. > It can saturate 40G link with MTU sized packets using a single thread while > ib wrapper cannot. OK, interesting. Do you have numbers and details about your testbed/scenario? > Answer 2. Sorry, I missed that. I'll make a new patch email with my real > name. > > Question 1. Is it OK if I separate GPL-based and BSD-based codes into > separated patches? > mlx4 kernel driver itself is dual licenses, so I think they are considered > as BSD in my source code. > The only source code under GPL is bitmap, integer logarithm, and red-black > tree contained in mlnx_uio/kernel directory. These parts will be built in the user-space driver library, right? It would change the license, which is not desirable. Technically, your approach may be interesting. But from a maintenance point of view, this huge codebase may be a nightmare. > 2015-07-06 23:17 GMT+09:00 Thomas Monjalon : > > > 2015-07-06 22:28, leeopop: > > > This is a native UIO-based PMD for Mellanox ConnectX-3 devices. > > > It uses a persistent memory library in order to provide a persistent > > > scartch area for the mlx4 HCA driver. > > > > What is the benefit of this UIO approach compared to the OFED based driver? > > > > > We release the driver itself under BSD license, but to use it for > > > commercial products, you may have to re-implement the separated GPL > > > sources. > > > > The GPL sources are not really separated. > > The DPDK libraries must be BSD-licensed. > > > > > The GPL affected source codes reside in the mlnx_uio/kernel directory. > > > > It seems that a large part of the GPL driver was also copied in > > mlnx_uio/mlnx/. > > > > Given that you are dropping a huge GPL codebase (whose you don't own the > > copyright) in a BSD library, and that you didn't give your real name in > > the signed-off line, it is NACK.