From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8676ACF68
 for <dev@dpdk.org>; Fri, 27 Apr 2018 18:42:37 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id D8F1C21BC9;
 Fri, 27 Apr 2018 12:42:36 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Fri, 27 Apr 2018 12:42:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=rtE0TCwLpL6nMTIdpOrfnsnqnW
 TGkDVTMjJB/+dutTs=; b=ic5PIXWYeKvnpUKaeRsTcprDjvp+EcoYbGvFVUNXyE
 EkeIM10Tjx9enUb8+M7vfnbBzNmVguX4RcdHc28EQHfif1mhFzwdTp0illmtL7uo
 ezYkoAfjcnoGlVnUpdfQcEqcfDni1WIRAQMcxotUctNjFKyCdbZ1IQbb7H4qV3Xk
 k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=rtE0TC
 wLpL6nMTIdpOrfnsnqnWTGkDVTMjJB/+dutTs=; b=lgGqqxm7lCnqlN8OiEnKYK
 Hfc6IbBL/aU4h8sK4auoWIWhh7srQaKBDU6em+rZtaFz+JPIk6gkgWrH0qqi8cM/
 pSTYTNWJXhL9hX0OrwgCA50KziOIFbzfrZzx4xzz9H0HcuWwuTeNRoJvf8rOmnYX
 Kq8GDQS12gx9kwgNCfyYBENWbXVgBWzL5v74vAYF3PeJjmt8QROJrR2Sz2Sak0zz
 q4qDmYxfXkcq/fV3V2qlFvJI637sY+VP/2uYzEc24EXGNjic/ZItvPp03PzhLdDK
 ge9g+NSASPXA4c4cSqKf+4/R3RboGHQWU9UjnCC9R/lHP7Qs168L8SgqyPh+ODRw
 ==
X-ME-Sender: <xms:_FLjWiiuzFMSEkQzSw3j5r6uQhqUaf2Lzh6nwXLQwNMimY-V0DCu_A>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id F371EE5098;
 Fri, 27 Apr 2018 12:42:35 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
 Anatoly Burakov <anatoly.burakov@intel.com>, shreyansh.jain@nxp.com
Date: Fri, 27 Apr 2018 18:42:34 +0200
Message-ID: <3088214.nrioSNccma@xps>
In-Reply-To: <1524847302-88110-1-git-send-email-jianfeng.tan@intel.com>
References: <1524847302-88110-1-git-send-email-jianfeng.tan@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal: fix threads block on barrier
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2018 16:42:37 -0000

27/04/2018 18:41, Jianfeng Tan:
> Below commit introduced pthread barrier for synchronization.
> But two IPC threads block on the barrier, and never wake up.
> 
>   (gdb) bt
>   #0  futex_wait (private=0, expected=0, futex_word=0x7fffffffcff4)
>       at ../sysdeps/unix/sysv/linux/futex-internal.h:61
>   #1  futex_wait_simple (private=0, expected=0, futex_word=0x7fffffffcff4)
>       at ../sysdeps/nptl/futex-internal.h:135
>   #2  __pthread_barrier_wait (barrier=0x7fffffffcff0) at pthread_barrier_wait.c:184
>   #3  rte_thread_init (arg=0x7fffffffcfe0)
>       at ../dpdk/lib/librte_eal/common/eal_common_thread.c:160
>   #4  start_thread (arg=0x7ffff6ecf700) at pthread_create.c:333
>   #5  clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
> 
> Through analysis, we find the barrier defined on the stack could be the
> root cause. This patch will change to use heap memory as the barrier.
> 
> Fixes: d651ee4919cd ("eal: set affinity for control threads")

Shreyansh (Cc'ed) is seeing some bugs with this patch too.