From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] doc: rework vm power manager user guide
Date: Sun, 16 Feb 2020 12:13:29 +0100 [thread overview]
Message-ID: <3090513.CAdn2TfLgq@xps> (raw)
In-Reply-To: <20200107091343.22965-1-david.hunt@intel.com>
07/01/2020 10:13, David Hunt:
> Review and re-work of vm_power_manager documentation. Hopefully this
> is clearer, easier to follow.
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
checkpatch is reporting a typo done several times:
s/virutal/virtual/
> ---
> .../img/vm_power_mgr_highlevel.svg | 2189 +++++++++++------
This high-level diagram is nice but I disagree about having text blocks.
I think images should be image-only and the text can be in .rst.
It will be easier to update.
Thanks
> .../img/vm_power_mgr_vm_request_seq.svg | 1455 +++++------
> .../sample_app_ug/vm_power_management.rst | 1194 +++++----
> 3 files changed, 2775 insertions(+), 2063 deletions(-)
next prev parent reply other threads:[~2020-02-16 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 9:13 David Hunt
2020-02-16 11:13 ` Thomas Monjalon [this message]
2020-02-17 10:44 ` Hunt, David
2020-02-17 10:48 ` [dpdk-dev] [PATCH v2] " David Hunt
2020-02-21 18:02 ` Thomas Monjalon
2020-02-25 16:46 ` Ferruh Yigit
2020-02-25 16:59 ` Thomas Monjalon
2020-02-25 17:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3090513.CAdn2TfLgq@xps \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).