From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 976FFA0597; Thu, 9 Apr 2020 14:09:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5572D1C026; Thu, 9 Apr 2020 14:09:16 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 8F5721C021 for ; Thu, 9 Apr 2020 14:09:14 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CB58D5C2FE0; Thu, 9 Apr 2020 08:09:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 09 Apr 2020 08:09:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=eeF8tzCFQErTaIKCn5eaZhXqUcaRrCzoWnEAjMEJw4U=; b=px9mKN+6iF5H NQtnmTdj/dPd1zUKPoSORDt11y6Oxze5A0UVJdd6TdBHPQL4l0H76Z72bTo4WYjF K4lVIr6Qf7BJtkkZbLqEyYd9O4GW61LWer2/j9jagXpF4dRXMd4+92dq5Nl+ZIaR 8XQKHi/37R9gEB2q6HYDdSzcOXo0j9o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=eeF8tzCFQErTaIKCn5eaZhXqUcaRrCzoWnEAjMEJw 4U=; b=wCMMnzwdCjqyYrrsRZS2YVKg0Wqiu6XjnJX1jZ+5Ci8lRdQrMapdJtSAe idLqAgRnGg/va7iSa7WUFYx1Cm0dYUem/D97g/UayxPYmv312qfUzlgxS1CKYrk5 2oL6J8bwVojo2YYpfOcYcAY9znVvMxsrGeaFzyoDhj8IOXHU92JX/LjpPg5pzQ0y lGNJEl/55oaKSe9DeitxVJOBnV1E99MjQfgeQAcBW/N1fvkqjZYWOnQEhj57Cezo zYBTS6phFSy2SXAiQQ0R9ZIkYFSwBbzRn0nfyv+jD+NqcY0GcTLXK2P1F3xMw44Q ENZ/ZOcaEFVfKEQq7CCRoon4PCikQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudelgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E6135306005B; Thu, 9 Apr 2020 08:09:12 -0400 (EDT) From: Thomas Monjalon To: Viacheslav Ovsiienko , Ferruh Yigit Cc: dev@dpdk.org, bernard.iremonger@intel.com Date: Thu, 09 Apr 2020 14:09:11 +0200 Message-ID: <3093998.oiGErgHkdL@thomas> In-Reply-To: <56019b21-8578-dae1-5f65-485bac0a9643@intel.com> References: <1561553317-16777-1-git-send-email-viacheslavo@mellanox.com> <1584625851-10291-4-git-send-email-viacheslavo@mellanox.com> <56019b21-8578-dae1-5f65-485bac0a9643@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/04/2020 14:03, Ferruh Yigit: > On 3/19/2020 1:50 PM, Viacheslav Ovsiienko wrote: > > - pkt_burst_stats_display("RX", &fs->rx_burst_stats); > > - pkt_burst_stats_display("TX", &fs->tx_burst_stats); > > + pkt_burst_stats_display(false, &fs->rx_burst_stats); > > + pkt_burst_stats_display(true, &fs->tx_burst_stats); > > Instead of this true/false, I would be OK to some duplication and have explicit > Rx/Tx, I believe it would be more clear that way, but no strong opinion on it. I have a strong opinion here: Rx/Tx is not a boolean. If not a string, it should be a constant (#define).