From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9D66E5587 for ; Tue, 4 Jul 2017 15:53:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2083C20B13; Tue, 4 Jul 2017 09:53:50 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 04 Jul 2017 09:53:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=5cnAWrNmfEjrswV sMUllNM5U4E41WzTHv1flmp1yGz0=; b=aLDDv7EY3FPileJPyR6gJAR2JUmJtOm nC+myKNquNlF6sqNKHk6bYYFu1DZF5Bx9PHM1JsZt0xA6p2+PLvF44lthN8PbRmb XebTUkdf033LFKWfjrdndeZrqPKQL2ytKjVqxQyr3SqrWyEIVNiUId8/U+C7RBMv gQZpaG0VB/N0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=5cnAWrNmfEjrswVsMUllNM5U4E41WzTHv1flmp1yGz0=; b=YOx+Y4XN 6+2DPLTouM3nBmhv1Zy/gv+Q1QTstZHTr4gMIL5wmfQEyGHyhllhzpSZxOx/9huo kjetQZW/GOMRKJAfH1hnuA6PBPnKdMprSqLM7iMLAKOOqEmbMuoZGrIDP2rQ2Qhe AIzMSulZDHADIdoHtWOMtMikJMM0QFeBtRkedRhti7cfR4ESWBh1Sw8gGIB6BtmE jAXZmuPUJI/LD+ScCWJXBr2Mfl9WqvWoNb2qbC87W+7+kWWPqEa8WvjR8TTQDayL eOtcC/Pu0uaUJzamE+PBXIJogFeBhuizIluvTv8PAjl7EySwvW7d8FKIiYCw1ojW te9vhbwtd2IRVQ== X-ME-Sender: X-Sasl-enc: kG6NNMhpdzxnM8jQ/UFNvnmVZ4qEiL3Pu5GGTIwbHqut 1499176429 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BF58E7E847; Tue, 4 Jul 2017 09:53:49 -0400 (EDT) From: Thomas Monjalon To: Ashwin Sekhar T K Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, viktorin@rehivetech.com, jianbo.liu@linaro.org, jasvinder.singh@intel.com Date: Tue, 04 Jul 2017 15:53:48 +0200 Message-ID: <3095665.xB34d7aaer@xps> In-Reply-To: <20170704092408.30878-4-ashwin.sekhar@caviumnetworks.com> References: <20170427140618.35897-1-ashwin.sekhar@caviumnetworks.com> <20170704092408.30878-1-ashwin.sekhar@caviumnetworks.com> <20170704092408.30878-4-ashwin.sekhar@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 3/4] net: add arm64 neon version of CRC compute APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 13:53:50 -0000 04/07/2017 11:24, Ashwin Sekhar T K: > rte_net_crc_set_alg(enum rte_net_crc_alg alg) > { > switch (alg) { > - case RTE_NET_CRC_SSE42: > #ifdef X86_64_SSE42_PCLMULQDQ > + case RTE_NET_CRC_SSE42: > handlers = handlers_sse42; > -#else > - alg = RTE_NET_CRC_SCALAR; > -#endif > break; > +#elif defined(ARM64_NEON_PMULL) > + case RTE_NET_CRC_NEON: > + if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_PMULL)) { > + handlers = handlers_neon; > + break; > + } > + /* fall-through */ > +#endif > case RTE_NET_CRC_SCALAR: > + /* fall-through */ > default: > handlers = handlers_scalar; > break; > I'm moving the fall-through comment outside of #ifdef to fix warning.