From: Thomas Monjalon <thomas@monjalon.net>
To: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Guo, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH] devargs: do not replace already inserted devargs
Date: Thu, 08 Nov 2018 13:53:19 +0100 [thread overview]
Message-ID: <3095983.aBgvmuOXeg@xps> (raw)
In-Reply-To: <FBE7E039FA50BF47A673AD0BD3CD56A84622BAB1@HASMSX105.ger.corp.intel.com>
08/11/2018 13:35, Stojaczyk, Dariusz:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 08/11/2018 12:25, Stojaczyk, Dariusz:
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > >
> > > > The devargs of a device can be replaced by a newly allocated one
> > > > when trying to probe again the same device (multi-process or
> > > > multi-ports scenarios). This is breaking some pointer references.
> > > >
> > > > It can be avoided by copying the new content, freeing the new devargs,
> > > > and returning the already inserted pointer.
> > > >
> > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > >
> > > Tested-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> >
> > Is it fixing any use case?
>
> Of course it is. I was previously seeing a regression with the following scenario:
> 1. hotplug device in the primary process
> 2. start a secodary process
> 3. hotplug device in secondary -> primary segfaults
>
> And now it's working.
Good to know!
Thank you
next prev parent reply other threads:[~2018-11-08 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 23:21 Thomas Monjalon
2018-11-08 11:25 ` Stojaczyk, Dariusz
2018-11-08 12:26 ` Thomas Monjalon
2018-11-08 12:35 ` Stojaczyk, Dariusz
2018-11-08 12:53 ` Thomas Monjalon [this message]
2018-11-08 17:12 ` Zhang, Qi Z
2018-11-11 23:12 ` Thomas Monjalon
2018-11-08 14:02 ` Slava Ovsiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3095983.aBgvmuOXeg@xps \
--to=thomas@monjalon.net \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=jia.guo@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).