From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 83CC67CFC for ; Mon, 15 Jan 2018 17:12:30 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 23A852054D; Mon, 15 Jan 2018 11:12:30 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 15 Jan 2018 11:12:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=K12dqfLW2V6MNcTNMi6SjngsYO JMPFwXx0Fw2wIJqiE=; b=BEEX9FCrjCDhLWEA11xnQE/jF03ldvU0a30MWg4/OV So6FDPt0Kl5g4bTqk4P+azgekDLp/LcQR0rJKE6K9x/o8x9h6WVjmkSBr7pHB7AE mu2OaWHKY391slvas3Y9RoJFHvEoKRR00jenCytoGgk9qxsTvete8yNkmosO3zAz I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=K12dqf LW2V6MNcTNMi6SjngsYOJMPFwXx0Fw2wIJqiE=; b=IHTEHgBkmZX/QL2lj2WNOM yrckHeB8GsK/V04iZf/BwQrJo/obfd/w/cmrM/7EE149FYcFJ1fPXVeLXuE241uv o+a2/kGh823k1YHPQbn4i9C+PM0A7rMycCuOEbEq64AQn88T1vUAhMjezkEAtLHY KwT0023H70fh4fgmLjilT6ijg+fmsmGnhmCzXWjdR7T1NSsduGgU1RxEmNGWJjju WZ+tVF8pDvNTFFcrPRXA/Vy2C6Z3T8EzSYvb9cYAKX0J0SdfBvz1wLorq6l1t9P3 Is5Mihx5XIxuI5QnC0gvqlhXrJV5qfgLsaZwI62qdZgA9sR0eCpycoC56QGKWcBQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C232124718; Mon, 15 Jan 2018 11:12:29 -0500 (EST) From: Thomas Monjalon To: Jonas Pfefferle Cc: "Burakov, Anatoly" , dev@dpdk.org, maxime.coquelin@redhat.com Date: Mon, 15 Jan 2018 17:11:58 +0100 Message-ID: <30962267.NVMYIIJvp8@xps> In-Reply-To: References: <1509465586-7436-1-git-send-email-jpf@zurich.ibm.com> <2075027.JcYejM7RvO@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 16:12:30 -0000 15/01/2018 13:22, Jonas Pfefferle: > > On Sat, 13 Jan 2018 23:49:30 +0100 > Thomas Monjalon wrote: > > 13/01/2018 13:15, Burakov, Anatoly: > >> On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: > >> > 07/11/2017 10:50, Jonas Pfefferle1: > >> >>> Is there something urgent for 17.11? > >> >>> Or can it be refined in 18.02? > >> >> > >> >> Nothing urgent. We can refine this for 18.02. > >> >> > >> >>> Anatoly, any thought? > >> > > >> > Anatoly, Jonas, how do you want to proceed with this patch? > >> > > >> > >> I don't see anything to be refined here, it's a simple bug fix - > >>code > >> assumes noiommu mode support is always available, when it might not > >>be > >> the case on older kernels. > > > > As a bug fix, the title must start with "fix" and a tag "Fixes:" > > must be added to help with backport. > > At the same time, the explanation of the bug must be added in > > the commit log please. > > > > Thanks > > It's not really a bug fix since it does not change the semantic of the > function but just adds nicer error handling. > Regarding redefining the code: What I don't like is the special cases > we have to check for when using the sPAPR iommu because it does not > support VA mappings yet. I think we should decide which iova mode to > use based on the iommu types available, i.e. each iommu type should > report which iova type it supports. Thoughts? Have you looked at what Maxime did? https://dpdk.org/dev/patchwork/patch/33650/ How does it affect this patch?