From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by dpdk.org (Postfix) with ESMTP id 158CBA6A for ; Mon, 23 Mar 2015 14:53:28 +0100 (CET) Received: by wetk59 with SMTP id k59so138460340wet.3 for ; Mon, 23 Mar 2015 06:53:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=L+SNYSHY4f6IFgrjkE2AfBy81n0cqFuudBfu7CVjaEs=; b=cnoxDeNdD8631o9LW3VXc53lCwKkl72+aqxovFeHZEHGzTKtJvcETFiaDzPaCRjaWZ xtRtNBMKI6pc9yWLFqpdrB0R12GvVQ0Ppz/bZD8IZW3O5mpTUxjG5FM9zfyl4ngUfoMT +6FjLer8uJkKxNBU8l2nxG91B/+F8zjp3eo9MddDGIhUS+CkjVVthvI0G0v0ywN8BrqA xXevM1FE65XvGRRvC+HhnBvSz0slFwBlQWvf62DR5/pEnL0u137wzLtf1Gsg2WrIoTxP aPvsucr5xUAVVWRQAUuLqYayuw/8yplYJ+mrigX1S2IJ/m5JP6dDJaklhMFzgEiLn3xR /lqw== X-Gm-Message-State: ALoCoQlvfRcpP+vixZN4pxQiPZXUzJxkWC+Ns2+9xyQDW1RDJ7Iy9NRo5kYy4KBk6yKqdTNqA4Cj X-Received: by 10.180.82.134 with SMTP id i6mr19774962wiy.70.1427118807916; Mon, 23 Mar 2015 06:53:27 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dc9sm11330515wib.9.2015.03.23.06.53.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2015 06:53:27 -0700 (PDT) From: Thomas Monjalon To: Michael Qiu , Pablo de Lara Date: Mon, 23 Mar 2015 14:52:46 +0100 Message-ID: <3096315.kVbCiLpmZB@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1422952659-21557-1-git-send-email-michael.qiu@intel.com> References: <1422952659-21557-1-git-send-email-michael.qiu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix wrong message when no port started X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 13:53:28 -0000 Pablo, what is your opinion on this patch? 2015-02-03 16:37, Michael Qiu: > The log message is wrong when no port started. > > Signed-off-by: Michael Qiu > --- > app/test-pmd/testpmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 773b8af..ebf9448 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1423,7 +1423,7 @@ start_port(portid_t pid) > if (need_check_link_status && !no_link_check) > check_all_ports_link_status(nb_ports, RTE_PORT_ALL); > else > - printf("Please stop the ports first\n"); > + printf("Please start at least one port first\n"); Why the word "first"? What could lead to this situation? Wrong pid? Shouldn't be an error returned? > > printf("Done\n"); > return 0;