From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 589691B393; Thu, 18 Jan 2018 18:00:49 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B84E120B44; Thu, 18 Jan 2018 12:00:48 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 18 Jan 2018 12:00:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=X52SAI1EuJbV4pu1y0rzsRTZGH fwQsDcOivBcuQRg6I=; b=l78EnRI7rpOJRdZ7/wUGs2kqw9WRv4S7Q3a/8hWGky BV5pntBdiC+Xgr27Hz3GrqVWlrZo67S7gF5iaG3eIWJN5diVhiIkX+Z3yTytCQ2+ Lu7hSU6Kwxjj1UTuNLL3oI3Gqjn45pCkAwmBSGjzalAb6U4B12ScTTEM6bvREf2C E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=X52SAI 1EuJbV4pu1y0rzsRTZGHfwQsDcOivBcuQRg6I=; b=eCgFA/uhqGKHG7M7meH2cj lkpf68cWDjrVK8nXV4qJ1crtCveWldGb1NQ13MfNXr5+LOf02P28le9WH5HDZoPL MIvAL8Z1dDLzvnQQ9GqObmcwusMEhw6muiesYz+0KptjtgWMJ3FZaZ0tWsWdFq+A tDFHXpkVD3IxiQgkkJq+y8/LocY4nrA3+EEyTH4pAvIxo+JOzzmS3VtTkq1vBt+A fVPojKTYilSYdWZH6WuVhKa2JBo5oHTIGlTQKpD2KDxnq+3gO6ei3fU3v033BKT1 1p0nEZrW98w+vpcAaEP47nas1aA4bVu0yqgREO0VRIvvARAmM2Jgk3u3Dvz14c6g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5AE22240DE; Thu, 18 Jan 2018 12:00:48 -0500 (EST) From: Thomas Monjalon To: Matan Azrad Cc: Gaetan Rivet , Jingjing Wu , dev@dpdk.org, Neil Horman , Bruce Richardson , Konstantin Ananyev , stable@dpdk.org Date: Thu, 18 Jan 2018 18:00:13 +0100 Message-ID: <30967616.lm9rISfK7X@xps> In-Reply-To: <1516293317-30748-2-git-send-email-matan@mellanox.com> References: <1515318351-4756-1-git-send-email-matan@mellanox.com> <1516293317-30748-1-git-send-email-matan@mellanox.com> <1516293317-30748-2-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/7] ethdev: fix port data reset timing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 17:00:49 -0000 18/01/2018 17:35, Matan Azrad: > rte_eth_dev_data structure is allocated per ethdev port and can be > used to get a data of the port internally. > > rte_eth_dev_attach_secondary tries to find the port identifier using > rte_eth_dev_data name field comparison and may get an identifier of > invalid port in case of this port was released by the primary process > because the port release API doesn't reset the port data. > > So, it will be better to reset the port data in release time instead of > allocation time. > > Move the port data reset to the port release API. > > Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process model") > Cc: stable@dpdk.org > > Signed-off-by: Matan Azrad Acked-by: Thomas Monjalon