From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E87DFA04B5; Mon, 11 Jan 2021 21:52:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A42AF140CEE; Mon, 11 Jan 2021 21:52:55 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 1DF96140CED for ; Mon, 11 Jan 2021 21:52:54 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 91BE55C01A4; Mon, 11 Jan 2021 15:52:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 11 Jan 2021 15:52:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= jdJ5HIGDKiz+1y98JzWkEnBSWxcRu5qCI3wpIxH1Tdo=; b=Vxr5PkuUsl+R9B/b OJgWuff4M1x9NFRPFKnHb2RqG9uINNCCYSdh8Xqn9gKuGagcrQFU13mZYDNRCHyZ B0RMvqeECP6rjDiHlcE27xD52WQfbEYm6P/iMiXEIDz8qrZB9P3dNQOyvk+FG+Kd 8D1UKc/TgiAMMJg5NlLxNK1Aw2LMNe4ZA9msRdcbRc6mEi+/0EuylM9ZnRzxNumB fBLF7C+31d3RVA2h9z7/2Qx4IJpihOCwYiM0GKx7SeZd94lwvN/8jg8MDH5VJADX x6leOuo7TWlJnmuN/ALdPzSHkv+syUqLGp1gOme7aVuebk0Xg2PzXvSxgQe723B9 1G6asA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=jdJ5HIGDKiz+1y98JzWkEnBSWxcRu5qCI3wpIxH1T do=; b=bdbu1xeJfwF0CkSvDGGBW7t85PxS41Yi/aCin4didF6X2jkD+7+d4lt+f rwlleQdEDjA18hd9fhZOXPMn+B/rQyuO31avg4XPr8BgxLJU8al8c7vY6lYQWCI3 aeOXXdO3aX3RQYrHP8nlAMV88bK1TrmojdO7vcKns05uaCaHSZFzJWVXB/BJotO/ igUll3x2mvqn/8S5+6T4fVLB3QS6jLknbOnGzBb3XlBmZttMESwXA9Xcgol+sqr7 +IbeZ9jRBOjRtU+WYkEqk9Dpid7pOhrnrNDQXoFM2TupIMTe/HrlC4BgX2/Bb/oc I8joR0Rho46tpB18kdURIl3PwwUaA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdehuddgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AE65F24005A; Mon, 11 Jan 2021 15:52:51 -0500 (EST) From: Thomas Monjalon To: ophirmu@nvidia.com, Tal Shnaiderman Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com, bruce.richardson@intel.com Date: Mon, 11 Jan 2021 21:52:48 +0100 Message-ID: <30970212.5v1tIpmo2K@thomas> In-Reply-To: <20210103080013.8964-1-talshn@nvidia.com> References: <20201210150648.8784-30-talshn@nvidia.com> <20210103080013.8964-1-talshn@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] drivers/common: enable Windows common mlx5 compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/01/2021 09:00, Tal Shnaiderman: > From: Ophir Munk > > Prior to this commit meson did not progress beyond directory > drivers/common for Windows compilations. This commit enables drivers > compilation under this directory. > > Signed-off-by: Ophir Munk > Signed-off-by: Tal Shnaiderman > Acked-by: Matan Azrad > --- > --- a/drivers/common/meson.build > +++ b/drivers/common/meson.build > @@ -1,10 +1,8 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2018 Cavium, Inc > > -if is_windows > - subdir_done() > +if not is_windows > + std_deps = ['eal'] > + drivers = ['cpt', 'dpaax', 'iavf', 'mvep', 'octeontx', 'octeontx2', 'sfc_efx'] > endif > - > -std_deps = ['eal'] > -drivers = ['cpt', 'dpaax', 'iavf', 'mvep', 'octeontx', 'octeontx2', 'sfc_efx'] The change in drivers/common/meson.build is useless. common/mlx5 is called directly from drivers/meson.build And when one of these drivers will support Windows, the Windows check will have to move in drivers file.