From: Thomas Monjalon <thomas@monjalon.net>
To: Gaetan Rivet <grive@u256.net>
Cc: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v2] bus/dpaa: optimize device name parsing
Date: Fri, 15 Jan 2021 12:16:55 +0100 [thread overview]
Message-ID: <30976194.rv9ajp2ogJ@thomas> (raw)
In-Reply-To: <20201109133755.999895-1-grive@u256.net>
09/11/2020 14:37, Gaetan Rivet:
> Device name parsing is done on all buses during device iterations at
> either EAL or ethdev levels.
>
> When a bus implements device name parsing slowly, all iterations are
> impacted. Efficient implementation is important.
>
> The DPAA bus device name parsing has two issues: it allocates dynamic
> memory and uses snprintf without a real need for it. Both can be
> avoided, which improves the parsing performance.
>
> The function is also simpler and shorter.
>
> Signed-off-by: Gaetan Rivet <grive@u256.net>
Applied, thanks
prev parent reply other threads:[~2021-01-15 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 11:31 [dpdk-dev] [PATCH] " Gaetan Rivet
2020-11-09 11:44 ` Gaëtan Rivet
2020-11-09 11:58 ` David Marchand
2020-11-09 13:36 ` Gaëtan Rivet
2020-11-09 13:37 ` [dpdk-dev] [PATCH v2] " Gaetan Rivet
2021-01-15 11:16 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30976194.rv9ajp2ogJ@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).