From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BD6AA0A02; Fri, 15 Jan 2021 12:17:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A543F140FD1; Fri, 15 Jan 2021 12:17:02 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 1A7D4140FBB for ; Fri, 15 Jan 2021 12:17:01 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 87A3E5C013E; Fri, 15 Jan 2021 06:16:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 15 Jan 2021 06:16:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 7dnXVGJWlUibSC5I9FQXnePoJilVcVQ8eMfH2LJx98A=; b=4O/xxUMyGv/HqGjE Vqac89qNqnvZmr/icsn6PLoIKBhHUUnloVSI4EwJCx537Bhyt72g6oxpa71cKHFN lMbYHg6vfGf89vXoPqElQdD/pw1m/cB5Hwcn4y8wlIZpONYBso2OgdbobbEOYpep tAheGwOsyYkRRg7/z447JfuROKeLPVenEGTF/gqUNbS1g5sIjiDpAiH6+7Qdp/Fr BXBGf2lQJ9RDY5CIpODxi8Ro2tbNfGFEGg+z/HN9EnwAwN2R7ndZFgd5dsjzU2pD ORwb6C8ZtQrk6Bb+Tpykwx2VLjSiWVWtjYAhPJ96CSflR9u//Lj8sG5QR7/fyNpy moa7jA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=7dnXVGJWlUibSC5I9FQXnePoJilVcVQ8eMfH2LJx9 8A=; b=hAv2fw5kmcQrT7FThJmpTnA4/0heiUZSIuLioVWJXQH3g4IfooeCRojhe LhFNShDJ1EgWxJhpjbhhlXRrYKbuYYb5QVhiL3W8fEw3IJZHPb8CZAPdfkQIPeIK MfpR3Cu+HTKNelXMdAzM2vPeOvjD0veiDCv7NoPROZQRIP8JbfWzWbtDuqE7cDsr aw1FpQgMOVRzNLQlK+fzrQlCqyVuCx2I2ShmCrqxCOFEvHhUQ/p3JqJjJvtqZamp 07B+8PYoZdeRx5Uykqc6RbOFe+qygXPAy8pEJ18MXSBHPLLOEcZuEzKqYkGSeYtF SMN4d0ZZPSyVKBvG/n2c0y0Nt0HVg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtddvgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddvtdehrdeguddrfeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhn vght X-ME-Proxy: Received: from xps.localnet (3.41.205.77.rev.sfr.net [77.205.41.3]) by mail.messagingengine.com (Postfix) with ESMTPA id F0FAF24005D; Fri, 15 Jan 2021 06:16:57 -0500 (EST) From: Thomas Monjalon To: Gaetan Rivet Cc: dev@dpdk.org, Hemant Agrawal , Sachin Saxena , david.marchand@redhat.com Date: Fri, 15 Jan 2021 12:16:55 +0100 Message-ID: <30976194.rv9ajp2ogJ@thomas> In-Reply-To: <20201109133755.999895-1-grive@u256.net> References: <20201109113147.962882-1-grive@u256.net> <20201109133755.999895-1-grive@u256.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] bus/dpaa: optimize device name parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/11/2020 14:37, Gaetan Rivet: > Device name parsing is done on all buses during device iterations at > either EAL or ethdev levels. > > When a bus implements device name parsing slowly, all iterations are > impacted. Efficient implementation is important. > > The DPAA bus device name parsing has two issues: it allocates dynamic > memory and uses snprintf without a real need for it. Both can be > avoided, which improves the parsing performance. > > The function is also simpler and shorter. > > Signed-off-by: Gaetan Rivet Applied, thanks