From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCF45A0545; Fri, 13 Nov 2020 00:17:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8EBF95928; Fri, 13 Nov 2020 00:17:53 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 63580569B for ; Fri, 13 Nov 2020 00:17:52 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id D84625C00E5; Thu, 12 Nov 2020 18:17:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 12 Nov 2020 18:17:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= KWigcpUyIriW8erm8zTmpaN7ctC8Y7/wM1awFxQ96H8=; b=tm6IqP5ukfbJNkEy oV/8JNl0v4ZFi8eWpKsdOmZ5T4oh9VC9arAO7s/hZzisbiFM/lgn74IvDvhXg1O/ FPdUHa762AXXamLzSCiX7MQuc2QcPeIAF+r3Il2F2VCN/QTRxMnOZXkynVyxqkk5 lx3NcuTWD75jl/hYiseZd7AA8C6TRBwTCHB0puDl/kGarcbfQ0jJkhkx50vbWq5N oZAp5576QwRGlrisyaoX1yCWuHzAfTarrA+L5qhcqnAiZYPnwct6fMocgOdkYMB+ NCZunnKPSc8oLF/rOby4UUu5q04CkkWlFJ52ppcnXy0NMFHW8+5QHFdNYlHDM0dZ Ivsi/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=KWigcpUyIriW8erm8zTmpaN7ctC8Y7/wM1awFxQ96 H8=; b=dLL/+wdTqKzGt6kudCimR52OJcn+hq8JBE8oLEVyADQs4+I4Jm9AbWewG 1D+HID4QXNw5N1t5gigT9Qkm2ZJclyinPhFmp3JHDuo1mk4yGdBBr+SqIz1tgTkH NtxKfuGtOPUSs6VkmKdN8Vi8YfUWQ4AIUf6vW55M5hnJmkEGeT4BPI3mvfbERTom E4zkS+3v4smCzswHFBiNmeGiosXAEvkVQ8XPwzzhaHz0DEHe2KRQiezXVXaHkaq8 rpFRaXae8Np4dkABnPndYRIzCjaDsT0HnIViq1CongOMu5HMsq8EYdRVe5UMf3T3 xkXDzU06ouHdP8AfERjASjR8aawoQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddvgedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (unknown [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 671663068D9D; Thu, 12 Nov 2020 18:17:47 -0500 (EST) From: Thomas Monjalon To: luca.boccassi@gmail.com Cc: dev@dpdk.org, Dmitry Kozlyuk , John Alexander , Luca Boccassi , david.marchand@redhat.com Date: Fri, 13 Nov 2020 00:17:45 +0100 Message-ID: <3097625.jnL5zvyN3p@thomas> In-Reply-To: <20201112201509.1002479-1-luca.boccassi@gmail.com> References: <20201029225505.30093-1-dmitry.kozliuk@gmail.com> <20201112201509.1002479-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [kmods PATCH v2] windows: normalize line-endings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/11/2020 21:15, luca.boccassi@gmail.com: > From: Dmitry Kozlyuk > > MSBuild XML files have to use CRLF line-endings, otherwise any change > results in the whole file being rewritten with CRLF line-endings by > Visual Studio. However, it's inconvenient to have such files checked-out > with CLRF in Unix environments. > > Add suggested git configuration to top-level README, so that Unix > developers don't miss it. Remove .gitattributes, because core.autocrlf > overrides eol= attribute. Convert line-endings of the existing files in > the repository. > > Suggested-by: John Alexander > Signed-off-by: Dmitry Kozlyuk > Signed-off-by: Luca Boccassi > --- > v2 from Luca: run dos2unix on all files in windows/virt2phys folder [...] > +Some Windows files use have to use CRLF line-endings. > +Unix developers can configure git to get only LF on checkout: > + > + git config core.autocrlf input This is the same as in v1: - same typo "use have to use" - this config is probably useless