From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CAB6A04F5; Fri, 19 Jun 2020 00:47:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85D11DE3; Fri, 19 Jun 2020 00:47:52 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 51B86255 for ; Fri, 19 Jun 2020 00:47:51 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CC51B5C012B; Thu, 18 Jun 2020 18:47:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 18 Jun 2020 18:47:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= XnAh3SwrM6tgRT562xTle6OBusYcC0mZLOo1lBfzUTE=; b=VDhHVQ//2PdJETyN LjnrklV3/KKZZ9MbnCS3pelnubcOpgOrdlEboYYQa7EJpP8CVR7Wdbg38ScWb6Cu bpgodDDRdGE/XqIyQQ2196QrCBeG0K4wmJnalyHhMyMYQ3VhKoEbxIoEuXG0smZ4 8tcaXJPon8GEiqcboxPXVxjODYfaSh6aih4OMSwwSUsU7ET245KFIXrXfeA95QPd UEcO3m2eit+vQZUJWbNWXh08eWxn9SpYwLkfAT9Y3IM9naIXUb7vwpBdrLLgmFVu IJZuNIlnUMwLuNCHKm64lBMQpuFBS/HfwJddSoyzejOlheXjVJwM1V4rhvP7rn8i Bq+C+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=XnAh3SwrM6tgRT562xTle6OBusYcC0mZLOo1lBfzU TE=; b=s03eMHokSnS3TSx4MsUy8xITGd59fVcA5v0knLkViY9R+qgoXG1LaOJrz tOMl4JVoE02SbR0y5dwjfWmrnaSTOXb1NTbea8E86F+8zg0d9ogOiJKTZ23BG6IH dgHEVVuQ/wMyISujqtD7KlfWIxyq0+n+XCJ8zLsEHQhKd74lg05RtgJvzZLX0GsB Wi9IYgMG333NUezpILvLTYofSM56bKLZI1ne0CYL5Ubo2if7lf7E1WJu/buGEyrL tYqBxOgYITdrsW698CfLM8m2mQWiGeCbGPKh/uRGpoCB9NXqDT8FYt2+3wFABlls eMafqNq4TYtmIt+31CBhg1No/0KNQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejhedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E60F230614FA; Thu, 18 Jun 2020 18:47:49 -0400 (EDT) From: Thomas Monjalon To: Ophir Munk Cc: dev@dpdk.org, Matan Azrad , Raslan Darawsheh Date: Fri, 19 Jun 2020 00:47:48 +0200 Message-ID: <3099190.lTHxlZXM2T@thomas> In-Reply-To: <20200610093233.23902-8-ophirmu@mellanox.com> References: <20200610093233.23902-1-ophirmu@mellanox.com> <20200610093233.23902-8-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 7/8] common/mlx5: exclude OS dependency in devx commands X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/06/2020 11:32, Ophir Munk: > Shared function mlx5_devx_cmd_mkey_create() reads the OS pagesize by > calling a Linux API: 'sysconf(_SC_PAGESIZE)'. Wrap this call with a > shared API 'mlx5_os_get_page_size()' which contains the specific OS > implementation. > > Signed-off-by: Ophir Munk Sorry, I drop this patch while pulling next-net. > +/** > + * Get OS page size > + * > + * @return > + * OS pagesize > + */ > +size_t > +mlx5_os_get_page_size(void) > +{ > + return sysconf(_SC_PAGESIZE); > +} The same purpose is achieved with rte_mem_page_size(), which was added in EAL recently for Windows memory management. In general, such basic need should not be implemented in a PMD.