From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 40C1B5922
 for <dev@dpdk.org>; Tue, 20 Sep 2016 15:48:56 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga105.fm.intel.com with ESMTP; 20 Sep 2016 06:48:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,368,1470726000"; d="scan'208";a="170986922"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.69])
 ([10.237.220.69])
 by fmsmga004.fm.intel.com with ESMTP; 20 Sep 2016 06:48:53 -0700
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Kamil Rytarowski <krytarowski@caviumnetworks.com>, dev@dpdk.org
References: <1472230448-17490-1-git-send-email-krytarowski@caviumnetworks.com>
 <1472230448-17490-8-git-send-email-krytarowski@caviumnetworks.com>
Cc: maciej.czekaj@caviumnetworks.com, zyta.szpak@semihalf.com,
 slawomir.rosek@semihalf.com, rad@semihalf.com,
 jerin.jacob@caviumnetworks.com,
 Kamil Rytarowski <kamil.rytarowski@caviumnetworks.com>
Message-ID: <30b54539-0ccf-65b3-c158-3f55a40a274b@intel.com>
Date: Tue, 20 Sep 2016 14:48:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1472230448-17490-8-git-send-email-krytarowski@caviumnetworks.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 07/13] net/thunderx: fix multiprocess support
 in stats
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Sep 2016 13:48:56 -0000

On 8/26/2016 5:54 PM, Kamil Rytarowski wrote:
> From: Kamil Rytarowski <kamil.rytarowski@caviumnetworks.com>
> 
> In case of the multiprocess mode a shared nicvf struct between processes
> cannot point with the eth_dev pointer to master device, therefore remove it
> allong with references to it refactoring the code where needed.

Patch subject says fix multiprocess support in stat, but it seems doing
more than just for stats fix.

Overall eliminates private_data->eht_dev link.

I guess this is because eth_dev->data is shared for primary and
secondary processes, and this makes impossible to use separate
private_data for primary and secondaries.

So this patch looks like keeping separate copy of private_data (nic) and
using eth_dev and nic structs for functions instead of using
eth_dev->data->private_data.

If above correct, can you please updated patch subject?

Also another approach can be allocating "data" independently and
overwrite eth_dev->data with this per each process, this also makes
eth_dev->data->private_data usable for each process.

> 
> Fixes: 7413feee662d ("net/thunderx: add device start/stop and close")
> 
> Signed-off-by: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
> Signed-off-by: Kamil Rytarowski <kamil.rytarowski@caviumnetworks.com>
> Signed-off-by: Zyta Szpak <zyta.szpak@semihalf.com>
> Signed-off-by: Slawomir Rosek <slawomir.rosek@semihalf.com>
> Signed-off-by: Radoslaw Biernacki <rad@semihalf.com>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---