From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D1B925F6C for ; Wed, 14 Mar 2018 16:49:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 08:49:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,470,1515484800"; d="scan'208";a="24631797" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.232]) ([163.33.230.232]) by orsmga007.jf.intel.com with ESMTP; 14 Mar 2018 08:48:58 -0700 To: Ferruh Yigit , dev@dpdk.org References: <20180307120851.5822-1-remy.horton@intel.com> <20180307120851.5822-2-remy.horton@intel.com> <023fbd6c-7cac-6c8b-9a40-7a62e5d47bb7@intel.com> Cc: Wenzhuo Lu , Jingjing Wu , Qi Zhang , Beilei Xing , Shreyansh Jain , Thomas Monjalon From: Remy Horton Organization: Intel Shannon Limited Message-ID: <30b8575d-4aeb-912d-6f74-c49ad7ce879a@intel.com> Date: Wed, 14 Mar 2018 15:48:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <023fbd6c-7cac-6c8b-9a40-7a62e5d47bb7@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 15:49:04 -0000 On 14/03/2018 14:43, Ferruh Yigit wrote: [..] >> lib/librte_ether/rte_ethdev.c | 18 ++++++++++++++++++ >> lib/librte_ether/rte_ethdev.h | 15 +++++++++++++++ > > Can you please remove deprecation notice in this patch. Done. >> + /* Defaults for drivers that don't implement preferred >> + * queue parameters. [..] > Not sure about having these defaults here. It is OK to have defaults in driver, > in application or in config file, but I am not sure if putting them into device > abstraction layer hides them. > > What about not providing any default in ethdev layer, and get zero as invalid > when using them? This is something I have been thinking about, and I am going to remove them for the V2. Original motive was to avoid breaking testpmd for PMDs that don't give defaults (i.e. almost all of them). The alternative is to put place-holders into all the PMDs themselves, but I am not sure if this is appropriate.