From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 411994246D; Mon, 23 Jan 2023 18:30:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2ED0140150; Mon, 23 Jan 2023 18:30:42 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2057.outbound.protection.outlook.com [40.107.93.57]) by mails.dpdk.org (Postfix) with ESMTP id D7DE6400EF for ; Mon, 23 Jan 2023 18:30:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YqGhUgLuJhEIEdumZZuZsrS0MWlHc1a0Vvi9YDXxgY2l8vk6VPoIlEnvL0NlxO7fy2EI9AOeGnebrZ+fhLDOzb74sT9A8MQdpYtirjItCgfkcPWJMmeuxgJNfPfSBhXL2NdX3FKGhfmNmdQwf+BOYSsrj37NHNr/fMlSywpclJmidxvWYLJYzAqDm09rivsH55EizlFt/0lIn4yGALY7j53xiyAfxQnxlxW+f/7AT8Pm1m/cK5m59hngqh9vgsBlljvgczbwolTrOGKbglQ9Pf6Ip0rprcCI+oACkjA8a5DD6sOkDSCDWrDBo7lXCxkSlBpQcLeHLiPEATAvke8hbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6TmzwvbH/47lW73OO4IgtLJN5zTyscDuVAtS/MVaFAw=; b=dP2Bd461BZS9J1WHsu4jtkLCcANFewcZ6lgMG7CkG0d04wIKxso0gP+C8Qn2+mQkm8TzfwobUOgTaqWaJpnsCOSrwMHjVD92q/5OMVu+y2uX25n+l1ndkCwKBbRiwWSZlRsa0xyyXekU8A8WmIwJgxm5/1jWKn1uM7HeRTvoVTZF2Z++fHRiUte+xd2bHiVO6j4NJ8uTzXkMj0yABDpW84fZkpqjA5GoBh8AfgNqzxLMv9jK97xy/ZMxiGumnAxyaSazVm9JuZockBZXp/VhGE0ZPTs5CzLFH/sUCKTCB5chZwKidn+cePiBrv3i77+zEKq2Mn+VzBvhG2N+99Ys1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6TmzwvbH/47lW73OO4IgtLJN5zTyscDuVAtS/MVaFAw=; b=OOC3twsAvJWrXWfrEQ8Odf0X8TnHgstEJjqF6KeEgPdEb332EQVx5F51Y7VsUv5P1UaMh3C+KzSuUTaRKt5cRbG4vgw/wsNLNw5ZHb38aL1iJtljaqh2y//oK5Eayru8ZGZXSHX4xj5dcyP5PfDq9caWR9ybX8qYmNHrcr1YsfM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6327.namprd12.prod.outlook.com (2603:10b6:8:a2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Mon, 23 Jan 2023 17:30:37 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%7]) with mapi id 15.20.6002.033; Mon, 23 Jan 2023 17:30:37 +0000 Message-ID: <30b986fa-f4a6-baca-71b3-5c36fbe61c30@amd.com> Date: Mon, 23 Jan 2023 17:30:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v6 0/6] add trace points in ethdev library Content-Language: en-US To: Ankur Dwivedi , dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com, mdr@ashroe.eu, orika@nvidia.com, chas3@att.com, humin29@huawei.com, linville@tuxdriver.com, ciara.loftus@intel.com, qi.z.zhang@intel.com, mw@semihalf.com, mk@semihalf.com, shaibran@amazon.com, evgenys@amazon.com, igorch@amazon.com, chandu@amd.com, irusskikh@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, jerinj@marvell.com, mczekaj@marvell.com, sthotton@marvell.com, srinivasan@marvell.com, hkalra@marvell.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, hyonkim@cisco.com, liudongdong3@huawei.com, yisen.zhuang@huawei.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, simei.su@intel.com, wenjun1.wu@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, rosen.xu@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, lironh@marvell.com, zr@semihalf.com, radhac@marvell.com, vburru@marvell.com, sedara@marvell.com, matan@nvidia.com, viacheslavo@nvidia.com, longli@microsoft.com, spinler@cesnet.cz, chaoyong.he@corigine.com, niklas.soderlund@corigine.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, g.singh@nxp.com, apeksha.gupta@nxp.com, sachin.saxena@nxp.com, aboyer@pensando.io, rmody@marvell.com, shshaikh@marvell.com, dsinghrawat@marvell.com, andrew.rybchenko@oktetlabs.ru, jiawenwu@trustnetic.com, jianwang@trustnetic.com, jbehrens@vmware.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, steven.webster@windriver.com, matt.peters@windriver.com, bruce.richardson@intel.com, mtetsuyah@gmail.com, grive@u256.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, jgrajcia@cisco.com, mb@smartsharesystems.com References: <20230112112140.807233-1-adwivedi@marvell.com> <20230120084059.2926575-1-adwivedi@marvell.com> From: Ferruh Yigit In-Reply-To: <20230120084059.2926575-1-adwivedi@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0257.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6327:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ca08083-89db-41da-d0ac-08dafd678a36 X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zqmB481sObHXTKd3LzfYr6waQcxvZVzuvjB65gR7ZaqdCpa36bA5GgVVWRsT0oSF2HdJo/E5U8YxhvX8ShohHNSuqDzYXb+ImQmxONmHTNaCk7gT0BAImZJleQ1p4SZF0mT02mxvuTy7ptFCc4Ez9RaVyUvTkSFz7kUf/5HhIegnnE3Gt7NO9bL3wAOrIbchoeHIB5qQATWLWxN6mbeEFnm77JSR044S1rZzQjNs/WaOrLbPhtdWYQ4o/F5Nb//rtwNlWGT1skyElXI8IA0OzOUGNjSHKauCcQcOb/p4nHY9SxxcahANumGqvWbKWogBEH2RdIMl+PhoSqzJuF1XDzj7bM220t3Vj+tuNlZqF/4g4VD7OX/MU6oRv1wHxc3w241aDqYe5WUKjUkmgxz/gY1bwktu4FbzNJwfjjH/v7KbihQpoIk6ujMKni+TgWh02jMJD5AM2mivCFsUO4xJQAs83G3ExUDDyAgNyzsfkhyrk2YR+POtWkLcZKkYw9EG7uvC2Jse+gDVf+qBBOVBkI4N3sc8c+WLBD98bAgHIUD215X5/aK+a+WjzcZDqE73vUFLdE6W12VF8q8W7lf2StP+oBpzk8nC0YTcc3Sg3BM7e38x1Kmk/pbDqm/VZIZysMeeG4evWZQfYakc58/Y0D9xNG6qs7x53o341uAEPmLqT7Oy2NMKGp/Al+18WtNbhq9PK2SnnGB0dd9pVWPhidyQna/s6xcTtYf+V3RCeAA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(396003)(376002)(136003)(346002)(39860400002)(451199015)(31686004)(53546011)(66946007)(8676002)(4326008)(6486002)(66476007)(66556008)(2616005)(6512007)(26005)(6666004)(44832011)(8936002)(5660300002)(7416002)(7366002)(41300700001)(7336002)(186003)(7406005)(2906002)(6506007)(38100700002)(31696002)(316002)(478600001)(86362001)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmJPeGkvcXBBV1R2cHNmWldPdUNIVFBBN3dDL2REcTVZaGlCZFJJZFBva0Y4?= =?utf-8?B?Ry9kS2kxOFd0emU0QjVlWWpWZkJONm45YVNCVEFHOWFHVjI3WDBWWVBabCtG?= =?utf-8?B?MjZUbG5QU2RrVzZYNlFhWEg3c3ZLeVVhVFc3MUlaaktXUDc0bXdYbmRNTlli?= =?utf-8?B?RThxMGR4Yk5DSkVrZHJ1ZjN1ZURqdUl1TVJVSVQrSGNPTytTdGVPb3BGWCtF?= =?utf-8?B?RDBPRjRKalZKM0pHbUw1NDAzUXJSOVMyaWVJMFd5NG5HaG9jWHBPNVZLY0tN?= =?utf-8?B?MkttaW1adVZ1SGNQRHhlMHg4Tm9VNFUxNXNYMk1RL2RpWlBKZG5ua2pjQlps?= =?utf-8?B?N3FWaVNVakl0UkczZWJELzBnQzdua2J1SFVkc01jTFA4NVZoZThmVnMva01Z?= =?utf-8?B?aFgyZVkybVlzWXQ5Wk4rTEtNOU9QSXZ6Rk9pRURGSk16RTk0VXVqKzF4bXJZ?= =?utf-8?B?TzdmQ1VCTGlESFFqNUY0ajVPYU5kVm0yNXBmQUozcWNCelQxU2kyQ2UzTFpR?= =?utf-8?B?QTNVVHdKQTFESG9jZURWY1JzQXlMQzJVS1VZUjNYSVl2bTVNTmZHNmlyRTNr?= =?utf-8?B?VTZXdDVzdE40dVNRSUJJWFZySzJQd2VNQUcvS3E3M1d6ZzFqU3ZWaC9tZWZT?= =?utf-8?B?V2dZN0xRQndyaCtuMVFwNG5IREFhSGdIc2IrSUpKY3EzSWU0bm40MEJFcGl2?= =?utf-8?B?ckErODR4L2J1ekU3YytCTkNzMnpVZysvQk4yREVTQ25pQVF4Zkk4UXoyL2Rr?= =?utf-8?B?N1FZVHhWdjFObGgzUmdwY2NoWU1uOVlXRG12dW9JVFphaG5RNk1ySmtBZmdH?= =?utf-8?B?MFlwUnJ2TWlTRHluMEd0NGpyNStJbUhyUTRFaHBMQkdkQUNMdCtpMUxNZW1U?= =?utf-8?B?YTRhc1dySnpWb2FCRnpDUHk1eE1OMGhYMUEyVllLY0t1MjhTeGZ0ajgyZktk?= =?utf-8?B?aWlPdkRTRU0xT1FUWlhRODMrU0VMYWlEOWJHWkhRVTJmWDh0UG5WWXVZSVBX?= =?utf-8?B?eTdPZkdBSURuRFpkRmViMW1zZHNWNXc4eVpCaDJXSDFLUjVickp1VzVwT0M4?= =?utf-8?B?NnZWV3VBRXdTa2w1RXJNS2F0eCtHdytHMHN3YTVpcHZqUDRreVkwTXY2SERU?= =?utf-8?B?YldoRGhTMzRha3hNblVMcjhaTERBZ2V5ekk0dmErbHBmMkNxZ3RVSVBHTmUy?= =?utf-8?B?ZVFHTzlEWEUxeUFRTlNscWdkLzhYYTNqdzN1dWtMNU1ERHJxa2Y0eDA4WUJu?= =?utf-8?B?WDNPTlhSeWNGbWw0TjNvOEtUVThKd0daWjdGV2ZVcGxuSkF0QzRxSFkvNExN?= =?utf-8?B?OG1wUTlTdFdYNkNhZWQxK1lnM01ZenFyd2FGVmlJSm5QMW1aSFpCbmFOME85?= =?utf-8?B?ZTU4L2kvYndGQURJN0U4anBvNjFzVU9SUnRjSDlhRHo4TzlmeXhjMElHdVZT?= =?utf-8?B?WDFKdDBnY3dFaVkvdnBNQkhJVW5ReFZ4aWNPM3VFMVVQTXlORVJhY01oK0Fs?= =?utf-8?B?MzJNY3Z4dHVETisycjcyeDZZWU9nZEdzU3dET1VWbEErZTEwMFJtazZ5S3ln?= =?utf-8?B?d1ZYUkI5ejlSdjh5U3p5MjNMa3dDV2hhTWd2U0lVWEZzUXUxZlBtd0xvNW12?= =?utf-8?B?elRFdC94emJEYWlIOFpZNUljUk1EYWF5T0YreTRlUGNIU0c5enZCaGhMV1BI?= =?utf-8?B?dXR6S3hYbGdnbmI2NGVCeUdFaFdiOG4zbDlhdUxZTjVpT0xSck95WjdGcVR2?= =?utf-8?B?TFA4ZnVmYkNydm4yNWMzU1o4L2w3VzkyNG5kV3VVZ0YvRXBDVW56MkFnWmhm?= =?utf-8?B?SS9ZOXN3V0lrNmVML1E1cnI2YzRvSWxRblh1VmZ2S215bFIzOWt3bEVyTmRh?= =?utf-8?B?eW5yVTQ4ZDZJb20xUThXVDBjSEhlZFFDelB6R1B4NE5sNHcxRFBQM3Nxb2tJ?= =?utf-8?B?SUtReWliNDhBZGowNkpYU0dNTytDME1GYU4wVk9TQUQvYkJPUjFMN3NuWklI?= =?utf-8?B?cnZLTWtTc3VjaVBCd2d6MStTRVVhUzRnR0R1MnZaNUt6cXRjV0EyTEdobk81?= =?utf-8?B?YzEvWkh4Q2hJUWVRcHFLbHdoMy9rTXljcTdvM2g4SEhKMXRKY3hQNWpSZFdt?= =?utf-8?Q?HAD9IntLNpQlnuSQivYKa92Q8?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ca08083-89db-41da-d0ac-08dafd678a36 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 17:30:37.1934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2FO9IMdWTzw94GwLd+g8wrV2He2ooRtvVtkXv0oMlB2Ft/lZYWG74fNiApml5/l8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6327 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/20/2023 8:40 AM, Ankur Dwivedi wrote: > This series adds trace points for functions in the ethdev library. > The trace points are added in ethdev, flow, mtr and tm files. > > v6: > - Resolves compilation error with 32 bit build. > - Resolves a bug found in v5 in the trace autotest application where > the traces where not getting generated after the first blob test case. > The trace size needs to be known at trace point register, so a dynamic > length array cannot be implemented with current implementation. > So changing the metadata of blob to make the array as 64 bytes. The > length will denote the blob length(passed by the application). The > trailing unused fields will be set to zero if length is less than 64. > > For example, the following is the ctf metadata created to display > a mac addr array in rte_eth_trace_macaddr_get(): > struct { > ... > uint8_t len; > uint8_t mac_addr_addr_bytes[64]; > }; > - Minor changes in the subject of patches (2/6) and (3/6). > > v5: > - The rte_trace_point_emit_char_array function is renamed to > rte_trace_point_emit_blob. With this function an array of > any length upto 65535 bytes can be captured. > For example, the following is the ctf metadata created to display > a mac addr array in rte_eth_trace_macaddr_get(): > struct { > ... > uint16_t len; > uint8_t mac_addr_addr_bytes[len]; > }; > - Added additional test cases for rte_eal_trace_generic_blob > test case. > - Capturing of return value of a function is added to tracepoint > for flow, mtr and tm patches. > - In ehdev patch (1/6), removed extra line. Also added rx_pkts and > tx_pkts pointer in trace point. > > v4: > - Adds tracepoint function to emit char array. Also adds the > test case. > - Resolved review comments on "ethdev: add trace point" patch. > This patch is divided into 2 patches to minimize per patch > size. > - From the earlier version (v3), few tracepoints in ethdev, > flow, mtr, tm are made as fast path tracepoints. For the > tracepoint which i was unsure, i have made it as fastpath. > All the fast path tracepoints can be found in > rte_ethdev_trace_fp.h and rte_ethdev_trace_fp_burst.h. > All the slow path tracepoints can be found in rte_ethdev_trace.h. > - Capturing of return value is added to tracepoint in ethdev. > For flow, mtr and tm these changes are still yet to bde done. > Will do it in the next versions. > - Moved the trace functions from INTERNAL to EXPERIMENTAL in > version.map. > > v3: > - Moved the trace functions from EXPERIMENTAL to INTERNAL in > version.map. > - Moved trace functions call to the end, in ethdev and flow trace. > - Added code to print the input value of features in > rte_eth_trace_rx_metadata_negotiate(). > - Added code to capture return value in flow trace. > > Ankur Dwivedi (6): > eal: trace: add trace point emit for blob > ethdev: add trace points for ethdev (part one) > ethdev: add trace points for ethdev (part two) > ethdev: add trace points for flow > ethdev: add trace points for mtr > ethdev: add trace points for tm > Hi Ankur, I put some comments on 2/6 and some of them are generic comments, can you please apply them to whole series first, later I can continue the review on next versions. Thanks, ferruh