From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 24CA87D4E for ; Mon, 18 Sep 2017 18:07:23 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20170918160722euoutp02c2663d516bad69f5ebfb551ad3155e7a~lgGno36mq0031200312euoutp02B; Mon, 18 Sep 2017 16:07:22 +0000 (GMT) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170918160721eucas1p17b379d961d33152e40b78be0c8c8e271~lgGmf767w0986709867eucas1p17; Mon, 18 Sep 2017 16:07:21 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2.samsung.com (EUCPMTA) with SMTP id 1D.BC.12907.93FEFB95; Mon, 18 Sep 2017 17:07:21 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170918160720eucas1p243fd2faaa5cd4440ee0dd4f081a51b6d~lgGl4an_s3200532005eucas1p2Y; Mon, 18 Sep 2017 16:07:20 +0000 (GMT) X-AuditID: cbfec7f1-f793a6d00000326b-97-59bfef3969e6 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 19.0E.20118.83FEFB95; Mon, 18 Sep 2017 17:07:20 +0100 (BST) Received: from [106.109.129.68] by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OWH001ENGS8DD20@eusync3.samsung.com>; Mon, 18 Sep 2017 17:07:20 +0100 (BST) To: Bruce Richardson Cc: tomasz.kantecki@intel.com, dev@dpdk.org From: Vladimir Kuramshin Organization: Samsung R&D Institute Russia Message-id: <30bb4049-6336-5a61-b0bd-75924398f9be@samsung.com> Date: Mon, 18 Sep 2017 19:07:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-version: 1.0 In-reply-to: <20170918144918.GA16860@bricha3-MOBL3.ger.corp.intel.com> Content-type: text/plain; charset="utf-8"; format="flowed" Content-transfer-encoding: 7bit Content-language: ru-RU X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsWy7djPc7qW7/dHGtx/JmxxY5W9xbtP25ks pq3+zW5x+uZmdgcWj18LlrJ6LN7zksmjb8sqxgDmKC6blNSczLLUIn27BK6MRQ8uMxZc4apY Mf0oSwPjAY4uRk4OCQETif9nZzFC2GISF+6tZ+ti5OIQEljKKPGu/x87hPOZUWLxsxZmmI4V CzZBVS1jlFj/dgUrhPOcUaLn1XV2kCphgWiJj+ees4DYIgKGElsXbgXrZhbQluhr3wVmswkY SazauJ8NxOYX0JJ4vHkjWC+vgJ3E6sMPmEBsFgFVicb2yWBxUYEIiW3fZ7BB1AhK/Jh8D2w+ p4CbxJuZS9kg5ltJPPvXygphy0tsXvMWaq+4RPupvWCHSghsYZNYuOk01NMuEr1/mtggbGGJ V8e3sEPYMhKXJ3ezQDR0M0qcbZ0D1T2FUWLPsicsEFX2EqduXmWCWMEnMWnbdKB1HEBxXomO NiGIEg+Jh1O3QsPOUeLyzo2MkOD6zygx6cIJpgmMCrOQfDQLyRezkHwxC8kXCxhZVjGKpJYW 56anFhvpFSfmFpfmpesl5+duYgQmldP/jn/cwfj+hNUhRgEORiUeXoFr+yOFWBPLiitzDzFK cDArifA6vwYK8aYkVlalFuXHF5XmpBYfYpTmYFES57WNaosUEkhPLEnNTk0tSC2CyTJxcEo1 MHbnyH5yuuf4V1xKewlPm9S7qzdebzrj0lz6aYfuOtn00msuz7gF0+XdNhvZdhbLB2Qb9rE9 zxAwcVn6Z8V/kR03/gvLy/JNiXRez5l/+1j6BDf+B93tXpUHpeLbN0c3Ps2s6nrrcFA7ry/0 2LTHIj8sZAsOp+2oMJOrZVP8H73c8mfUn85vSizFGYmGWsxFxYkAtZmnuyYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t/xq7oW7/dHGnybamZxY5W9xbtP25ks pq3+zW5x+uZmdgcWj18LlrJ6LN7zksmjb8sqxgDmKC6blNSczLLUIn27BK6MRQ8uMxZc4apY Mf0oSwPjAY4uRk4OCQETiRULNrFB2GISF+6tB7K5OIQEljBK/Dq6mxXCec4o8fjHb0aQKmGB aIm2mcfZQWwRAUOJrQu3MoPYzALaEn3tu5ghGv4zSpzr3g/WwCZgJLFq436wFfwCWhKPN28E a+YVsJNYffgBE4jNIqAq0dg+GSwuKhAh0ff2MlSNoMSPyfdYQGxOATeJNzOXskEsM5P48vIw K4QtL7F5zVuoI8Ql2k/tZZ3AKDQLSfssJC2zkLTMQtKygJFlFaNIamlxbnpusZFecWJucWle ul5yfu4mRmDwbzv2c8sOxq53wYcYBTgYlXh4Ba7tjxRiTSwrrsw9xCjBwawkwuv8GijEm5JY WZValB9fVJqTWnyIUZqDRUmct3fP6kghgfTEktTs1NSC1CKYLBMHp1QDY9GXPT8rZGNvuV3v 8d+klvdhiUfe8wPnehY9YVSz9E7ZPf3quaU1XMcazZtjP83/UeWrHMNpdND899cTbosuVhu4 Hr+7LGRy3hbvsG2285hOfV+VsSj0tqSLS0u4hc2Jthc7dA5avCnanhHmUSTJF1O87oX1jHX2 UZe1bcNfpP8Ps1+w+P4sFSWW4oxEQy3mouJEAH49DHZ6AgAA X-CMS-MailID: 20170918160720eucas1p243fd2faaa5cd4440ee0dd4f081a51b6d X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?VmxhZGltaXIgS3VyYW1zaGluG1NSUi1WaXJ0dWFsaXphdGlv?= =?UTF-8?B?biBMYWIb7IK87ISx7KCE7J6QG0V4cGVydCBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?VmxhZGltaXIgS3VyYW1zaGluG1NSUi1WaXJ0dWFsaXphdGlv?= =?UTF-8?B?biBMYWIbU2Ftc3VuZyBFbGVjdHJvbmljcxtFeHBlcnQgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-CMS-RootMailID: 20170907114552eucas1p182c484310d70f1d52f64b9ea7fb96ed6 X-RootMTR: 20170907114552eucas1p182c484310d70f1d52f64b9ea7fb96ed6 References: <20170829095153.12627-1-v.kuramshin@samsung.com> <20170907114527.26649-1-v.kuramshin@samsung.com> <20170918144918.GA16860@bricha3-MOBL3.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH v2] examples/l2fwd-cat: fix build according to API changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 16:07:24 -0000 I agree with you but the problem is that in this case I should also change Makefile in order to add version checking there also but I don't know how to write correct condition in Makefile that checks if it's higher or lower version, e.g. if PQOS_VERSION > 1.3 then ... else ... If there was some spec file I'd add such checking there but I have Makefile only. Regards, Vladimir Kuramshin On 18.09.2017 17:49, Bruce Richardson wrote: > On Thu, Sep 07, 2017 at 02:45:27PM +0300, Vladimir Kuramshin wrote: >> Current version is compatible with PQOS version 1.3 >> but not compatible with higher versions. This change >> makes l2fwd-cat example compatible with versions since 1.4 >> >> Signed-off-by: Vladimir Kuramshin >> --- >> Version 2 changes: fixed checkpatch warnings >> "Prefer 'unsigned int *' to bare use of 'unsigned *'" >> > I can confirm this at least allows the code to compile with the latest > versions of the pqos library, which is currently broken. > > One enhancement might be to put into our code a check for PQOS_VERSION > from pqos.h (which is, interestingly enough, currently at 1.1), to flag > when we have an unsupported version - right now one that is too old. > > Otherwise, this is a good fix to have. > > Acked-by: Bruce Richardson > > >