From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14ED2A00C3; Tue, 20 Sep 2022 16:56:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0153E410E8; Tue, 20 Sep 2022 16:56:47 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2063.outbound.protection.outlook.com [40.107.101.63]) by mails.dpdk.org (Postfix) with ESMTP id EEBC24069B for ; Tue, 20 Sep 2022 16:56:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XsPwRGNZ7GoJuBrDZedYo+pozIAQ9ntxHZ4p6l92laSIzJAxAiRbra9r+DYE8LlDgX78ASs06udf5lhaRz8fLnIlz7cWK7lk6vHBsZ5ACzPZl7V9rffYROOZkUojwEe0G/5BDjfxgna8NwlCVwRQ5Dyg2JUDES0rtPgjPZ+cSOaB6NTEp55mHoh9Rdu9URZZz376xhTvlPRQ+YhhxJYAHFpCmugdlzIMKkoRgNaaQXYdv4Bn2HrZMj1aB6yGKS4ju1Yde+iokDwRmsbzr3qjrjJ1G7bnKS2wkDj8DxDaFjrxsrvUPs4KkiinwLrd6WKY9MK9iQbCPtIAcF1yHYrGdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fO44I9JStjq+HTG1ZuYIqVc+Dlyx4EroMhYjOvF4OX4=; b=a17UmydrenGupP4gELKl7v3Y1hObd2ARLNGuJtQGP6ddLLii7jIH5elnfOJGSiZoUmBmaSqwIihlrKOcJkHhWrHX9ZG9gEFgdN1GcaF9RTN/R0VPCDWR4+9gbA61S3Ajd53kCthBbKNIXTJ7fwzNF16BWhyCIRiuwx0is2TKELqtGCXusG+Vz1YGyCYrS6QqRYFENLNFfTPynwOmbWU/Z9CV2SBaamd1xcAMwczmvyu6tPO7aaloT/WlzW1abGz+CxvCaaJIOPJY4yIK7lCpmc2K3xN3obpnCGBHWGu/G9tib5h9JFfcUBJ49DnaFTKRSBIbOy5hd03A1PpGaGQhTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fO44I9JStjq+HTG1ZuYIqVc+Dlyx4EroMhYjOvF4OX4=; b=MVRZg2xDL1yxusMpPUStpVNdPFA/iHm5FvL3T2Ffw80KY2qgGUOlg6V0QQv+N/W6zYTpND8ELgaZl6A6VxwSBowQxyq4Uxw/YbKQuRbdF0gHwFPKdp7PcZZgwo4FGhKGrMQWHfqgXAxrcL1MBEASDeo6jsyUBZbraMKG3wFBaHg= Received: from SN7PR04CA0236.namprd04.prod.outlook.com (2603:10b6:806:127::31) by MN2PR02MB6831.namprd02.prod.outlook.com (2603:10b6:208:1d1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Tue, 20 Sep 2022 14:56:43 +0000 Received: from SN1NAM02FT0062.eop-nam02.prod.protection.outlook.com (2603:10b6:806:127:cafe::c3) by SN7PR04CA0236.outlook.office365.com (2603:10b6:806:127::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.23 via Frontend Transport; Tue, 20 Sep 2022 14:56:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0062.mail.protection.outlook.com (10.97.4.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 14:56:43 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 20 Sep 2022 15:56:42 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Tue, 20 Sep 2022 15:56:42 +0100 Envelope-to: chaoyong.he@corigine.com, dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com, jerinj@marvell.com, andrew.rybchenko@oktetlabs.ru, thomas@monjalon.net, david.marchand@redhat.com Received: from [10.71.194.74] (port=60647) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oaefy-0003tN-88; Tue, 20 Sep 2022 15:56:42 +0100 Message-ID: <30e1463b-22c6-cd26-acf3-c38c05ea477b@xilinx.com> Date: Tue, 20 Sep 2022 15:56:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v9 07/12] net/nfp: add flower ctrl VNIC related logics Content-Language: en-US To: Chaoyong He , CC: , , Jerin Jacob Kollanukkaran , Andrew Rybchenko , Thomas Monjalon , David Marchand References: <1663238669-12244-1-git-send-email-chaoyong.he@corigine.com> <1663238669-12244-8-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1663238669-12244-8-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1NAM02FT0062:EE_|MN2PR02MB6831:EE_ X-MS-Office365-Filtering-Correlation-Id: 768f4573-d058-431d-0c55-08da9b185526 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: daLCWg83RReIkHAWV7rKLlZB2ap6QfbwA1GVP/cJnmIFiM4uByTJT+h85leTcemNlcsAgv0WLeTED3BAWN0yy0NBDjVKJNq2Q6al0W3e5+Z3S6s7nzBzhA0XGpITy/oEV5U57NY2CvhAzObekfYthYmIAB/vZNTPOF1JOQ31wot4GOwxuNNDfvm/NxhHVK8OCqtiZkh0crXvFhoWa21hRtf9ZWgj5ZZXU1A/I0cVWFj05xLUkyKd7Rx6tpTEW6WOoSBRWjJrkNgDILcuqAj40hifvI4rEQPhNWyid0Ctx+BjnW/bEtPD4qEg5Hjw1D/Y1Gb9ll34Gq46C5LTLx3wYjpIokK9r+AvALDtgEKz3lGb7RBm6mqqhD91IcPm766QW09efgiO7QsXNHnNGR3RT3xP9BofuNeazy9vj4f4z7Lu6uuvgVG53OvQVFRD5rCyGdz5q5Ub3h2HV/TpxqIMcBUqOKyWtHrWf1FlicbJt69yQHMgHf7N3i6xZYKyjn0YZX+UTosQJunRtwQu2snWGzbMPrTapJXd06unmzgoXYacqyG9umuh22MCPhWynuOwghZjgaJAj4cJVkYpwU4vw99+P2whmNZspPKZ0Rp9yJgQx0y4kwUeFkRoC5/53BkHWGRj4TecPmyFk1mbB/3FOoB4Bu9K0KrkFIOpzrwvQd/Jz+dB8nsJj1040iE4hPf7LB4MNr0NerYHxPOq3i4Z5wU6RcnZOVSmMzoby7E10qYoCVaU0hwwv033QqblEY+Smnz/aAOAC5RDvg7SWQSboN0Mp4KklcK7Hg+FaQA9Dij8oSERpOw9L0drKL3Y19qoWzx9CK6RVyT64HS/l3N1xQ== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(46966006)(40470700004)(36840700001)(31696002)(7636003)(54906003)(356005)(316002)(110136005)(2906002)(336012)(82310400005)(53546011)(26005)(426003)(2616005)(47076005)(186003)(82740400003)(40460700003)(36860700001)(40480700001)(478600001)(41300700001)(36756003)(8676002)(31686004)(4326008)(5660300002)(70206006)(9786002)(44832011)(8936002)(70586007)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 14:56:43.4080 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 768f4573-d058-431d-0c55-08da9b185526 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0062.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6831 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/15/2022 11:44 AM, Chaoyong He wrote: > Adds the setup/start logic for the ctrl vNIC. This vNIC is used by > the PMD and flower firmware application as a communication channel > between driver and firmware. In the case of OVS it is also used to > communicate flow statistics from hardware to the driver. > > A rte_eth device is not exposed to DPDK for this vNIC as it is strictly > used internally by flower logic. > Hi Chaoyong, Similar comment with previous versions, interface is created using regular 'rte_eth_dev_allocate()' API, I think interface will be visible to application, I can't understand the need of creating an interface for control. What is the communication method between driver and FW? Since one of the following patches (09/12) introduces Rx/Tx for ctrl interface, is device interface is control packets (similar to network data packets)? > Because of the add of ctrl vNIC, a new PCItoCPPBar is needed. Modify the > related logics. > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund <...>