From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B651A0501; Thu, 5 May 2022 21:58:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C07740E5A; Thu, 5 May 2022 21:58:14 +0200 (CEST) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.133.74]) by mails.dpdk.org (Postfix) with ESMTP id 10FD740C35 for ; Thu, 5 May 2022 21:58:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651780692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M6o8/UhQOHKUfuHU9S+msd4k1xDM54k5A327fJXqXNI=; b=CpNUffbND4K1cgnrjtEvoN/Jo9vUQNsrQ1dRMjIkk3nXTmS6YRAC3cDcrxJKkHnpfDmJxZ lBqaEZO3kIU4U3snXLNe5J3sNOq5a0//DFs6i24hoygnrgled21ZdNjKz0MkhZIoBjcKpM +f7zlLaZsTrt3w0WLYNvz6N8O0xRGJY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-176-mNPAN30xO0m6PjBbQypCKA-1; Thu, 05 May 2022 15:58:11 -0400 X-MC-Unique: mNPAN30xO0m6PjBbQypCKA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2FC233C01D84; Thu, 5 May 2022 19:58:11 +0000 (UTC) Received: from [10.39.208.18] (unknown [10.39.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 97717200D8EC; Thu, 5 May 2022 19:58:01 +0000 (UTC) Message-ID: <30e33d90-f3b5-8102-3298-1c44d9978f27@redhat.com> Date: Thu, 5 May 2022 21:58:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 2/2] vhost: validate fds attached to messages To: David Marchand , dev@dpdk.org Cc: chenbo.xia@intel.com References: <20220425125431.26464-1-david.marchand@redhat.com> <20220425125431.26464-2-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20220425125431.26464-2-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/25/22 14:54, David Marchand wrote: > Some message handlers do not expect any file descriptor attached as > ancillary data. > Provide a common way to enforce this by adding a accepts_fd boolean in > the message handler structure. When a message handler sets accepts_fd to > true, it is responsible for calling validate_msg_fds with a right > expected file descriptor count. > This will avoid leaking some file descriptor by mistake when adding > support for new vhost user message types. > > Signed-off-by: David Marchand > --- > lib/vhost/vhost_user.c | 145 ++++++++++++----------------------------- > 1 file changed, 43 insertions(+), 102 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime