From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0075.outbound.protection.outlook.com [104.47.38.75]) by dpdk.org (Postfix) with ESMTP id A8D701B010 for ; Tue, 9 Jan 2018 08:07:31 +0100 (CET) Received: from DM5PR03CA0028.namprd03.prod.outlook.com (10.174.189.145) by CO2PR03MB2359.namprd03.prod.outlook.com (10.166.93.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Tue, 9 Jan 2018 07:07:30 +0000 Received: from BY2FFO11FD048.protection.gbl (2a01:111:f400:7c0c::167) by DM5PR03CA0028.outlook.office365.com (2603:10b6:4:3b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.386.5 via Frontend Transport; Tue, 9 Jan 2018 07:07:30 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD048.mail.protection.outlook.com (10.1.15.176) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Tue, 9 Jan 2018 07:06:59 +0000 Received: from [10.232.134.49] ([10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0977PZt015285; Tue, 9 Jan 2018 00:07:25 -0700 To: "De Lara Guarch, Pablo" , Shahaf Shuler , "dev@dpdk.org" , "Ananyev, Konstantin" , "Nicolau, Radu" , "arybchenko@solarflare.com" References: <20171123121419.144132-1-shahafs@mellanox.com> <2cde002e4430cdc6ad44d6d1801994171b7a8340.1513081087.git.shahafs@mellanox.com> From: Akhil Goyal Message-ID: <30ef29c4-0b70-281e-7e8a-0c82b196562a@nxp.com> Date: Tue, 9 Jan 2018 12:37:24 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131599552197482698; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(396003)(376002)(346002)(2980300002)(1110001)(1109001)(339900001)(3190300001)(13464003)(199004)(189003)(24454002)(31696002)(59450400001)(2501003)(8676002)(36756003)(6306002)(356003)(77096006)(106466001)(31686004)(93886005)(83506002)(316002)(81156014)(6246003)(53546011)(86362001)(110136005)(81166006)(76176011)(58126008)(85426001)(8936002)(53376002)(47776003)(68736007)(50466002)(65806001)(230700001)(53936002)(2486003)(23676004)(67846002)(65826007)(97736004)(65956001)(2950100002)(966005)(5660300001)(105606002)(64126003)(229853002)(498600001)(305945005)(104016004)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2359; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD048; 1:392gIo0sHX2gv4EODPb3vceVj2fHzpquTSFjO4mNk8oTqz49Nx+KVCGO9tkf57Q3FEASEUGGde5ijLB64FHS8cOBG6+3uE3S/c96pVs6FlTrMohb0an1jMG29JMWTht0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a51fd339-212d-4d9d-d8ca-08d5572f93cb X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4628075)(201703131517081)(5600026)(4604075)(2017052603307); SRVR:CO2PR03MB2359; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2359; 3:vv4payRjg96ONyyHonJ3JCe0ycYC67iDF4YcYx1R+NqMxQM3tMehe5yCZeZhqzn1GhTfNWJQjE0yvwM3r3rRAfRPMkWhqMbQfycLEqvzgaslvzNDvisgzmsWtHXMvZMyVlRhD7wRwHD5mwUeJqR5coEiqylPh+1jr4iNEKxvJ0cG405Unr/FsR4Me2Yp6DDLc5N8V3uK3tYvFxU3BjqO3gn0YB/2Awte45N3oD1sTB1xrg+wuUPyVEcIqzmeDG149WFQljCmcbB5frmWO2rdbR9rNLQQyIw1jn9ThFdLWY4d2Soi3Ghtmn4KrdpJUvmD9qiIvwKl9RnqVf1gRcehzIdmaR2+YJG0t6LxX0VjXtA=; 25:hvQf+lKPS/fycgUjlq0JPoS30dRkgNO8eVwXB29GdIhG6zOS2OOMMcLlJ53lJjY1ztUQGp1z/ufQbwnG3MYS9l9Xz+VsJEWUsT6LubO9IDSWmETrKwhLzKkVK3i8Nr/e0Sv4qA1ffd9BvaoKYXqeaWCNrpDQ/8mfbsNprjl9oPOApb+f+5EgTq7nuegadz+u5op0C/yROVMpQoCA5Pf7UEtWW7B6kQP3EWwsris1ooaE+IhaUaqBdjPuO4Gkf1xjzkseP8dIN9PbKd720wW00YyuI7bTqSGm8G0dGAN/wWy5n91Yl2dRqoE1xFw9wTyF0SyYX48nYsKTkOmHizHl1g== X-MS-TrafficTypeDiagnostic: CO2PR03MB2359: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2359; 31:K7+1mHwk+8rQ67/Sniv4YrFZRerDvLeneJzQO81ZI+xBQZ4Sj7UkW58KIrxjLBCvrWq+sK/tzT3bF+HAlXaTNhjXxe32LEdwIBctqDxdq+zx1nuhdKZ3PbAEJUSQq/YbUhd4yjFBny/ThLLUVxenKK6dGy3HY5Tr0BqL7m1VnZVJZSVrMR9x/Kc8/g6VH9lsftHcGNhm+8fjXwEWIIiEtxzBIryFmbn5UuLx3L/aMVg=; 4:GG1bGGRvouW9iQEUDyoKKO53DzbwfukVPcWvXYUE6kEdKdRLYD4E+J+CXnti8yYcRKYDlBOFXIeeHMKQ/Mx70S0FX4CXKKMbzV4PcyyZaGuOlQvEzJGGJVJbn6trj+dh/7jGKa6pZk800zO5bYxPZT71pE9dWtPmr5LAJm/qZSEXELxN1H9adi0W5H8q2Nu1ebRtkkHWXFuSV3eZmRUiAfoJLptHdUtFO7udn79MTI+1bAPf9lEhN84Khf1QWdB/s/T9q+uK7N22oWeqDs7TZJmOZb9c/RY+LOEX4yNoM0BZrCXKyplMjHsmyMcVI3kX X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231023)(944510075)(944921075)(946801075)(946901075)(10201501046)(6055026)(6096035)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123565025)(20161123561025)(20161123563025)(20161123559100)(20161123556025)(201708071742011); SRVR:CO2PR03MB2359; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CO2PR03MB2359; X-Forefront-PRVS: 0547116B72 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjAzTUIyMzU5OzIzOmpHVGlhK3A3MVJnWTAxQXhhRTBZaVNFQVBj?= =?utf-8?B?MDBlYmxqaWZvdStuYXpGUlV0eDl1eld5NWQyWXVLdEVSVEhuZ0ZNdVVvSC9v?= =?utf-8?B?ZFp6RTNVbnFRc1lUYit2dldKZW5YaG9wY3FDZmkvVkVOTUVLR281V01yZ2NL?= =?utf-8?B?Q214L29CbzV0cjJ1VTlPUkVSUXcxczZwV1gzVSsrc28rMmJyaGFZTmEvSlJQ?= =?utf-8?B?QUlGZEg1L3BlZzcwTjJtL3QwZFVuMkgxSm1nYkVoM1ZTVFBQUVU2R1JWdzAy?= =?utf-8?B?WlRXeHBRaEFDQytnVUIzNHQyYk81bGh2UXNRUyt3SEpVNnVWd2NjQ2syRXVn?= =?utf-8?B?NWxXN0w2VjB0cGRYczY1V0NhZjJVTE04QU1HbVExMFhVYW4yS1AzanlscUJu?= =?utf-8?B?R0dRZjJzdUpIN0NZR0tpZzJMWFIzQ2d2eTBieTloRHgyazc5bmpRbWdBYWpr?= =?utf-8?B?UVVTLzF6NWJOcng1WHFpclpqS21DOTl5eFQ3d2dXN2FabnF1RlVaZnNML01D?= =?utf-8?B?OWx4ZmgyRk13eUNpM3lQM0R3dFZEcmhHOUdEQ2tWOEJUbXVFRFJRY2ZYZVBM?= =?utf-8?B?RnJob2QrMTBleC9yalg5eGVFdWJuVHd2WFBCRmpDQmhmbGNWRGZ3cUR5emx5?= =?utf-8?B?TmdKYlJsUXhKeHNTYjVFSWhmOHBBTHhGZFpEaGhxY04xR3RNL1B0empaUCtl?= =?utf-8?B?TGpwZGFVMHh3WlBZUmloa0pMcEdZMzFvRGRyVkg3TWFoQmtXZVFhY3lkMzlZ?= =?utf-8?B?RWJ3VWZpMGVLOHlYN2FtVnovaElxQmQ3aEtlUkE5N2pUNWlJNXN3N0xxZTd3?= =?utf-8?B?MmkrVzA4ZHAzVWpncm9xYzMzSFZnT1J2SGx1c25uSHVhK0lQbzhVVkl5YUZU?= =?utf-8?B?YTU3bHozMU81b0FGTzhTQW02RWw2WnFlek01ZHRQYld1WXplRnlWQmNtMHFL?= =?utf-8?B?YkFBVGtnSG9OZDNaMXZzOVRhZVhORkd4YXNUc2Z3ZVFvZ1kxUmxTaGVORzJx?= =?utf-8?B?UlZ1czdYcUtzM0JZVi9pSnErQ2thSTNLRzRCdS9wMlIwRTR4ZkNWUEVjN3BJ?= =?utf-8?B?c3ppU1BFWkdsR3NaMFVBM1dJdFZUTG5UR2FwSmc5UGdUd0QvSUNacERHd1RN?= =?utf-8?B?ZlRtYjlaMFY2Mm9MQk0yTXVwNUN4SDRhT2xERTk5U1dzYWo3dVBCZFFiOGZv?= =?utf-8?B?UjJPK1hSNTVSei9CMGhTYitqQlJnNGtFeUtSTXRrN1NsNnp0TTJSaitLOWox?= =?utf-8?B?cEpIQVRSQnN1YUFDS1JpcE1qZDliQXFLaVEwUHJqckQ3bjl0MTBQSXU0VTR2?= =?utf-8?B?QjNpbUhKTVpTVnIzV3RiTjVqWEVUT0Y2ZWZsVXJYQ2MyV0pXT0VHdzFsQjFR?= =?utf-8?B?RTBId29RbFFaWWtjdElmeE5HZE1ReTBVT1hzSStwMXIzRy82T09UL21XTzk2?= =?utf-8?B?SmFhaDViS21DMWNSWkhnRVRTc2NaNCt1N3dFZ1U2aFIreWh3NkJuUWROK2Iw?= =?utf-8?B?RHUvWi8rbFE0S2wrRkRseWdpRzhWQ2NYSm9RSmhVZHRKYjhsWDBuQ0pVVi9O?= =?utf-8?B?cmlCWU1JN05kQmx6Z01yWEZmaGpxdzNCUGFXV1hOWnJ6VXhraHFqNlpCYURh?= =?utf-8?B?RFdLNXNzcmhiQ0NNamk3NytQaUh5SzhBbGloRG9oTXV3aW9zaG85RzRML2xG?= =?utf-8?B?WVVkR2lDSkFLV0tOMTh0Sk0zYS9KVS9jLzlWWGdJODQ4dWZqYTBONDlGOFRD?= =?utf-8?B?QjA0ZEFDcXNRSkFrd3dsZUtxcWpkdHVoTjZhaTdxNzFrdFFmK3N5MEVjT3dZ?= =?utf-8?B?eE82WitVUWFXOE5MYVNydkFsMzl1TkVuY3JPK1Z5ZngxanBjc1Jnam9DcUg3?= =?utf-8?Q?GlukvtQCtzD70Tg3+pnquPcn3q8PD9BQ?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2359; 6:4aDLj3ICawlLLr2cx5jnZ2b5jKL5sZjFfdf84nfkK3+j6HS3vxgBXfsOkJee9pbZvh6SrQmr21XWnAvUWo+1m/Y5JnDXhGSepJ7dwwIlEAj1yZqtvHCrrxuw2ZTHRpxtA/VpzJ9dPGe0hJ5E+THfxWlgnTjCi1kRqGuJzuVA4lzTgem+oxEUaSic9gtOdFU8j9XCbuyqnGLLnJ6cXo5sUQvd3Q2Fx9392j4G8FRwl9j4UJDs4wa9q89I1qsUDr/OfxJj3Fo294w/0hDw5lDy8VQdFBBo0MAfM33vY6gW9YAmGiAe1HWR76RhZtRG36O5mFPBMM7NgVt2UljcXgQyvPlMjPOg85pfTobsuNxJ96w=; 5:qrtqBJWHX83MgGqN2Kf956FxynQxPu59uGuhAx8g9CHvlkgu0h8Jm8H0VQc6AddGJiRfoEYQQF0pfPLeIal25CNxYRKgtZCgmbqQosDjLxdRPimsOJ4N4rOjYCAVb7PWMPiQoDVm8xRjq6Tt2aQgRoGKONFLHHG19NEnTylpZqc=; 24:2mIF+2CLUCamEg4M4uBH9A6Pa43on+F7fbNfG+RM9sg+TUcCmYTkeX1tRRoc1giUWFNC7Xnl2iP00QwKJ03F2yP6/CDuEQhAFXQW6GFGUNM=; 7:8ejSrooeQ1P7Me4PRsU0sYmy4LFjT0a5UOfcr1uqMKvPwEXN/oBlrDqdbvLPDr9sIQaomPFEs0Qbf00w1Agf/GbC5sYoFLFBS+wtxy/lm+Fi69dyJcADj/pDw3M6JvDOilvF38oqWViqOWR4nRNCmAHIeb9iF/exxvO9jXMCKx+qsOEAaD5STpnhpMmLj+CUSRGdOE5nbI/0n8YtiOYK6syMeIu7cHkWJO9kAth5wLcww3I1OPF2YKdHJcIm2vKe SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2018 07:06:59.4986 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a51fd339-212d-4d9d-d8ca-08d5572f93cb X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2359 Subject: Re: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to new ethdev offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 07:07:32 -0000 Hi Pablo, On 1/8/2018 9:57 PM, De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: Shahaf Shuler [mailto:shahafs@mellanox.com] >> Sent: Thursday, December 21, 2017 1:45 PM >> To: De Lara Guarch, Pablo ; >> dev@dpdk.org; Ananyev, Konstantin ; >> Nicolau, Radu ; arybchenko@solarflare.com >> Subject: RE: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to >> new ethdev offloads API >> >> Hi Pablo and maintainers of ipsec-secgw, >> >> Tuesday, December 19, 2017 2:39 PM, De Lara Guarch, Pablo >>>> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- >>>> secgw/ipsec-secgw.c index c98454a..1e8af8d 100644 >>>> --- a/examples/ipsec-secgw/ipsec-secgw.c >>>> +++ b/examples/ipsec-secgw/ipsec-secgw.c >>>> @@ -217,6 +217,9 @@ struct lcore_conf { >>>> }, >>>> .txmode = { >>>> .mq_mode = ETH_MQ_TX_NONE, >>>> + .offloads = (DEV_TX_OFFLOAD_IPV4_CKSUM | >>>> + DEV_TX_OFFLOAD_MULTI_SEGS | >>>> + DEV_TX_OFFLOAD_MBUF_FAST_FREE), >>> >>> Hi Shahaf, >>> >>> Isn't this removing some checksums that were previously done? >>> Txq_flags was set to 0, which means that SCTP, UDP... checksums are >>> disabled now? >> >> You are right that before txqflags were 0, but it doesn't seem the >> application uses any Tx checksum offload beside IPv4, as seen on snipped >> code[1]. >> If I was mistaken and it does uses L4 checksums then I will need to update >> this commit. >> >> Maintainers of this examples - can you confirm? >> > Akhil, Radu, could you confirm that this change is OK for the IPSec app? > There is a v3 already of this patch: http://dpdk.org/dev/patchwork/patch/32711/ > > Thanks, > Pablo > I believe Radu is a better person to review this one. It is related to ethernet offloads. -Akhil