From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C5D845500; Wed, 26 Jun 2024 13:57:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E33F43382; Wed, 26 Jun 2024 13:55:23 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 191CA42E95 for ; Wed, 26 Jun 2024 13:43:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719402224; x=1750938224; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PAAotW8m1VM/Rd2MXD8PcCNhYyGUQlkLiTiY5pMowl4=; b=dgACvqUx1VUWMhFSW8uodTVQiPpHpJNmqSlqSsi7Rx1d6mEoQRwAChOY T/UZ3NF9Z+JxF4JS+GhUNQefMG2vMqC0uWnfwEYCprMfA5u/CvxIT/jV7 wfKmbmEYtP/9dWQGk8ZKoGYJ53P1QTJ5jHQX++GFYo5wu9LGxTkCDYjU+ HfNwIGRsfxRKa3nSM1fX6w8dnELF0dd57sI9w9wiyiU0xFIytiOw0+e6s A/+bRB1Ph1rFee8x8zUymXAh5Zb52mN6eyPG2mz8nUMuD/DMIY7GL/3Jr JDlPGtztBsLCwC72ZWH0B81S8y0Z8uee+PRb8XfMfRTBkRthZ1iTkQ3gC A==; X-CSE-ConnectionGUID: ueVLfeaAQZOLMuj8hMjcJA== X-CSE-MsgGUID: Qay1nu1+Q7iSzd40LMO1hg== X-IronPort-AV: E=McAfee;i="6700,10204,11114"; a="38979355" X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="38979355" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2024 04:43:43 -0700 X-CSE-ConnectionGUID: UHa4xBLqSQyv32xztoLafA== X-CSE-MsgGUID: B+LWggB3SFysmI5PibuvwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="43873626" Received: from unknown (HELO silpixa00401119.ir.intel.com) ([10.55.129.167]) by orviesa010.jf.intel.com with ESMTP; 26 Jun 2024 04:43:42 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Adrian Pielech , ian.stokes@intel.com, bruce.richardson@intel.com Subject: [PATCH v4 026/103] net/ice/base: remove dead code from ice_get_ddp_pkg_state Date: Wed, 26 Jun 2024 12:41:14 +0100 Message-ID: <30f414466f048eadf902582168d1ed271c9eb8f9.1719401847.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Adrian Pielech Removed "else" statement in ice_get_ddp_pkg_state() as it may never happen. Signed-off-by: Adrian Pielech Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_ddp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c index fcf6dc69e3..5a0cf4d54f 100644 --- a/drivers/net/ice/base/ice_ddp.c +++ b/drivers/net/ice/base/ice_ddp.c @@ -1205,11 +1205,8 @@ ice_get_ddp_pkg_state(struct ice_hw *hw, bool already_loaded) } else if (hw->active_pkg_ver.major != ICE_PKG_SUPP_VER_MAJ || hw->active_pkg_ver.minor != ICE_PKG_SUPP_VER_MNR) { return ICE_DDP_PKG_ALREADY_LOADED_NOT_SUPPORTED; - } else if (hw->active_pkg_ver.major == ICE_PKG_SUPP_VER_MAJ && - hw->active_pkg_ver.minor == ICE_PKG_SUPP_VER_MNR) { + } else { return ICE_DDP_PKG_COMPATIBLE_ALREADY_LOADED; - } else { - return ICE_DDP_PKG_ERR; } } -- 2.43.0