From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 2383A1BE18 for ; Wed, 4 Jul 2018 18:04:01 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B36A868801; Wed, 4 Jul 2018 16:04:00 +0000 (UTC) Received: from [10.36.112.34] (ovpn-112-34.ams2.redhat.com [10.36.112.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 353E22026D76; Wed, 4 Jul 2018 16:03:59 +0000 (UTC) To: Tiwei Bie Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org, mst@redhat.com, jasowang@redhat.com, wexu@redhat.com References: <20180702081629.29258-1-maxime.coquelin@redhat.com> <20180702081629.29258-3-maxime.coquelin@redhat.com> <20180704053940.GB28826@debian> From: Maxime Coquelin Message-ID: <30f83c77-c750-d5dd-dba3-aa34a5785803@redhat.com> Date: Wed, 4 Jul 2018 18:03:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180704053940.GB28826@debian> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 04 Jul 2018 16:04:00 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 04 Jul 2018 16:04:00 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v6 02/15] vhost: add helpers for packed virtqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2018 16:04:01 -0000 On 07/04/2018 07:39 AM, Tiwei Bie wrote: > On Mon, Jul 02, 2018 at 10:16:16AM +0200, Maxime Coquelin wrote: >> From: Jens Freimann >> >> Add some helper functions to check descriptor flags >> and check if a vring is of type packed. >> >> Signed-off-by: Jens Freimann >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/vhost.h | 6 ++++++ >> lib/librte_vhost/virtio-packed.h | 8 ++++++++ >> 2 files changed, 14 insertions(+) >> >> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h >> index cecd5c1ee..cabbc3ab7 100644 >> --- a/lib/librte_vhost/vhost.h >> +++ b/lib/librte_vhost/vhost.h >> @@ -318,6 +318,12 @@ struct virtio_net { >> struct vhost_user_extern_ops extern_ops; >> } __rte_cache_aligned; >> >> +static __rte_always_inline bool >> +vq_is_packed(struct virtio_net *dev) >> +{ >> + return dev->features & (1ull << VIRTIO_F_RING_PACKED); >> +} >> + >> #define VHOST_LOG_PAGE 4096 >> >> /* >> diff --git a/lib/librte_vhost/virtio-packed.h b/lib/librte_vhost/virtio-packed.h >> index 744b3991b..d386cb6df 100644 >> --- a/lib/librte_vhost/virtio-packed.h >> +++ b/lib/librte_vhost/virtio-packed.h >> @@ -19,4 +19,12 @@ struct vring_desc_packed { >> uint16_t flags; >> }; >> >> + > > There is no need to add above blank line. Removed. >> +static inline bool >> +desc_is_avail(struct vring_desc_packed *desc, bool wrap_counter) >> +{ >> + return wrap_counter == !!(desc->flags & VRING_DESC_F_AVAIL) && >> + wrap_counter != !!(desc->flags & VRING_DESC_F_USED); >> +} >> + >> #endif /* __VIRTIO_PACKED_H */ >> -- >> 2.14.4 >>