From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 774E343DA3; Mon, 8 Apr 2024 14:51:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4710D40289; Mon, 8 Apr 2024 14:51:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BEA7940041 for ; Mon, 8 Apr 2024 14:50:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712580658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m5fc0UJDppX6aBtKX125WoCag8gtrVjMrUOaAKkpBR0=; b=PLjCDrF3MEslPoWWp69MCZkTSMbP3QKOSZNGqViukF0qAUdG/VvMpn5hFVi5fgNkICAh+U RYHJoitrznHWR9p7DGX6qf22HE4DYDbcY+SveJ9dTIHyS5TDoJwNYhd5qaUQy16pqne54y 095d9agyMCsegGwTLOg9sae0A3RQKK4= Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-191-Nzgor1dCNRyRaLVXeC3UPQ-1; Mon, 08 Apr 2024 08:50:55 -0400 X-MC-Unique: Nzgor1dCNRyRaLVXeC3UPQ-1 Received: by mail-yb1-f198.google.com with SMTP id 3f1490d57ef6-dd8e82dd47eso6040245276.2 for ; Mon, 08 Apr 2024 05:50:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712580654; x=1713185454; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m5fc0UJDppX6aBtKX125WoCag8gtrVjMrUOaAKkpBR0=; b=WYzZ55iwtGuxmUOnlHoFCAbdvWEA0OPrv0J7xzA6Hn2v2gD5pc3VHjYR8J/lT/KmPR HEeS/wC9SMB3xxP27gTc2fEc9Gqrbfd9Z48JRwZDbXR8HWzBbau1YOepEF+ok8Ht4mXz ab+19apsDi1ATFU4vvPaXpY0iPmRA1bIMr2riRSxs0dBaUuiwipAWUNnpQ3Yc7Kxt047 Oc1DTr3ncVOjANR6l5YODGIs8wVmqfiJXUZ+Tj1vYfDohLNV7jVUIcedbbr/pvCtvpAQ UgB56IB12kLF6DFOL+X0gNlIz/7OOe8n7zgMw9aSrZea4S3Pbajd6l4IXzfRbs3Lt2hF OyNA== X-Gm-Message-State: AOJu0YwFoIPO2PRciO/EaPHUPhmPc2aRRsE+fKTmAzNxmRiuof+KEWB+ lYqd1lcgfMUlDOcwBAJE/NlwNrXeVzsJdz1lY2CeCHEoiIKwAWlTyMiaMPu5fjccWrw9mERVC04 12/ZJObOKNJpX8biB7sdxF1dai1uoIdoDr1NkbmMs X-Received: by 2002:a25:6cc6:0:b0:de1:849:a6f3 with SMTP id h189-20020a256cc6000000b00de10849a6f3mr698159ybc.7.1712580654521; Mon, 08 Apr 2024 05:50:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjXk3CBgzfz3jg3GKLw0cnGUBTxS/lUjYb/7lZTTqbB7+ieybzUX5wsEmGqxAYUt6P/uciUA== X-Received: by 2002:a25:6cc6:0:b0:de1:849:a6f3 with SMTP id h189-20020a256cc6000000b00de10849a6f3mr698148ybc.7.1712580654169; Mon, 08 Apr 2024 05:50:54 -0700 (PDT) Received: from [192.168.0.12] ([78.19.74.23]) by smtp.gmail.com with ESMTPSA id df12-20020a05622a0ecc00b00434b8812a85sm374618qtb.94.2024.04.08.05.50.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 05:50:53 -0700 (PDT) Message-ID: <30f91607-af92-47b9-aed3-0a6d47c2d725@redhat.com> Date: Mon, 8 Apr 2024 13:50:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v13 2/3] net/af_xdp: fix multi interface support for K8s To: "Loftus, Ciara" , "ferruh.yigit@amd.com" , "stephen@networkplumber.org" , "lihuisong@huawei.com" , "fengchengwen@huawei.com" , "liuyonglong@huawei.com" , "Marchand, David" , "Koikkara Reeny, Shibin" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20240404142326.2151118-1-mtahhan@redhat.com> <20240404142326.2151118-3-mtahhan@redhat.com> From: Maryam Tahhan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 08/04/2024 11:46, Loftus, Ciara wrote: >> +#ifdef ETH_AF_XDP_UPDATE_XSKMAP >> +static __rte_always_inline int >> +update_xskmap(struct xsk_socket *xsk, int map_fd, int xsk_queue_idx >> __rte_unused) >> +{ >> + return xsk_socket__update_xskmap(xsk, map_fd); >> +} >> +#else >> +static __rte_always_inline int >> +update_xskmap(struct xsk_socket *xsk, int map_fd, int xsk_queue_idx) >> +{ >> + int fd = xsk_socket__fd(xsk); > 'fd' computed here is not used in this function so generates an unused variable warning. Thanks Ciara, sorry I missed this. I will fix it >> + return bpf_map_update_elem(map_fd, &xsk_queue_idx, &map_fd, >> 0); >> +} >> +#endif >> +