From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0303A04C7; Mon, 14 Sep 2020 19:31:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBD1DFFA; Mon, 14 Sep 2020 19:31:22 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1E386160 for ; Mon, 14 Sep 2020 19:31:20 +0200 (CEST) IronPort-SDR: qF2eHeHit+aewxZU3SzYqmOIAo1nd9iJ+YGOsrM4KIJcCZI6GJxDVtsZIHiWkT5juwDneWNytM quxqCnOi7olA== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="223306464" X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="223306464" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 10:31:19 -0700 IronPort-SDR: M0EXxMcZPNPkURmRSEJcZ3B7iK27bBOWRw2rfBaTH/Slmr6t8Y+gsPUS+4GRgPhzynOjuiomOe 8wukE+BXntzA== X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="507222216" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.247.225]) ([10.213.247.225]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 10:31:17 -0700 To: Ophir Munk , dev@dpdk.org, Wenzhuo Lu , Beilei Xing , Bernard Iremonger Cc: Ophir Munk References: <20200729082905.19499-4-ophirmu@mellanox.com> <20200827070244.32392-1-ophirmu@nvidia.com> <20200827070244.32392-3-ophirmu@nvidia.com> From: Ferruh Yigit Message-ID: <30fe788b-7447-1b83-b847-bdbe3cd7d4f3@intel.com> Date: Mon, 14 Sep 2020 18:31:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200827070244.32392-3-ophirmu@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: enable configuring GENEVE port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/27/2020 8:02 AM, Ophir Munk wrote: > From: Ophir Munk > > IANA has assigned port 6081 as the fixed well-known destination port for > GENEVE. Nevertheless draft-ietf-nvo3-geneve-09 recommends that > implementations make this configurable. This commit enables specifying > any positive UDP destination port number for GENEVE. > > Signed-off-by: Ophir Munk > --- > app/test-pmd/parameters.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > index 7cb0e3d..0d135b0 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -70,7 +70,8 @@ usage(char* progname) > "--rxpt= | --rxht= | --rxwt= | --rxfreet= | " > "--txpt= | --txht= | --txwt= | --txfreet= | " > "--txrst= | --tx-offloads= | | --rx-offloads= | " > - "--vxlan-gpe-port= ]\n", > + "--vxlan-gpe-port= ] " > + "--geneve-port= ]\n", > progname); Hi Ophir, Is there a command line to update the geneve port? I can see there are some parameter for other tunneling too, but do you find providing parameter useful? I think command line better since it is more flexible, what do you think?