From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id CD4752C49 for ; Wed, 8 Mar 2017 22:58:28 +0100 (CET) Received: by mail-wr0-f172.google.com with SMTP id l37so32840117wrc.1 for ; Wed, 08 Mar 2017 13:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=OUPwNmCI3LF97KIr+4s1jegl+KcWne9vTInk1/j4qHI=; b=cM1HaCVYWZCnYtlPXFgFFOGlkruusCqTUs7wW7fm15GSMiCGzuDyoxAJjh7zqDQlqJ QVJ90er6VjZ/+zkxW7SUVY8dT7CCMkWeuc4Bf8JKDj/B5tTXZhi+4KQDqvIvEGF8dSde k6vApyqe40Ev6uCQLP27fNyvv9lvSanRabbdB4jx3NdOaUh2wRreQhhHmTuTV9fo0oFX pI+glYuaUNmRX72K+6DKg815TnlNBvi/OSbRxbHDbJtoqmIraprNaEgMdgs93ApTS8xn jDlmZBDH3PpsMpCIgVEQC0P/0NC0EfIjLl+HhfujekFuQLsnczXu+5tCVcQdV88zcPvr hQXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=OUPwNmCI3LF97KIr+4s1jegl+KcWne9vTInk1/j4qHI=; b=HLWJ/zbswsE/DM/3hzOE76PZjjqMQ9qxGaAQ+NQYCWPGza+B9xwZwx+eHdjEjoFQ0h DzP52yHQnwUO3U0akuIGTb8Km1RyNa10NBThGEX+Plkq0c1EIxGrYnctP9L1ngPdlZyV buUuebaYs+h/7yq6GLGGzkN2/vOuHyu22BZD0VpPN6GlHJU9dT0y6plxuANJy7uHnGJ/ wHFQ2ncOw296UDpXXWwJ3sSugCH8AukNiWJpAH185kibZKDKw00AArpBZfdz712wzuH/ qF/iKat2z1wIMltbMzXc6ROFlZi/r4Q6WqpJ+UuIITx28VehNw5gaIPevGlh3qY3wI9U lcCQ== X-Gm-Message-State: AMke39lmO8DX/HhrcZguTsM7hvkd/19UpI1OF03ReyttG80YmMLQZ0dbo1xwTJIdtk95jCxo X-Received: by 10.223.164.16 with SMTP id d16mr7146178wra.47.1489010308504; Wed, 08 Mar 2017 13:58:28 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id d1sm5743204wrb.62.2017.03.08.13.58.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Mar 2017 13:58:27 -0800 (PST) From: Thomas Monjalon To: Aaron Conole Cc: dev@dpdk.org, Stephen Hemminger , Bruce Richardson Date: Wed, 08 Mar 2017 22:58:27 +0100 Message-ID: <3101203.dHUXMUouNS@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170228185315.12546-1-aconole@redhat.com> References: <20170227161811.12309-1-aconole@redhat.com> <20170228185315.12546-1-aconole@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 00/26] linux/eal: Remove most causes of panic on init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 21:58:29 -0000 Hi, Thanks for the work. I think it needs to be completed to have the same behaviour on bsdapp. As a another version is required, I add some small comments about the formatting. I think you should use the form "do not panic on " for most of the commits. Some commits may be squashed (see below): 2017-02-28 13:52, Aaron Conole: > Aaron Conole (26): > eal: cpu init will no longer panic > eal: return error instead of panic for cpu init squashed? > eal: do not panic on hugepage info init > eal: do not panic on failed hugepage query squashed? > eal: do not panic if parsing args returns error > eal-common: introduce a way to query cpu support > eal: do not panic when CPU isn't supported squashed? > eal: do not panic on memzone initialization fails > eal: set errno when exiting for already called > eal: do not panic on log failures > eal: do not panic on PCI-probe It is not really the probe here > eal: do not panic on vfio failure > eal: do not panic on memory init > eal: do not panic on tailq init > eal: do not panic on alarm init > eal: convert timer init not to call panic > eal: change the private pipe call to reflect errno > eal: do not panic on interrupt thread init > eal: do not error if plugins fail to init > eal_pci: continue probing even on failures > eal: do not panic on failed PCI-probe squashed? > eal_common_dev: continue initializing vdevs > eal: do not panic (or abort) if vdev init fails squashed? > eal: do not panic when bus probe fails > eal: do not panic on failed bus scan > rte_eal_init: add info about various error codes