From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACEA9A00C5; Sun, 26 Apr 2020 20:08:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7DEBD1C122; Sun, 26 Apr 2020 20:08:56 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 5109E1C121 for ; Sun, 26 Apr 2020 20:08:54 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id E6097473; Sun, 26 Apr 2020 14:08:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 26 Apr 2020 14:08:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= cLGuQ2rm8bANPHF8C+wDT3mMuUJ658d2IaQoJ/CkH4U=; b=P9nwA1LudN7KmyoE E3a/vLUMNdqDUqFxLStuoHYBUVJ+VXsnxJMoV/pXdWebTu/ODhVZ5HjgIb6wTbhu QJQMxotHReg+OM/TCiuukQGyB42N+WVOU/yUcMfwLDouzu9lrFIO+tmZNlEwbo65 txUUfKWmLNoyoqXCafo9Dcj2idAmBZdl5ynaBmSpV/DRrhSTTvnL5KE0aKM7NNns ofcjGN/2xDWMN+iHbln/3UTrSCtfyEEZJE+6sdcf7ElwIaiUGXajdS8du1qAsvIj aHApghNr8CDpzrQg+heLGT1hB6VjDg31FdPFzHgLW9GHo06P5KoSwFhV5MChYuBo 1x9egA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=cLGuQ2rm8bANPHF8C+wDT3mMuUJ658d2IaQoJ/CkH 4U=; b=nhjSYX1mGTqGVBfIigjgFLKpRqB4v78bFjqVqeshGwOvuPg2bFOonWNtV cGA173aOLdjJiqpoaeWdCSbvmxLc96cOzA7b84E1AwlRsGBJABBZfE4TWy74agOG tCTgMpSno1RCd26SRsU3NWFCjc7QrHPV6G16i0m7BFANKNfHXkQJx9FWtPntG563 Qb9oapwyvu0Nq+SYINOnYXJWdOOKKk8NJqq9YSAKqVmo8buOtNizPhIlOm1QwXfc cJ2p93AqUN9zmpg+fDGgJfeqaY/OD9yGjc3eJDo2I3T7DUxllfj3UvuOjsqjdNx8 hN9c0b7xWgcYkZeZwECE/ZikVOH5Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheejgdduvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg hssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 37DA13280059; Sun, 26 Apr 2020 14:08:50 -0400 (EDT) From: Thomas Monjalon To: jerinj@marvell.com Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com, xiaolong.ye@intel.com, david.marchand@redhat.com, hkalra@marvell.com, Jerin Jacob Date: Sun, 26 Apr 2020 20:08:49 +0200 Message-ID: <3102527.CAdn2TfLgq@thomas> In-Reply-To: <20200426173811.49788-1-jerinj@marvell.com> References: <20200426173811.49788-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/04/2020 19:38, jerinj@marvell.com: > From: Jerin Jacob > > If the PCI device is not attached to any driver then there is no > point in probing it. As an optimization, skip the PCI device probe if > the PCI device driver of type RTE_KDRV_NONE. > > Signed-off-by: Jerin Jacob > --- > Notes: > ------ > - virtio drivers does special treatment based on RTE_KDRV_UNKNOWN, That is > the reason allowing RTE_KDRV_UNKNOWN in this patch. > - virio devices uses RTE_KDRV_UNKNOWN for some special meaning, IMO, if it would > be better, if > a) Introduce the KDRV for virio > b) If the PCIe device of driver type NONE or UNKNOWN then not even add in pci > list > in the scan, It will improve the boot time by avoiding operation on > unwanted device like sorting the PCI devices, scanning it, probe it, managing > it etc. mlx4/mlx4 uses RTE_KDRV_UNKNOWN. > - Initial problem reported at http://patches.dpdk.org/patch/64999/ as > boot time printf clutter on octeontx2 devices with a lot PCI devices which are > of type RTE_KDRV_NONE. Add a logtype for PCI driver and adjust log level accordingly to your preferences. > @@ -271,6 +271,8 @@ pci_probe_all_drivers(struct rte_pci_device *dev) > FOREACH_DRIVER_ON_PCIBUS(dr) { > + if (dev->kdrv == RTE_KDRV_NONE) > + continue; > rc = rte_pci_probe_one_driver(dr, dev); Nack