From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13ABD43A46; Wed, 7 Feb 2024 12:54:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0556340279; Wed, 7 Feb 2024 12:54:20 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2050.outbound.protection.outlook.com [40.107.244.50]) by mails.dpdk.org (Postfix) with ESMTP id 0BF3B4021D for ; Wed, 7 Feb 2024 12:54:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TBJBubXgORSonUosGs20mkAgY7PKwK0hI4/TIp7Zuozmx2vVOaVWudDSzPUYRHQgWNAP1i7tV61FFnXRvw/RRBBrXhjn/V6XaHROAggVeyDocL60ISIh3Gj0K5Wp3ysvzfd/LHvp1G/KUQpqUiX3R/h8Nje09f64eyJ7T0KKPv80KPyIJC5/xLsunQ9SnWIWMFA08AOBQUbK9YHToxocZYQMqCyvsyo0Yc+PcjgOnOdD1w8jgn0aY6LV2T1FGMIwmkrjDKShO11dLIYmUxOdZqI3F87zdRPO8lK2U6js5Uqp9TwwnSLDfOGNn85pTOcSYKQbQqY/tfAHU95RHKf4vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fgxLeRoMVq+eQRHcKHxEwKP6XAnRjrBC80BqbrpzPw0=; b=enxr3QISxa8vDQMr+67eZs1WPMjnxwdBPnml9Bw6cL4fu43/nOs3DRVFTcy0CFDu7SdttTJdLnZaYsPIlgffcWhCIaN4rEincIYnV+MOi2q5lXt9Nmu8eAJvAWqapGkoFqaH0zNEdW5pa37CrVBJjo0NUDuNeJYR+bYeZyeDUrggaVs0d6hI3U5JhUVsuvO+r3cqymmBn6xK72BpMRpk6UgQH7qPtHoJh29ktGi2ErZrs3k+ew1ciG9Wi8AKqXu+x0YRvsMtvis5zLefNRojr48/i2kM1Kgu/fllJU91M9ZadXsJn1tLUR3d8atdbLFQ1JWlWyTMC9R+CDywoGIvgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fgxLeRoMVq+eQRHcKHxEwKP6XAnRjrBC80BqbrpzPw0=; b=BUKqpUUkOACyOINXvukMZNIbby4+1mDnNtnx9ovMIqkEqlTatacZNY6DIDsOMsuWrlxkcMm/PfeMWxbS2H6BOqFfzy9uMVNYi8JN6ZOpI1DFwb2m7OsdV1l9yOS8Ybh3wdbGVJ1N4EW4V2gU9TWw8zSCKeY5TrXws0PKLJhKXN4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW6PR12MB8866.namprd12.prod.outlook.com (2603:10b6:303:24c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.17; Wed, 7 Feb 2024 11:54:16 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7270.016; Wed, 7 Feb 2024 11:54:16 +0000 Message-ID: <310d05e8-561d-4bea-bb07-8efac3febc19@amd.com> Date: Wed, 7 Feb 2024 11:54:11 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] ethdev: fast path async flow API Content-Language: en-US From: Ferruh Yigit To: Thomas Monjalon , Dariusz Sosnowski , "Mcnamara, John" Cc: Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Andrew Rybchenko , dev@dpdk.org References: <20240131093523.1553028-1-dsosnowski@nvidia.com> <13882742.RDIVbhacDa@thomas> <2b0c7fe0-5713-4416-987e-34da0dc4aaef@amd.com> <2956397.VdNmn5OnKV@thomas> <00761c83-1843-420d-aaeb-d9e49329e191@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <00761c83-1843-420d-aaeb-d9e49329e191@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0053.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW6PR12MB8866:EE_ X-MS-Office365-Filtering-Correlation-Id: 115523de-77bd-43dc-b2a0-08dc27d38254 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VP0UWjemaJ2N6pkF03tnR//7a63ZFIKu6YQEySJvurLY5ugPs8rMUCY7pUsCSw4meSPByWEgRfdHL1njw4B90fyb5stObIV+/+BloQwwsxHp82uXS6UCCxJSb9cKqXZoqid/ZzaoKdjrqxfuy2oMdmBGSbQQ1VH5NW7LmvmW/8Yk+vbiVKN/uko3KRfL6Mbqleuq7AgLSgjM9vD/0hrYQns+WYszTAjh+nWaKCVWufFDYW74oeTN63n8SRdKXWhxOROXrFJVg6tKEasRwB8bnZqUKhTFLEPkI/lVUyxDV3rUGjeqoeEKwTsW1eue4/6gMJo3weWOm3w/LxxphXQhuPxaRtlN4PQ5d0O6NZCIuP6ajM7aiVSPS9g3lxRnwrl81oJAwgsf+hOF4mu2FIKK5UUaR9bPjmYpReEgsWHPWkSCU8CeEHsesmUUJkyznXbAiRULZkzybb1vbte+yn5Mqp1W9/GQxH3ocqDKW2oATZF0CPYyDZiRt5P/Zug/oPM4q9JwiAXw355wIj7mPhokZuRu9i647p7KkmFhrwvDX7/Mqpt8YqhSChgIdjYABD34oSo8VbZopXltYC1VR15+/UCto+Fi3IQ1G6xZgWyfKZdnFpS/pvQqBfGsVvEwaxiwIf023E9MkMkvTKXH+Wr/Xg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(396003)(346002)(366004)(136003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(41300700001)(86362001)(6512007)(110136005)(966005)(6486002)(66556008)(53546011)(6506007)(36756003)(478600001)(54906003)(66476007)(66946007)(6666004)(8676002)(8936002)(4326008)(316002)(38100700002)(2616005)(26005)(31696002)(83380400001)(5660300002)(44832011)(2906002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWtEbUdoaU5OSTNaVlErOGJzUGRMUWZnay83ekltaFpOQ2ZxaCtYWFRSekpR?= =?utf-8?B?MVlBRFZOVTJ1L1NKS2Jpd1Iva0wwTmoraUpEaC9SR0xyVG8rTHVPVmh5S2Vv?= =?utf-8?B?WFhaWGdjWHFyRTRwUTkrRjNpdlhmYzJlSkpGb3ZPcE9YUS80OFVhU3AyZTZF?= =?utf-8?B?NnJrZFQwMDdDOEJBQWQ1eU9lN2QzK3lVcTVRSXdMbmJVTVc5dmVabXB6a3NC?= =?utf-8?B?cDJZTWNJRWNZbTNncHVZYUwxM2g3b3RKRlp1RlpjVjhSY0NIWWVSbGZFbTdy?= =?utf-8?B?aTE4Z1p2cS9nZFlFTUwyZGc3NStQekdmdHBFK0lhNnhQT1hMbE1ycURNamUz?= =?utf-8?B?Uk1kcUNpYWRaV2c3M2w5MExxbG04NE1Pb05qWWlNa1ZRUHR5djlFYjdYR0Fo?= =?utf-8?B?Qk1jUzhuRHUvbjcwWEV1WERLb3ZSTUMvMlhSenV2TWZjS2oxMkJEL25XakVs?= =?utf-8?B?aE54T1Z3RjJTNm9rOTB1SnlaKzkwSXZoSFYraWEvVS9LVjNzemdwQ0xKeVNa?= =?utf-8?B?RmsxVjlsSnBDUStydEozUFI2U1J1RkRZeXFJSkh0TkRrUGZMMEtWalF5T0Q5?= =?utf-8?B?a1FIbWFLVlVhdHFRQ1RDTHdWLy96dURWZ0ZUZ1hmWU5ibjg1TVBpcS9RVVJ5?= =?utf-8?B?OVU1aitLdkJYbW1iczNSUS9hTWFLVFE0WHMybit0UlVGTkJlUkViWE9XeDd0?= =?utf-8?B?amprRFpDRkNWaGpSbzlHN3ZROVB1V0dxUk9xcnE3QXJRZVVJTERHaWRjRkZr?= =?utf-8?B?eWZqK0dQUGVIaG84eXNlZzVHRk0raHltMEJjdEU2bkhLT3BjWHdITitkcVli?= =?utf-8?B?Z2ZSeStXMUZIR29XWkVuQTRFTEEwM1hqcm9VK1FlQXQ4dzN5YkpDK2JzRnVJ?= =?utf-8?B?N2JGWVMvVHNOclZFQndZMHpNM2VabUFib0I1UXFuMjl6VnB6VzNVOU9oRkNi?= =?utf-8?B?eEI2WUttQ2pqYUxGY1RteURWZkRiZTlQY0Y3VS9CYkFyM2gzZzV1NmVmZU51?= =?utf-8?B?cFFJMElkY0xYY1Z5QnZaUHNhRHBSTkRnd0tUdjdDek0zUmRqYjZOeHV5Y3Y0?= =?utf-8?B?ZDRJT3l3aVVpYzlhVmNuaWE2NU9Pck03VkJsS0dxTXEzTFE4SzlzRVp6MUZI?= =?utf-8?B?dmFMejh6aTM2Z3lLdnZpdkNTaUNUS0gxUytDVjUyYzBHS0t3MHlnbmZCZGgv?= =?utf-8?B?NFJvU3Z3dkROUUoyenZZeFhKV1N2RnFncUhWcWNKRXJzSXUyMWtsd1ZPZExE?= =?utf-8?B?SUdVdTEzY0RrNG5YZ0F5S2dYZCtIU0lsZHczMlovSGQrYkdublVyZFU5OWFi?= =?utf-8?B?NGdkQzZpUkhvaUltY3JmRy9VU3FMWFpkaWV2WHQrQmk5Sjc2THRtQlBEalRG?= =?utf-8?B?cmhtOTRoZlBHRzNXK0NzYTh4akg1eEpiVVdTZ09IVWo3MDBHcE5USTlzdmIw?= =?utf-8?B?eXRGT2N0UE1hcDhiM093OGJRa1RYMzgrcnpETU5DNmhrYm1NLzZJOUEvbGxE?= =?utf-8?B?NnVqUXJuSHRtMVYydFllREZKV3V0WFRBUFJzUVlLNDROemxXeEdQUzVaTUlm?= =?utf-8?B?RmxCL25lR0ZUaWdTaEdnelpvN3M4dng1WGlpcVl2L3U1WXIwa1BCL0NrL2ZS?= =?utf-8?B?WWFwcWlnTVJFSURyRmoxZ29lUjJMU2dvT0FHRFZsV1ZTeXcxWHc2UndsWVFm?= =?utf-8?B?cWtYN3dFMWNiREcvSjhtQ2YranZmUG9QSE42a3FlcWtJbjBCVkJFcjVTYnFw?= =?utf-8?B?K1YxckpJemdaaDBYYmZFNE1lMDBVMHBYNXA0c1c1Z1VLVEt2U0lRdXRRaTE5?= =?utf-8?B?UE5VUjRuMVRqV1BkaTBCbWtRQi9YQ0tiSEVSVG9Bd2ZXR2dlTlhFOFdLSzVh?= =?utf-8?B?NkpORXpFblBvMllWUGRxKy9SZDhTZXhDVVBDQkpZYVRGZ1l2OXE3blZ4UHpm?= =?utf-8?B?ejBLb3VmRWlFVm9TUWM2aHpFZFdWUUFGMFdnR1VRZkFWTUV5SUhUYWxQaHU3?= =?utf-8?B?L1Y1b1BHTG9GL1IyZVlueUU5V2NvSDlWSWtnbGVzeko3ekFSZlJkQ0xJN3hN?= =?utf-8?B?dlBvbGN5a1FvaHhUZ2xtbjFyd2FmOFZPUDA4aHBxamRkL0JGZ1ZiRitIOWpF?= =?utf-8?Q?ZwGJ5S7vs1gBJixMDikN0gC04?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 115523de-77bd-43dc-b2a0-08dc27d38254 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 11:54:16.1842 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eqwGTUecbqp2sW8BkW8RqvFbHVWXXpuZ9xYb1nztEyE0O2ooWo1TPwH1LR6PAlLI X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8866 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/7/2024 10:56 AM, Ferruh Yigit wrote: > On 2/7/2024 10:47 AM, Ferruh Yigit wrote: >> On 2/7/2024 9:27 AM, Thomas Monjalon wrote: >>> 07/02/2024 01:57, Ferruh Yigit: >>>> On 2/6/2024 10:21 PM, Thomas Monjalon wrote: >>>>> 06/02/2024 18:36, Dariusz Sosnowski: >>>>>> --- a/doc/guides/nics/build_and_test.rst >>>>>> +++ b/doc/guides/nics/build_and_test.rst >>>>>> +- ``RTE_FLOW_DEBUG`` (default **disabled**; enabled automatically on debug builds) >>>>>> + >>>>>> + Build with debug code in asynchronous flow APIs. >>>>>> + >>>>>> .. Note:: >>>>>> >>>>>> - The ethdev library use above options to wrap debug code to trace invalid parameters >>>>>> + The ethdev library uses above options to wrap debug code to trace invalid parameters >>>>>> on data path APIs, so performance downgrade is expected when enabling those options. >>>>>> - Each PMD can decide to reuse them to wrap their own debug code in the Rx/Tx path. >>>>>> + Each PMD can decide to reuse them to wrap their own debug code in the Rx/Tx path >>>>>> + and in asynchronous flow APIs implementation. >>>>> >>>>> Good >>>>> >>>>>> --- a/doc/guides/rel_notes/release_24_03.rst >>>>>> +++ b/doc/guides/rel_notes/release_24_03.rst >>>>>> +* ethdev: PMDs implementing asynchronous flow operations are required to provide relevant functions >>>>>> + implementation through ``rte_flow_fp_ops`` struct, instead of ``rte_flow_ops`` struct. >>>>>> + Pointer to device-dependent ``rte_flow_fp_ops`` should be provided to ``rte_eth_dev.flow_fp_ops``. >>>>> >>>>> That's a change only for the driver. >>>>> If there is no change for the application, it should not appear in the release notes. >>>>> BTW, API means Application Programming Interface :) >>>>> >>>>>> + This change applies to the following API functions: >>>>>> + >>>>>> + * ``rte_flow_async_create`` >>>>>> + * ``rte_flow_async_create_by_index`` >>>>>> + * ``rte_flow_async_actions_update`` >>>>>> + * ``rte_flow_async_destroy`` >>>>>> + * ``rte_flow_push`` >>>>>> + * ``rte_flow_pull`` >>>>>> + * ``rte_flow_async_action_handle_create`` >>>>>> + * ``rte_flow_async_action_handle_destroy`` >>>>>> + * ``rte_flow_async_action_handle_update`` >>>>>> + * ``rte_flow_async_action_handle_query`` >>>>>> + * ``rte_flow_async_action_handle_query_update`` >>>>>> + * ``rte_flow_async_action_list_handle_create`` >>>>>> + * ``rte_flow_async_action_list_handle_destroy`` >>>>>> + * ``rte_flow_async_action_list_handle_query_update`` >>>>>> + >>>>>> +* ethdev: Removed the following fields from ``rte_flow_ops`` struct: >>>>>> + >>>>>> + * ``async_create`` >>>>>> + * ``async_create_by_index`` >>>>>> + * ``async_actions_update`` >>>>>> + * ``async_destroy`` >>>>>> + * ``push`` >>>>>> + * ``pull`` >>>>>> + * ``async_action_handle_create`` >>>>>> + * ``async_action_handle_destroy`` >>>>>> + * ``async_action_handle_update`` >>>>>> + * ``async_action_handle_query`` >>>>>> + * ``async_action_handle_query_update`` >>>>>> + * ``async_action_list_handle_create`` >>>>>> + * ``async_action_list_handle_destroy`` >>>>>> + * ``async_action_list_handle_query_update`` >>>>> >>>>> [...] >>>>>> --- a/lib/ethdev/ethdev_driver.h >>>>>> +++ b/lib/ethdev/ethdev_driver.h >>>>>> @@ -71,6 +71,10 @@ struct rte_eth_dev { >>>>>> struct rte_eth_dev_data *data; >>>>>> void *process_private; /**< Pointer to per-process device data */ >>>>>> const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ >>>>>> + /** >>>>>> + * Fast path flow API functions exported by PMD. >>>>>> + */ >>>>> >>>>> This comment may be on one single line. >>>>> >>>>>> + const struct rte_flow_fp_ops *flow_fp_ops; >>>>>> struct rte_device *device; /**< Backing device */ >>>>>> struct rte_intr_handle *intr_handle; /**< Device interrupt handle */ >>>>> >>>>>> --- a/lib/ethdev/meson.build >>>>>> +++ b/lib/ethdev/meson.build >>>>>> +if get_option('buildtype').contains('debug') >>>>>> + cflags += ['-DRTE_FLOW_DEBUG'] >>>>>> +endif >>>>> >>>>> This looks OK. >>>>> >>>>> Acked-by: Thomas Monjalon >>>>> >>>>> >>>> >>>> Acked-by: Ferruh Yigit >>>> >>>> Applied to dpdk-next-net/main, thanks. >>> >>> Ferruh, I was expecting a new version. >>> Did you address yourself the comments above? >>> >>> >> >> No, I missed the comment, if it is simple I can apply in next-net, let >> me sync with Dariusz. >> > > As we synced with Dariusz, there is no good place to document > ethdev-drivers interfaces in the release notes. > > Also this release there were more ethdev-drivers interface changes, > around get_ptype(), but those also not documented in the release notes, > so will remove these ones too. > Dariusz, I did the changes in next-net, can you please double check them: https://git.dpdk.org/next/dpdk-next-net/commit/?h=main&id=23f1ee71a9c332210aaa5b1ec51160938b5fc50b