From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 74EC71B1CF
 for <dev@dpdk.org>; Tue,  9 Jan 2018 14:49:10 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 1115F20A7E;
 Tue,  9 Jan 2018 08:49:10 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Tue, 09 Jan 2018 08:49:10 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=VeXU4sfVedYE3+V25s0sOdeUY7
 crRFKj5HJXlvyomRU=; b=A4wLcEwp+bUPTUeKuctzphIuKKVRMdbVdsBE1X1e+H
 q7aTP1633oCEsgNUZUXu3eUDwNv1Pj83FeuMlkT+L79dYV8h+Cc1cEYkzOl85SiN
 ei/IodIy4CGygfxd2LlJj1or5qvLhPtpy8h+1cg3QQVWub+MHodhvLFFwMCfcV85
 o=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=VeXU4s
 fVedYE3+V25s0sOdeUY7crRFKj5HJXlvyomRU=; b=XF7QvYNoGVphCw2OWmOG1y
 nlY68rSUT/5U+W1g2UCyhYyXvROk+dvNFe9P7wq1ox4ucnWzrZyRj2sC3gH2KGTo
 NrBqCx61H6Tu0diV2brNaQjdA8ln+VQeCD83ZNWhymRKtko0OzDRdrGkQYfP1RYa
 ZTnM8zQX9HEzYG+yx8V49vp5/ke9BoocCOFhNnX1d4ubbtxOoiIzL1Ea7mB6FKNj
 /LuHa2RbE6n8KGkYWW9FAw8SzlbTXUOcrU5dABsqOo4eS7vx+dtgSZ0FGMyjMB4w
 D/U2i+YFxErXq0jKmzg9t+QDz27N4vhqvAeQsXgLNXUv3aH2xvhCff9v4omvtXlg
 ==
X-ME-Sender: <xms:VshUWok9gpeibQWYPa0qMq5HZi0rvCuPOfMDPwHW4rfIl8hgY3jSew>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id B42EB2470D;
 Tue,  9 Jan 2018 08:49:09 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Xiao Wang <xiao.w.wang@intel.com>
Cc: yliu@fridaylinux.org, tiwei.bie@intel.com, dev@dpdk.org,
 stephen@networkplumber.org
Date: Tue, 09 Jan 2018 14:48:45 +0100
Message-ID: <3112517.GnCYoIETns@xps>
In-Reply-To: <20180109132654.3504-4-xiao.w.wang@intel.com>
References: <20180109142651.84582-4-xiao.w.wang@intel.com>
 <20180109132654.3504-1-xiao.w.wang@intel.com>
 <20180109132654.3504-4-xiao.w.wang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v8 3/5] net: add a helper for making RARP
	packet
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jan 2018 13:49:10 -0000

09/01/2018 14:26, Xiao Wang:
> +/**
> + * Make a RARP packet based on MAC addr.
> + *
> + * @param mbuf
> + *   Pointer to the rte_mbuf structure
> + * @param mac
> + *   Pointer to the MAC addr
> + *
> + * @return
> + *   - 0 on success, negative on error
> + */
> +int
> +rte_net_make_rarp_packet(struct rte_mbuf *mbuf, const struct ether_addr *mac);

I think we should apply the new policy of introducting functions
with the experimental state.