From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D81504371A; Wed, 20 Dec 2023 10:37:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9E9F40291; Wed, 20 Dec 2023 10:37:43 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 2911240266 for ; Wed, 20 Dec 2023 10:37:42 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id DCEA13200AAB; Wed, 20 Dec 2023 04:37:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 20 Dec 2023 04:37:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1703065057; x=1703151457; bh=zUsFsJOGvECOSxoSDDIWhFCbQTTiOqHIBBi5cVksbf0=; b= pHi0wDBoOK0I7iFDR/gAZQC/GWtKp9uDnbbfNgo0sZdJTDmQxS6zfXVLK6PwqjqS a/nSL2TgqJ/GfuMlObqod+rrmJ/xqb/OijNt0vJVQiE5Ee4uCqK3arIHwAX62hDT eHUWwOa+tlwvsxV64LxO2DbAz1Gd7Q5/5vf9Sa49QhyJ5TxnpqVIttigizlVEgDH P+35Hlz9hqRUGErREbYJ/5JCPIbOIopHtNgOI8byWmh2/DQGk2/btw4SZiCPbx/f VCxksybug3Zg3JzMxCC4yiXz3zkDpqg/cXGxDM/4lbZ8VYAT9O1+EMPQEkZ/X2eg 00GqyLXcmvzsF1q4YZDR4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1703065057; x= 1703151457; bh=zUsFsJOGvECOSxoSDDIWhFCbQTTiOqHIBBi5cVksbf0=; b=C XWLst1VVcHnLPHETK5cQhMMWN1g4BQ/IMyDJCxR2fvziazyijU5WAIeQsfsQa7pN etiSV94u2k5/AZise2/Wl2NRozwUepxLKhRFedMVDXWLItVqyEWzophqUllKHqzW k8pQszCnSE1MheaVx6boD39CP95WwhkDil0MQDG1qxUDlWH5QZxeiwqr6rYfB5Wu 9hMNUnjd/S4+0LXpWBGMU8I/TDjk8k/Gf/0Z2CPrv+7uaeY9/ys+XqQpqf0Dcx2h ScRnIrFlgQ9gNsgIM4K2uYpKYlPylr2Efb0ltWxu6aVQH8Lg4o8PKl+Xs5TUk3Ow TRrVlNHGTeAmAJXYGGllw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdduvddgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeeltdeltdetkeevvddutdeiudelveefuddugeetleduteelhfef keefueevleevueenucffohhmrghinhepphhmugdrnhgvthenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Dec 2023 04:37:36 -0500 (EST) From: Thomas Monjalon To: Harman Kalra Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dev@dpdk.org, jerinj@marvell.com Subject: Re: [PATCH v2 24/24] doc: port representors in cnxk Date: Wed, 20 Dec 2023 10:37:34 +0100 Message-ID: <3113395.8hb0ThOEGa@thomas> In-Reply-To: <20231219174003.72901-25-hkalra@marvell.com> References: <20230811163419.165790-1-hkalra@marvell.com> <20231219174003.72901-1-hkalra@marvell.com> <20231219174003.72901-25-hkalra@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/12/2023 18:40, Harman Kalra: > +The CNXK driver supports port representor model by adding virtual ethernet > +ports providing a logical representation in DPDK for physical function(PF) or > +SR-IOV virtual function (VF) devices for control and monitoring. > + > +Base device or parent device underneath these representor ports is a eswitch > +device which is not a cnxk ethernet device but has NIC RX and TX capabilities. > +Each representor port is represented by a RQ and SQ pair of this eswitch > +device. > + > +Current implementation supports representors for both physical function and > +virtual function. A doc comes with its implementation, so no need to say "current implementation". > + > +These port representor ethdev instances can be spawned on an as needed basis > +through configuration parameters passed to the driver of the underlying > +base device using devargs ``-a ,representor=pf*vf*`` > + > +.. note:: > + > + Representor ports to be created for respective representees should be > + defined via these representor devargs. > + Eg. To create a representor for representee PF1VF0, devargs to be passed > + is ``-a ,representor=pf0vf0`` > + > + For PF representor > + ``-a ,representor=pf2`` > + > + For defining range of vfs, say 5 representor ports under a PF > + ``-a ,representor=pf0vf[0-4]`` > + > + For representing different VFs under different PFs > + ``-a ,representor=pf0vf[1,2],representor=pf1vf[2-5]`` It looks like something we should describe globally for ethdev, instead of driver documentation. > +In case of exception path (i.e. until the flow definition is offloaded to the > +hardware), packets transmitted by the VFs shall be received by these > +representor port, while packets transmitted by representor ports shall be > +received by respective VFs. Not clear. How is it related to any offload? > +On receiving the VF traffic via these representor ports, applications holding > +these representor ports can decide to offload the traffic flow into the HW. > +Henceforth the matching traffic shall be directly steered to the respective > +VFs without being received by the application. Using "these" makes no sense here. Please prefer "the representor ports". > +Current virtual representor port PMD supports following operations: Again, no need of "current". [...] > +---+------------+-------------------------------------------------------+ > | 2 | NPC | --log-level='pmd\.net.cnxk\.flow,8' | > +---+------------+-------------------------------------------------------+ > + | 3 | REP | --log-level='pmd\.net.cnxk\.rep,8' | > + +---+------------+-------------------------------------------------------+ > + | 4 | ESW | --log-level='pmd\.net.cnxk\.esw,8' | > + +---+------------+-------------------------------------------------------+ Why it is not aligned? > --- a/doc/guides/nics/features/cnxk_vf.ini > +++ b/doc/guides/nics/features/cnxk_vf.ini > @@ -64,6 +64,8 @@ mpls = Y > nvgre = Y > pppoes = Y > raw = Y > +represented_port = Y > +port_representor = Y > sctp = Y It should be in alphabetical order.