DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Huang, Wei" <wei.huang@intel.com>,
	"Xu, Rosen" <rosen.xu@intel.com>,
	"Gao, DaxueX" <daxuex.gao@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Zhang, Tianfei" <tianfei.zhang@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Huang, Wei" <wei.huang@intel.com>
Subject: Re: [PATCH v1] raw/ifpga: initialize variable to avoid compile error
Date: Wed, 16 Mar 2022 10:40:52 +0100	[thread overview]
Message-ID: <3116003.mvXUDI8C0e@thomas> (raw)
In-Reply-To: <CO1PR11MB5011CA05C368BEF89F6913A79D119@CO1PR11MB5011.namprd11.prod.outlook.com>

16/03/2022 10:27, Gao, DaxueX:
> From: Wei Huang <wei.huang@intel.com>
> > 
> > Compile failed with cflag optimization=1 on Ubuntu20.04 with GCC10.3, it
> > reported vendor_id and dev_id may be used uninitialized in function
> > ifpga_rawdev_fill_info().
> > Actually it's not the truth, the variables are initialized in function
> > ifpga_get_dev_vendor_id(). To avoid such compile error, the variables are
> > initialized when they are defined.
> > 
> > Signed-off-by: Wei Huang <wei.huang@intel.com>
> > Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > Acked-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> 
> Tested-by: Daxue Gao <daxuex.gao@intel.com>

We need a "Fixes:" line to help backports, please.




  reply	other threads:[~2022-03-16  9:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16  7:26 Wei Huang
2022-03-16  9:27 ` Gao, DaxueX
2022-03-16  9:40   ` Thomas Monjalon [this message]
2022-03-16 19:34     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3116003.mvXUDI8C0e@thomas \
    --to=thomas@monjalon.net \
    --cc=daxuex.gao@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=nipun.gupta@nxp.com \
    --cc=qi.z.zhang@intel.com \
    --cc=rosen.xu@intel.com \
    --cc=stable@dpdk.org \
    --cc=tianfei.zhang@intel.com \
    --cc=wei.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).